Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 14 Apr 2022 08:52:31 -0700
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        Miroslav Benes <mbenes@suse.cz>
Subject: Re: [PATCH 09/18] objtool: Add stack validation cmdline option
Message-ID: <20220414155231.2kkpwl5oq2saef5t@treble>
References: <cover.1649891421.git.jpoimboe@redhat.com>
 <a13c502a91ae0bef8dfeb502d7dee88e73039355.1649891421.git.jpoimboe@redhat.com>
 <YlferZa7SP6hVgcA@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YlferZa7SP6hVgcA@hirez.programming.kicks-ass.net>
Precedence: bulk

On Thu, Apr 14, 2022 at 10:43:25AM +0200, Peter Zijlstra wrote:
> On Wed, Apr 13, 2022 at 04:19:44PM -0700, Josh Poimboeuf wrote:
> > +	if (opts.stackval || opts.orc || opts.uaccess) {
> > +		ret = validate_functions(file);
> > +		if (ret < 0)
> > +			goto out;
> > +		warnings += ret;
> >  
> > +		ret = validate_unwind_hints(file, NULL);
> >  		if (ret < 0)
> >  			goto out;
> >  		warnings += ret;
> > +
> > +		if (!warnings) {
> > +			ret = validate_reachable_instructions(file);
> > +			if (ret < 0)
> > +				goto out;
> > +			warnings += ret;
> > +		}
> >  	}
> 
> Doesn't SLS also depend on validate_functions() ?

Doh, I had the intention of splitting that out from validate_branch()
like I did for ibt.

-- 
Josh