Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Fri, 15 Apr 2022 15:55:04 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Russ Weight <russell.h.weight@intel.com>
Cc:     rafael@kernel.org, linux-kernel@vger.kernel.org, trix@redhat.com,
        lgoncalv@redhat.com, yilun.xu@intel.com, hao.wu@intel.com,
        matthew.gerlach@intel.com, basheer.ahmed.muddebihal@intel.com,
        tianfei.zhang@intel.com
Subject: Re: [PATCH v2 4/8] firmware_loader: Add firmware-upload support
Message-ID: <Yln3yCsPK9Za2jbu@bombadil.infradead.org>
References: <20220415200805.610339-1-russell.h.weight@intel.com>
 <20220415200805.610339-5-russell.h.weight@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220415200805.610339-5-russell.h.weight@intel.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Fri, Apr 15, 2022 at 01:08:01PM -0700, Russ Weight wrote:
> +EXPORT_SYMBOL_GPL(firmware_upload_unregister);
> diff --git a/drivers/base/firmware_loader/sysfs_upload.h b/drivers/base/firmware_loader/sysfs_upload.h
> new file mode 100644
> index 000000000000..a72d0e82e107
> --- /dev/null
> +++ b/drivers/base/firmware_loader/sysfs_upload.h
> @@ -0,0 +1,41 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __FIRMWARE_UPLOAD_H
> +#define __FIRMWARE_UPLOAD_H
> +
> +#include <linux/device.h>
> +
> +/* Update progress codes */
> +enum fw_upload_prog {
> +	FW_UPLOAD_PROG_IDLE,
> +	FW_UPLOAD_PROG_RECEIVING,
> +	FW_UPLOAD_PROG_PREPARING,
> +	FW_UPLOAD_PROG_TRANSFERRING,
> +	FW_UPLOAD_PROG_PROGRAMMING,
> +	FW_UPLOAD_PROG_MAX
> +};

This is all looking good to me, thanks for all the work and testing!
Can you just add kdoc entries for the above as well?

Other than that:

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

  Luis