Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp1035251pxb; Fri, 15 Apr 2022 19:06:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQ5e01Xzb/MLKQKzgZ3vJezg0+WptTTOwpiVxDDSbHw9+NjiotFoh8WJ4OdNP3CiDEyx1H X-Received: by 2002:a05:6a00:24cf:b0:505:d9fd:e415 with SMTP id d15-20020a056a0024cf00b00505d9fde415mr1584687pfv.78.1650074787255; Fri, 15 Apr 2022 19:06:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650074787; cv=none; d=google.com; s=arc-20160816; b=SCLqTxKfYYjh0MF6TlEFlMGV0x+38be9///QP/48YfrpJd7F2FOya43gC+000roeJo +TCZzXvWu2OFiL7xveC+wTNqWfKs+LdhRQrLZAH7+1rps7cnVF2KC/RilBfEkkXim+pV 0rADTWPhqVumwcz7aCoASMOT/A2Q+kpANjbE2+tMLkeNX1hitdjaow9zFNNCvCc1BCG5 SF85DFr8jl4SH2pIxvpnycaf4ZpLwmvGZ+eZj7EU5ZW4OvYCJhcz77sra1Z1J3yQ22a9 6zHhP7JJfdt1PKhcGLHr2U7iY/0tc/az5EWYmnE640USBulXc0Gr2b5ZsrwD+i6xymjZ nZdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Z5tq7WhsfYCtbsBpe6vYTV676bSOimMfYuf424iszwE=; b=zbOSE2YYpKVELl5Uag5R+WR+N1OSi00lzvCkCHYLPKLPAzBm+JRBKZJswe9oN5iFuB vR6EhgVOvh+tnBoKMFczTYRuQTWhOsI+ygGtq/mtFTZakVENHWCdTRbMESzJk3O7cOiv Kk9W89QNMoqsqA6OJhVp5y0njlsjBK+vMD2qzNGbN4w4qTA5AY4Wjeau+hr+fUzSbIHl /k+mPeJfM56/PEJwGoz+93b+qBwBr5F1s3I+UIcFP8l+H0BVGzt91jn+sHB1tgsjJz0k bT5wwpWmaWWBOdk+5Z63UJVCTzP2CTIjX/51x7xwGvpsdb2hqbQ9q3hasMjKlTgwKSIj geEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="aV+e6hc/"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id l19-20020a170902d35300b0015826677457si2569341plk.354.2022.04.15.19.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 19:06:27 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="aV+e6hc/"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 792BA117CAD; Fri, 15 Apr 2022 18:24:55 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347757AbiDOTET (ORCPT + 99 others); Fri, 15 Apr 2022 15:04:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347623AbiDOTER (ORCPT ); Fri, 15 Apr 2022 15:04:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E014D9E9B; Fri, 15 Apr 2022 12:01:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ED8FCB82ECD; Fri, 15 Apr 2022 19:01:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 850EBC385A5; Fri, 15 Apr 2022 19:01:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650049305; bh=Z5tq7WhsfYCtbsBpe6vYTV676bSOimMfYuf424iszwE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aV+e6hc/YF4o11T2Oms1tvdnTdFOUTPWcEW2d9B7X47iV5IgdOvthDZQHzb5HZQ23 9l9KaD4MeUZOiH7SzithuFtnSoeUlv/o4Lpo4YyDME41z7B501NpoJGiFkRmF45BSM jpyxJ9WXisbunkgGL0p8RFCpAeZzaW27PAt61aO7Tgz+/sbSDIzh8zAgrIZysp6OF2 gXBQs2I8YNN814UlqT3gGxH2hBVzNxDKl6FI3DfLXH/QscMkcUyHAP2eGpbQs4Qbps AiCzVD3nGWDsUYP0xIhez7Mqfq6z9PNYNpuBjq7MXu6z9N8bw9SSf6ikHavUmvlaZP xz1wDzi1VbD+w== Date: Fri, 15 Apr 2022 21:01:39 +0200 From: Jakub Kicinski To: Horatiu Vultur Cc: , , , , Subject: Re: [PATCH net] net: lan966x: Make sure to release ptp interrupt Message-ID: <20220415210139.2d338f4b@kernel.org> In-Reply-To: <20220413195716.3796467-1-horatiu.vultur@microchip.com> References: <20220413195716.3796467-1-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Apr 2022 21:57:16 +0200 Horatiu Vultur wrote: > When the lan966x driver is removed make sure to remove also the ptp_irq > IRQ. I presume it's because you want to disable the IRQ so it doesn't fire during / after remove? Would be good to have such justifications spelled out in the commit message in the future! > Fixes: e85a96e48e3309 ("net: lan966x: Add support for ptp interrupts") > Signed-off-by: Horatiu Vultur