Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 15 Apr 2022 09:20:01 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Haowen Bai <baihaowen@meizu.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4] staging: rtl8192e: Fix signedness bug in
 rtllib_rx_assoc_resp()
Message-ID: <20220415062000.GP3293@kadam>
References: <4370787.8F6SAcFxjW@leap>
 <1650003325-26568-1-git-send-email-baihaowen@meizu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1650003325-26568-1-git-send-email-baihaowen@meizu.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jjfbv8s9jmsirQNxO5wHwRrjwGccq8ns13juOF6BBBydFkHTUYWq4kAAMvus?=
 =?us-ascii?Q?F5Ga/DEEPZZGjqlWliE1BdLLKK7eYmIXdH68bPHI2aMWgwB3jLxF761TYOAo?=
 =?us-ascii?Q?+xTVQHoOYqMYD5xWP2hdLk1UuBFJV5kbwyx8RDuWQgXhjHuYATEAozog439y?=
 =?us-ascii?Q?c/fyEnQS0d5bhZ8VRgV75jvEUEZZFkiGHNXGiw8htdMqlbEpfQ/XmWkdenAi?=
 =?us-ascii?Q?FoTjLV07uj6HWHgrqt+niv6coF+Q1aUTeCEDgixQ84yr6QhXlZppNz6+dWMb?=
 =?us-ascii?Q?Rx8f8XjiPG7bT5wTGRvGdZ3by5pV+riCRM+/PB8Gq0je+lT7yH/qW+sWBybo?=
 =?us-ascii?Q?Kz88zlvJPOtY7PqvMzH4Mz0c9S7JXdXku2mxUrVizPt1rwJt4xLCyba9IoF/?=
 =?us-ascii?Q?CtNoTEE9vfM9aq8VXfyGkTqAppV9HYzJ65pOkwwbEDxMOBkymd/iQzdRbzS6?=
 =?us-ascii?Q?Pc4PT2wdpQL362wqVk6Nl/WNSxWd8BizLDPJOyX820FZxUM5WQzkv2o+FDVz?=
 =?us-ascii?Q?Z9QzCCjna6Xbi3G1F5EPv9Y2ObctGop0BhedMiV30VEVjTg0k0n5OnfZLQ+t?=
 =?us-ascii?Q?fmIh0TS+aZlEfOi5OgyI1OvIj2aGdW+PQCEgf3eyYNl0hBCtmySqZTfQ6/9S?=
 =?us-ascii?Q?Y8H7rRi3pr3XCDfpbTB/Jwl/j+/MFBVHmv2ePWRcVove6ZJj3PIitQpsgfm8?=
 =?us-ascii?Q?jeoS9XFPGOPIJ6+9JyXo1dULrYy4WvUx9z0+5zs/D157uDmge6Fv1QglAjtq?=
 =?us-ascii?Q?IGKVSC51R67FqvIBEN8OVi6GsYnBFbE7d0wjUe+jLHQTp/OBRoWOarsSPhoG?=
 =?us-ascii?Q?xd9jx0I9tC6gTitvHYswutT19auBMWeqYvRt/ex+SR6QciLdyDdAZp98coQs?=
 =?us-ascii?Q?QFMWDUbQxBi3loR7tOQh9Ko1Rz8xMjGCYziEz5CLCqiZ15DBVxTJ3jTjDq23?=
 =?us-ascii?Q?zq0SjgEpnysjbsoMEaXPKXs/bjzlEfqDMF69JPmXFMyuUYafV9SeEQdFXLlA?=
 =?us-ascii?Q?yQ7I7a3AIlpYvMF7ayVupYF4JK8xOGQwhHMvGIMjQvebepexdAhbnCX89ch1?=
 =?us-ascii?Q?K+383EWyejbU2xc4EhOp8X/1OEJ7cNk3CtAD9PD77/n/6VE5+KAerjk8NHNM?=
 =?us-ascii?Q?E4j7NrbdoeXRRPlWjsDlhaws0BhPaZD0GWbb+Ke2gu4RK6V63nuoqgx91WvZ?=
 =?us-ascii?Q?BvXHTcHnBUg1eH70Lr5pvwEdERBVY4PCUSw8hB1lazEZ1TG5aKzuXibUOsDH?=
 =?us-ascii?Q?I5UvB6AkDV9YDbjOQ8Msn/I/nEIgi4DWhAPGCo1VHME6QpGCerZM4Jp3SCIn?=
 =?us-ascii?Q?81Q9i7CowyZy5A122z8P4X9izeku5o5lTtGaXAaJR5KRQop2X5EofO1Sx6LG?=
 =?us-ascii?Q?lH+BO3bSNhziO8Hq7F3xTHzTtBcx8AxfraPwqnXqy8WrUycg5kkYuXzmlGrO?=
 =?us-ascii?Q?dZtOiPQKPhZE7uEtfA6FDswBlVkzIJHRPpkbdW2HNhNNuliB4e5yNEgoub4P?=
 =?us-ascii?Q?AmOALRAjyTmjUXg8Qqk32S8eiY/d63UfyTaMGTuuNXq1SLp7gFlHrQf1yQWN?=
 =?us-ascii?Q?pLrylfA2DkfZPNSK0i1ASNG0jST3CBN03ko85rCNlUOBNyty0Dq+F7jp/xMf?=
 =?us-ascii?Q?BTmpBVdz5OMu8fyuww1vVnFDzMwVM2vL9CMhYPF1oWWvWMLcBgw9QSnMhSg5?=
 =?us-ascii?Q?8cblKxAaz7aXaEWGkK+RWuCcqsAIJ7Mh3WTDJBGVHO4Xhv2CHllKDygPYjOr?=
 =?us-ascii?Q?byxa8wfMz8tTuJ9X5gedky/nXNwtGcs=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fb031ac-3721-48c5-440f-08da1ea7fef4
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2022 06:20:11.6357
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HwyKXnQMSUXuVfnlYB4gQZVPVnhbgx3zUGGTj2Qzdd3yv4DZBWQNqRhPsJjz1tPsji73DKLBS/iE0LGu1qmfF+Auqsk8QxzeldIZhcHPIQs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4896
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-15_01:2022-04-14,2022-04-15 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 malwarescore=0 mlxlogscore=999 spamscore=0 adultscore=0 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204150038
X-Proofpoint-ORIG-GUID: 7I8NavlYDlK5bb58BjEAqaK_8MaVVWAc
X-Proofpoint-GUID: 7I8NavlYDlK5bb58BjEAqaK_8MaVVWAc
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 15, 2022 at 02:15:25PM +0800, Haowen Bai wrote:
> This commit message suggested by Dan Carpenter as below:
> 
> The rtllib_rx_assoc_resp() function has a signedness bug because it's
> a declared as a u16 but it return -ENOMEM.  When you look at it more
> closely it returns a mix of error codes including 0xcafe, -ENOMEM, and
> a->status which is WLAN_STATUS_NOT_SUPPORTED_AUTH_ALG.  This is a mess.
> 
> Clean it up to just return standard kernel error codes.  We can print
> out the a->status before returning a regular error code.  The printks
> in the caller need to be adjusted as well.
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> V1->V2: reduce return random value; print its own error message.
> V2->V3: change commit message; change s16 -> int.
> V3->V4: add message suggested by in title.
> 
>  drivers/staging/rtl8192e/rtllib_softmac.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 82bf05eb1cbf..4a1b9a94930f 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -1764,7 +1764,7 @@ static void rtllib_softmac_check_all_nets(struct rtllib_device *ieee)
>  	spin_unlock_irqrestore(&ieee->lock, flags);
>  }
>  
> -static inline u16 auth_parse(struct net_device *dev, struct sk_buff *skb,
> +static inline int auth_parse(struct net_device *dev, struct sk_buff *skb,
>  			     u8 **challenge, int *chlen)
>  {
>  	struct rtllib_authentication *a;
> @@ -1773,7 +1773,7 @@ static inline u16 auth_parse(struct net_device *dev, struct sk_buff *skb,
>  	if (skb->len <  (sizeof(struct rtllib_authentication) -
>  	    sizeof(struct rtllib_info_element))) {
>  		netdev_dbg(dev, "invalid len in auth resp: %d\n", skb->len);
> -		return 0xcafe;
> +		return -EINVAL;
>  	}
>  	*challenge = NULL;
>  	a = (struct rtllib_authentication *) skb->data;
> @@ -1787,7 +1787,7 @@ static inline u16 auth_parse(struct net_device *dev, struct sk_buff *skb,
>  				return -ENOMEM;
>  		}
>  	}
> -	return le16_to_cpu(a->status);
> +	return a->status;

See previous responses.

regards,
dan carpenter