Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <9dfffc57-4733-37c9-5668-97b06a40a202@intel.com>
Date:   Fri, 15 Apr 2022 13:53:20 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [Intel-wired-lan] [PATCH net] ice: Protect vf_state check by
 cfg_lock in ice_vc_process_vf_msg()
Content-Language: en-US
To:     "Keller, Jacob E" <jacob.e.keller@intel.com>,
        ivecera <ivecera@redhat.com>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>
CC:     Fei Liu <feliu@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        mschmidt <mschmidt@redhat.com>,
        Brett Creeley <brett.creeley@intel.com>,
        open list <linux-kernel@vger.kernel.org>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
References: <20220413072259.3189386-1-ivecera@redhat.com>
 <YlldFriBVkKEgbBs@boxer> <20220415183845.51a326fe@ceranb>
 <CO1PR11MB5089695CB3733F4B1284E3CED6EE9@CO1PR11MB5089.namprd11.prod.outlook.com>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <CO1PR11MB5089695CB3733F4B1284E3CED6EE9@CO1PR11MB5089.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEg1MHNLNWg2STlwdjN5d1hOZW5LaVpKSkpyNVJ4bXlSd2F1aUIwVkFROUhP?=
 =?utf-8?B?RHpxOGZyTzFZbkw2TUJKRHdxcEVDOGpQSk1QL0FqQThUV01uNUl4dCt3bklT?=
 =?utf-8?B?enNhaUtyWHRIb0RlWG9VUjlyTER5WkkvdWdsQm5RbGFUSS9VUjhzS2NiR3k2?=
 =?utf-8?B?MElWejdVUHBDUFU1L0ZKWUtJdlQ3YUJsTm0wbTB0KzBNTGtDanp3QVBNRlly?=
 =?utf-8?B?T2huVVdHWE1hdEdSd3E4aVNGMHRLRUN3MkwyS0xseWdxdVVRM3hTYm5zZm1q?=
 =?utf-8?B?MkJFNkRsdE5kK2wxYllEMW1tWlN6aklwdy9qUFhWdUhJd0dvMU5MU05QTzJK?=
 =?utf-8?B?b05SdHk0bWU2OGM5S2NQY3dDeW9kWUs2OERqb1k4WjIzOHJtYkVUMWJqVEt6?=
 =?utf-8?B?SnZLNmRVcWdabWpuMllvSHNVTEtaZ3g1MnRFMHczdDdNakRwVC9xK3ZpT2pP?=
 =?utf-8?B?am1sK2FRN0V2L0hsS2VHTkNvMzhQQWkwRmVsVlBmK0YwV2JEMnhxdHVRK25F?=
 =?utf-8?B?SnphSWhjZEx1emMvK1RKUUpiU2Y2dTBCMmdvTkdKc2ZGcHRTbUtUY0Z4UWdZ?=
 =?utf-8?B?SWdCNllvUHNFdXloRGhoUGJXNlFmR1lWRHo2dmtBbEFZa0cxYTNFaG1ucjNH?=
 =?utf-8?B?Mng2TnpRNWtOQmNTdDhqWitkM2Q1VEFxQnhCOXM3KzhydXUvdXJsa0Y2eDc4?=
 =?utf-8?B?eUYrcGZ3Z1cvVGpwRFEzQ21Xb1RqMFBUdUJmdzNTbURQY0FNVXk3RXJwMG1r?=
 =?utf-8?B?UjVKTWpZa0ltSXVzSTNLSHRqS1RmTUdicGpyeVRYTW13OWdVQXMvU21XczdB?=
 =?utf-8?B?Tjk3dDVIQXZYTnJpdjBJWjVUTk5TYUpPRDhLbS9VNHl6blZCR1NpdUNKU2Yz?=
 =?utf-8?B?Q0wvaHRLOXpHSjZlSE5QUEZxS0hYREwrODhISkpLUEQzc25idFRicXVFcVRs?=
 =?utf-8?B?MForSjAwTmRDUDErUjNocHliOHQ5ZWk3TFpIMFJUMHNOWjhBQVl4R0R4eWFz?=
 =?utf-8?B?WUNPY0N1Njk4ZFU2b2NyRGRmMUE2VkxJYjN2VitzeEpVSVRGb0hXMytCMU5O?=
 =?utf-8?B?a0gzNHVLci9qQmNoNTRSZlZuNFJwbHZuQ2o1MEk5L0ZXSmxzSm5iMzdUZUZi?=
 =?utf-8?B?UmJqOUJtYnh4a0VzMVd6alR6KytwMjRzZGc2ZlhsRjRsSDV0Qk1CclpVN3lz?=
 =?utf-8?B?eEFBUjVTdUZPM0JwN0lYNFIxSytVdjB0ZXBzZnZtdEI0bDNReW1BamZ0Umpw?=
 =?utf-8?B?S0syZFdtTHpIVktDQm96NHdqVUJ3QXBSYkc4djFFdUtIMkFYaHZ3bHVIcG1n?=
 =?utf-8?B?TW00a3RoeGhvT0NuejhqdkdEN1l1OVhXVzQ5UkRBb2t0R2NDZ3NscVQ1OE83?=
 =?utf-8?B?ZEJsZGZGVDV5dTMrdWhoR3RWaUdoMEhnWDlseW1aTnJ1RzBBTkd6UExjZVZp?=
 =?utf-8?B?bVVIVE5HL05aUVEvMWt0QmJOTmw5RFNvMkpJWHl4Slg2Z3dNQTgrSDZKcEVZ?=
 =?utf-8?B?M0dWcUZJMk54YmxzN3g1b2hDdHkrSWhyS2pka2JaWmJCSUs4OVhLOUV0eHBK?=
 =?utf-8?B?emdpUGs5NEhGVFlidmRzVWNwdER3OEpvZS9CWjhudk9sU2txN1UwMkoxS2Ft?=
 =?utf-8?B?cXF0U0p3cjlyUHlBY3cvK3dMRjVHVEpvODVDSGNscGFkNXFmekEwSUdUd0ky?=
 =?utf-8?B?dUVrYjZEcjJnNXRNN0lUSmxkVnZ3cE5oYXl5UUFoRHk3dDFGN3FLdjZUbVBa?=
 =?utf-8?B?V3RCSUtLQTIyTmZhajNCWjVjQnpBSFQwQ1k2VnNiVGF3TXQvekxCN1h2NlEx?=
 =?utf-8?B?N0ZBWFN1SFFqK0ZLRGhna25tQTI4TzNqNEZHem1zZ1Zmd3ZEaGM5c0swRjRD?=
 =?utf-8?B?L1ZxTVU4aEpQMXpqL1JqMW5Ja25oUTBBdDFRREhCNEZUQmFTOUZmN2lWU2RB?=
 =?utf-8?B?S3R0SVlXY2V6ZHJkZ0Q5N1JESjJOSVVVc0NYV0R0Zzl5V3Jsc29MQ0RBbjRs?=
 =?utf-8?B?RWZNSnh4Y3Q5a0NocWhMSXZzZTUvUHMvQW5kbFFmcHFNanNnb3gvVkEyMFpm?=
 =?utf-8?B?VVZxL1p0SFk2WjRqUlNjdVkrb04veUlMNHRJdU0yeWJwc3dxZE4vbnFxdkFR?=
 =?utf-8?B?ZGtrbGdqdkNMNjNrelNKWjZNTk5Jd0ZCRkNIUkRMSmc4MmhUK2xyYXhlQkg2?=
 =?utf-8?B?UDdVa1lVL1ZPRnh0MEFvQVFjQTA1eFpOWG4zcU1NOXJ2SXA3RHZrMU1kc2V0?=
 =?utf-8?B?dFZFSWJhTjJUNlBSUWpFTkFzTlA2aE5XWmFxbDJmVHBEUHJsc2Fnc0xESHNB?=
 =?utf-8?B?M1FtWDcxSTgxamdhdHFWNG84TTFKNGxOWThlWTNkWDZkQjdFSFJaYmRtN3lN?=
 =?utf-8?Q?0RMEGg8qnZuQGHUo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e9dbe087-0454-4315-2e78-08da1f21fb31
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2022 20:53:23.7220
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NrsyFdKE4jX4R65/Dyzy8CQYv8y4KOU+nr3rAGDpVQGHV43DvLi8y4AejlrPowyf246a9+ucNecyselSpyeDuRGfddISvMxM99OPOmyt1FU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5337
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/15/2022 11:31 AM, Keller, Jacob E wrote:
>
>> -----Original Message-----
>> From: Ivan Vecera <ivecera@redhat.com>
>> Sent: Friday, April 15, 2022 9:39 AM
>> To: Fijalkowski, Maciej <maciej.fijalkowski@intel.com>
>> Cc: netdev@vger.kernel.org; Fei Liu <feliu@redhat.com>; moderated list:INTEL
>> ETHERNET DRIVERS <intel-wired-lan@lists.osuosl.org>; mschmidt
>> <mschmidt@redhat.com>; Brett Creeley <brett.creeley@intel.com>; open list
>> <linux-kernel@vger.kernel.org>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
>> <pabeni@redhat.com>; David S. Miller <davem@davemloft.net>
>> Subject: Re: [Intel-wired-lan] [PATCH net] ice: Protect vf_state check by cfg_lock in
>> ice_vc_process_vf_msg()
>>
>> On Fri, 15 Apr 2022 13:55:02 +0200
>> Maciej Fijalkowski <maciej.fijalkowski@intel.com> wrote:
>>
>>> On Wed, Apr 13, 2022 at 09:22:59AM +0200, Ivan Vecera wrote:
>>>> Previous patch labelled "ice: Fix incorrect locking in
>>>> ice_vc_process_vf_msg()"  fixed an issue with ignored messages
>>> tiny tiny nit: double space after "
>>> Also, has mentioned patch landed onto some tree so that we could provide
>>> SHA-1 of it? If not, then maybe squashing this one with the mentioned one
>>> would make sense?
>> Well, that commit were already tested and now it is present in Tony's queue
>> but not in upstream yet. It is not problem to squash together but the first
>> was about ignored VF messages and this one is about race and I didn't want
>> to make single patch with huge description that cover both issues.
>> But as I said, no problem to squash if needed.
>>
>> Thx,
>> Ivan
> I'm fine with either squashing or keeping them as separate changes.

Either way sounds ok to me as they are different types of changes.

Thanks,

Tony