Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220415004622.2207751-1-seanjc@google.com>
In-Reply-To: <20220415004622.2207751-1-seanjc@google.com>
From:   Oliver Upton <oupton@google.com>
Date:   Thu, 14 Apr 2022 18:05:29 -0700
Message-ID: <CAOQ_QsgxyM2SQNuaWaoPD8pj5Mwk0bt15TS=i7=Yc1OFG=fdAQ@mail.gmail.com>
Subject: Re: [PATCH] KVM: Initialize debugfs_dentry when a VM is created to
 avoid NULL deref
To:     Sean Christopherson <seanjc@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
        syzbot+df6fbbd2ee39f21289ef@syzkaller.appspotmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Sean,

On Thu, Apr 14, 2022 at 5:46 PM Sean Christopherson <seanjc@google.com> wrote:
>
> Initialize debugfs_entry to its semi-magical -ENOENT value when the VM
> is created.  KVM's teardown when VM creation fails is kludgy and calls
> kvm_uevent_notify_change() and kvm_destroy_vm_debugfs() even if KVM never
> attempted kvm_create_vm_debugfs().  Because debugfs_entry is zero

Boo! I've got a few patches to bring kvm_create_vm_debugfs() in line
with the rest of the VM initialization. Kinda gross it is done in the
ioctl body.

> initialized, the IS_ERR() checks pass and KVM derefs a NULL pointer.
>
>   BUG: kernel NULL pointer dereference, address: 0000000000000018
>   #PF: supervisor read access in kernel mode
>   #PF: error_code(0x0000) - not-present page
>   PGD 1068b1067 P4D 1068b1067 PUD 1068b0067 PMD 0
>   Oops: 0000 [#1] SMP
>   CPU: 0 PID: 871 Comm: repro Not tainted 5.18.0-rc1+ #825
>   Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015
>   RIP: 0010:__dentry_path+0x7b/0x130
>   Call Trace:
>    <TASK>
>    dentry_path_raw+0x42/0x70
>    kvm_uevent_notify_change.part.0+0x10c/0x200 [kvm]
>    kvm_put_kvm+0x63/0x2b0 [kvm]
>    kvm_dev_ioctl+0x43a/0x920 [kvm]
>    __x64_sys_ioctl+0x83/0xb0
>    do_syscall_64+0x31/0x50
>    entry_SYSCALL_64_after_hwframe+0x44/0xae
>    </TASK>
>   Modules linked in: kvm_intel kvm irqbypass
>
> Fixes: a44a4cc1c969 ("KVM: Don't create VM debugfs files outside of the VM directory")
> Cc: stable@vger.kernel.org
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Oliver Upton <oupton@google.com>
> Reported-by: syzbot+df6fbbd2ee39f21289ef@syzkaller.appspotmail.com
> Signed-off-by: Sean Christopherson <seanjc@google.com>

Looks good, grats to the bots for finding my dirty laundry.

Reviewed-by: Oliver Upton <oupton@google.com>