Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Yihao Han <hanyihao@vivo.com>
To:     Claudiu Manoil <claudiu.manoil@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH] net: ethernet: enetc: Add missing put_device() call
Date:   Fri, 15 Apr 2022 06:36:33 -0700
Message-Id: <20220415133633.87127-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JltwIAmYaIQhS8eU8TH+WCSU9jr4bBRgLOuZOA/hvOy7rGTLHCBCLp1suzeo?=
 =?us-ascii?Q?R/T627xSGWtJoMMGpAGMrEquQNl4Ti//k+e/rwAhyeSjIGQNopdShkSEXXDG?=
 =?us-ascii?Q?0c01tF1B7smllDxe5B77SkwbAfBNAtlAfksf6Itnp3a+IXmFDAGzGzMxwCgN?=
 =?us-ascii?Q?s0BixCF3DGYewtNCvl3aN0kINnkzVqjO+mzCvSbLHbKySkNYD/auxerBlJGv?=
 =?us-ascii?Q?qnSMWdUax85/2LAes5QDmbtZC8ZTfI4hiyYXa1qhebQZo3m3S8j7X3Gb2Ewb?=
 =?us-ascii?Q?iBxOx41o9XMT2NMP9dlbYirvNGHzMjLK7IVX/01RkwH9SiuHHuaCjrHELkGl?=
 =?us-ascii?Q?AY4dzVf7FE8xahS0TsNcJ9PvC4bNLyD6NSYfvgWlKiC9zHW8MrmOAWkoSapz?=
 =?us-ascii?Q?uq7oZf7zjI189/yb0SU0xUF++FQZ8Mzh5FZgbWXFJQGvxJ7e/b2eFXpnMTha?=
 =?us-ascii?Q?10zFsHWBm4wQx9IlG2Ahp63/oL2kXh1nylIUY3wtAawDbRS5rDce9fXuyEaO?=
 =?us-ascii?Q?YO1Gi0tgr1sX4fzFtvRJrHIWagja+y6OzhFHsSDMfNwvDPbYRMNbkoCmbSxd?=
 =?us-ascii?Q?gOKkkNxaBpgyEhxb/1avCZFhZKJu3Vz+nq6gq+GVS1URAM6gA9LLjeJkR8Ra?=
 =?us-ascii?Q?4YkMIabXuoctiWVDlreFbc0sKQlyRjJD1j4hH7aFOP5V56tW0zX28cEZNXWS?=
 =?us-ascii?Q?HfuExV/woa/gw5nEuzrdH8AEL7VUHpmdeNvIcfUCJnfzbXLkAC8Dce2bzlTt?=
 =?us-ascii?Q?6r5Jqlrs92egWUQ0uHgDgQUbulWUHXAD+hnPIZbIgPMZUeyTD2/vAEjscDKm?=
 =?us-ascii?Q?rZZjGL8wG9Yf6vyAsJXaHPRQ+WT+YbZKx8AgW2EXY8iM6JKC/vjXL8Gjk82G?=
 =?us-ascii?Q?XcEq0Gkhk1YK39yIujxsCCVQaWoJd6FhqqdF8/8P2OkZeW55bxPoIzIXSAjG?=
 =?us-ascii?Q?FqlKaLAZIaddJ0hW9EfVyJIWE5xTsX3lgMRd7V8ngUO1AGBTJOb+1JCUDV82?=
 =?us-ascii?Q?Ev2mIu2Mke8rQMhzoxKw7zXd0grbsfjCPDk2k4FJJx+/6C/g5RoVAje8q2J/?=
 =?us-ascii?Q?AByLD1RqT6F6e84zZvB7UMEp1Heme4J4ehtd/AHjF66o5MV2qbijkHq0w2p5?=
 =?us-ascii?Q?XR8nIDh0eAnjl+o6zaX8YmGcbWR45CssZcj3CDepCJQkfFdjdLItIwVjHAiC?=
 =?us-ascii?Q?h7Y3LuHD8AhUGfLsaF7PqLDrBbjzh3F7kDbvUcddPKkpsj5Xfg6QHf1RePhh?=
 =?us-ascii?Q?TUkueD73GWIAJFqSdX3tTK1G4BjY3/SAMvZteQrwxYWZv6SLFJPsQxRLAbYZ?=
 =?us-ascii?Q?G6dDI5n8InXNzVHpyNbUDbIC6CxgMHciGCX+9t9OZm6hftHbRf7UMfU5y8lC?=
 =?us-ascii?Q?sjk5IjCH24HXEzWx5M4CS52PiY8wfy4KK9kMV+S+mfkX5S5Flf45PBmhUkrS?=
 =?us-ascii?Q?/XmRT54FXx6Wh4y9pvlZyi1l/ZLGsFabo02RXhxJE/PoL4pF2fTAQCYU3ilQ?=
 =?us-ascii?Q?E69ARnnYLR45VZB2X01+7onXkNJ5RPF68rY2o/xVwnB0P/lUxfeNDrBWLfly?=
 =?us-ascii?Q?mPjDhTf8RNQRy0CEakukc1//PHZezWeZCMslYbTc/5qhkFw2FvXkv3l0xjjl?=
 =?us-ascii?Q?n79Fy5l9yWKVrbo52ajkpzCRZy1J8uAfyGJhI20vnEl8tUsFDiqYf8Jk1876?=
 =?us-ascii?Q?RdX8DzoRtC/UDDeMdMemEjrwwCKnnQrVmjKmTTo6ZEX5EGLN/f/fAtCsnV7C?=
 =?us-ascii?Q?APnSHtGhsw=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49cab372-572a-4d7c-225f-08da1ee4ff41
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2022 13:36:51.1900
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eMzUuIPHxnQCHLkZuYO9gHdqcMes5qJilkgQi2DPvxeyZZhBnCqL0VI+nfzsC2kXeee3FJOhsGYcMJGHOKAa3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB2329
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

A coccicheck run provided information like the following.

drivers/net/ethernet/freescale/enetc/enetc_pf.c:1180:1-7:
ERROR: missing put_device; call of_find_device_by_node
on line 1174, but without a corresponding object release
within this function.

Generated by: scripts/coccinelle/free/put_device.cocci

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/net/ethernet/freescale/enetc/enetc_pf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pf.c b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
index a0c75c717073..d6e18afda69a 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_pf.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
@@ -1177,6 +1177,7 @@ static int enetc_pf_register_with_ierb(struct pci_dev *pdev)
 	if (!ierb_pdev)
 		return -EPROBE_DEFER;
 
+	put_device(ierb_pdev);
 	return enetc_ierb_register_pf(ierb_pdev, pdev);
 }
 
-- 
2.17.1