Received: by 2002:a19:f614:0:0:0:0:0 with SMTP id x20csp57724lfe; Fri, 15 Apr 2022 19:21:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUYtDhcDID6BqZXVh24/Ydo12tRqEbJPkCBa0Y8QmC3sUYJ+hZ7CDn5h1wrOs71Te7Wlie X-Received: by 2002:a65:6b92:0:b0:39c:c97b:1b57 with SMTP id d18-20020a656b92000000b0039cc97b1b57mr1385686pgw.517.1650075692265; Fri, 15 Apr 2022 19:21:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650075692; cv=none; d=google.com; s=arc-20160816; b=M4Ko2OF1YgNNjtIQbltXwynhaBXYtDolpsfOUIpwzM0sSYEhuS1oFxp9IXHjho/Ma9 Mwqktp57ACyVOnrZn35Y4GHNPX6kltyrELdbJNzZNu9xmVLQBgSCzdByoa6oswK6ABui yQhVd5vteoxbk1Z1qU98PwevLF6GCutU7m3jjjx7VLku0cGSHoNRxpr7UwYy9wdneqRz dH2LXlMgh4TOHy9mkwpTo1cZ0ZVpI7Q/mHBqOfRxB2BWTWe7Hk5ueBxrYDFX/nV3OfcK ITLjX6D07b0kBK4hwTo/YmhrzBu0nObR+npvDgJR8+wTHAAQNsuoiyPv56i66aFQthmN ZJiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=Y5lAtzXMg+ppnAbSv6Q3GxiwRfJLdMdWeI1FfICWONs=; b=FcC4xUGi8u1OnfVoGQhsD5xvHopuVF1tLpIqDPiQjdvh0WtQbYip3l7XejDb7dkpFA tF0p2Y/WLN2HHnSwBrz+0B3MBXb15itXsn/nAV5SODeETgF31JjOS9ZbTOvuiVJO93Hr 2X2NQCv1Fe+fu7b/Az7N08Ix4cMSB06jqRj5zKoOUwSIoBlVzPgjZLzq5/LmlgQtx8SY JaCM3xyq6v5byd5TN/q0GWzSOpkWbGCVq7bLntp55DdHlWEBtrQGhP8MuFHe34UcsDoU RJ1NnjMQv9R/HLlLMuYiICnyH0D9pp+V26DJfmy8DIrOBjDm+Hrnu2QjW+Ylpbrip8nl lVIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=o9fimpV6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id u190-20020a6279c7000000b00505fa6023fasi2904774pfc.154.2022.04.15.19.21.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 19:21:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=o9fimpV6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 925C935AA2; Fri, 15 Apr 2022 18:35:13 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353680AbiDOMpB (ORCPT + 99 others); Fri, 15 Apr 2022 08:45:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351470AbiDOMpA (ORCPT ); Fri, 15 Apr 2022 08:45:00 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82809263A for ; Fri, 15 Apr 2022 05:42:32 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id v12so7055147plv.4 for ; Fri, 15 Apr 2022 05:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=Y5lAtzXMg+ppnAbSv6Q3GxiwRfJLdMdWeI1FfICWONs=; b=o9fimpV6GpiP3IeJuO1eZov9gqi31/QclX7nLI3lfbAW776Q5//E67iXr7kMcV+uaF 1WA583e0yHlyPzanmTt/VgrhVUYQtqSpaedKTpXuusp1y4gO9TKpWiksCCqO/CZTi052 UqYxbayNcHMPdqsOI+H4yi/3jk+Q603ErV7f94mnYeFr8BNQmSJUyZcdxHckYeHRdfWi g2IQQYaP4wKxEy/+W83yEcCbPNqfwS8s1nKJq5zU8QQCkK2JuoVqghI+DCbvMByVk9/M ry7x0pkr+XlhEddS9+MgnU2sX9vwqdnsdoSC+3YYj6N5nzUBnKsrCbJRkf1/WQKqqb2B cXcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=Y5lAtzXMg+ppnAbSv6Q3GxiwRfJLdMdWeI1FfICWONs=; b=C7q9xQ/gpDnoD0x4ogfOYdSrWoIh202XE0Q2jR1xD4Jqpz58yYVBz2cy0O7eyo4X7v 96PKyB6Oae/psj3u1Smc5YszWbgkUu53WaKdccGZkBCi8ylTV/aX6M4gM2lzLC5AXc6H BAJPbPHo5t6lUmiTHt4SHLIpouZKHKTOZ++itVM1WtuljmqggXdCs0N84f5DtThRDRJj hcLwX13KSdQcM8eHvJkA3HIWQv+Yc1dvAdOAdRxnCABj0Iuao+N5fBAm2pWBxN7aaoG+ 9LsiI83WABODTdrguFGI3K7EacstCUbYt3p7Rr+B7/rfZiINdyye4ZRs7V3zs1i6fpAv LK/w== X-Gm-Message-State: AOAM530yYtesnJw8RachDpN18WXsWKINvWfNsJkYyTibJ76r0MufQhvh GeQhAZSr0p5Tq/sBRfx0YWuNl9XKzYXkqg== X-Received: by 2002:a17:90a:5407:b0:1bf:43ce:f11b with SMTP id z7-20020a17090a540700b001bf43cef11bmr3999585pjh.31.1650026551772; Fri, 15 Apr 2022 05:42:31 -0700 (PDT) Received: from [127.0.1.1] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id j13-20020a056a00130d00b004f1025a4361sm2987102pfu.202.2022.04.15.05.42.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 05:42:31 -0700 (PDT) From: Jens Axboe To: khazhy@google.com Cc: linux-kernel@vger.kernel.org, bvanassche@acm.org, linux-block@vger.kernel.org In-Reply-To: <20220414224056.2875681-1-khazhy@google.com> References: <20220408234707.2562835-1-khazhy@google.com> <20220414224056.2875681-1-khazhy@google.com> Subject: Re: [PATCH v2] block/compat_ioctl: fix range check in BLKGETSIZE Message-Id: <165002655078.10530.5825902345538532925.b4-ty@kernel.dk> Date: Fri, 15 Apr 2022 06:42:30 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Apr 2022 15:40:56 -0700, Khazhismel Kumykov wrote: > kernel ulong and compat_ulong_t may not be same width. Use type directly > to eliminate mismatches. > > This would result in truncation rather than EFBIG for 32bit mode for > large disks. > > > [...] Applied, thanks! [1/1] block/compat_ioctl: fix range check in BLKGETSIZE commit: ccf16413e520164eb718cf8b22a30438da80ff23 Best regards, -- Jens Axboe