Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Yihao Han <hanyihao@vivo.com>
To:     Shahed Shaikh <shshaikh@marvell.com>,
        Manish Chopra <manishc@marvell.com>,
        GR-Linux-NIC-Dev@marvell.com,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH v2] net: qlogic: qlcnic: simplify if-if to if-else
Date:   Fri, 15 Apr 2022 05:09:49 -0700
Message-Id: <20220415120949.86169-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?er6HrqUYb5OkrnzLuMSFqhJsiVQge3xO/h1Rkmkzxwv4aYnNzzAg+PqlZsKI?=
 =?us-ascii?Q?feZtP9jmC4GT4xifDd+L0AmhldfJCmRb/r35IBTsZUbgtyVcVeuXpLJb+CNo?=
 =?us-ascii?Q?k79uGSevA4RHag8lM7MTph/r3YHqNabdyaxNHOhJlq4grL3AEu8BB0muZTMX?=
 =?us-ascii?Q?D7++HouZDWsW9AEZgFj1VOi24cO53NrawV6eVQ99IaT2TzpFvyfHDReSPyOc?=
 =?us-ascii?Q?rxnFuy6zXFoq9XoQOsV6MVPQ+k0JKxAc0Ss3yFI5zBwH5yGz83ps28CPeFFe?=
 =?us-ascii?Q?orpLy7P9ABkCBMWn6cZPyl7Js+aaBmtLsr4NPWIA5fb9T40v5nuhVxltsdN5?=
 =?us-ascii?Q?Rhb0esLmDMfRPJLOkBSCk4VmL1/h1dNes4OQKdd3nnSuFnvnnHTeS1C3LWKj?=
 =?us-ascii?Q?XSPq5TkaVPvC8USN3tTGHy9bSEu7xHJ4+X8UatOP+Kiva2gjTKMwgto8lmsx?=
 =?us-ascii?Q?D4ryRaKPEDdqRWfdP2Tz7h+3GYjNsCQCP/xBByxXpShjFGCBmD9jAeEodckg?=
 =?us-ascii?Q?38hhoKqV+GgkEHew9T1xV3jNpNUUznzs5a4xm1lQIyqXxMyRUoR8fMLP3XIa?=
 =?us-ascii?Q?r91zq+EzZQf43WuDznyed/7aq42lcxudfTN5sAHYFUOSDSazDt5uXSA9SdIt?=
 =?us-ascii?Q?8zHzRwf5gTLpN8aIgMYfD1pLnxcA8pOqhlVBhZCmhz65eAK3EM1noGn17oWy?=
 =?us-ascii?Q?HpHb7hIR7kVNnpZj3M2qnW+bIRuBI8JtxSX3e9myeiLhqi8Xc6cJf4sPox89?=
 =?us-ascii?Q?OywziOz4TdEaxXFuBI696tVL3048EUH6rl026eWfp6t7bLzT+4JAOjzWb6KK?=
 =?us-ascii?Q?I2Klu2e6E4Nfht1nUUfQzXlwLftLX9+0hwesT3UYpiJdMQATZE7L8Sme+d6J?=
 =?us-ascii?Q?LlBEYxJMncxkMe91qIKSlnhd4VKruznnWWTU8V87qZsp9qd9W7TiJKrybCI/?=
 =?us-ascii?Q?QiY18ZXBZe4BsMQiWMqkdNvipO9URSXUS07lKJrFjdWhtCVdEk82M4fihGpX?=
 =?us-ascii?Q?F7uKIQF08mx2ZHgpFqUajYrdUpPzN+IxxBoDLBgRi7DaVE3diHL7dvKXfDAB?=
 =?us-ascii?Q?ljOHx/9HNHBvNtQ6FqSYN/KaCOB67y5yr5LWv3vCyjbxgbj5yvjAmD9Kv9qh?=
 =?us-ascii?Q?tplHb7AUi9T/jM8tFrZ53H26mOoqiPdba/qyQ+/GDGy0veaiJt8mGZzbDJZr?=
 =?us-ascii?Q?wiLpDxSQlgBMA9N21xKqXRNSSnMtl1EEwqsdb0LIHJOK+pkeNYSSiXmhTB6/?=
 =?us-ascii?Q?aRIxeqTezM1iuera6AUPVakn3WxJkC3i+Bj+Pp4iiY9eq4Zp4JQr1/AJvpxt?=
 =?us-ascii?Q?yIn1jefzstrIfaDq2uJdGfDmWPdkPhPQHEKvCAX1HGxPGhXrFNMqWLpkFHgZ?=
 =?us-ascii?Q?LjAC53PbfXnt8tJOqoEmMXdNwrUOrhuDC6rBJl4DSXGX/EJ6q/GI0MmUZ7rg?=
 =?us-ascii?Q?p1Qikd1xzw5ls0Lk8mVTpHbtlK253B3PwVi6/vEU2oVq/8K0hjmBVu4tBcEK?=
 =?us-ascii?Q?elfLbnSxc+PKo+v3dSOUTdobbryr/iifYsI49O/NkcEabO6ce+AnuzLZDDLS?=
 =?us-ascii?Q?ncH6EB1dQVRXL/1HucGX1j5iL/rY2/SI96SuaJoch7wknLGehHJiE5/MLRgZ?=
 =?us-ascii?Q?IUGKt1kU0/pmrWNLoqEHjHe1uJq/pBVIHEYc49KmmR0XB2fFKfVw2CgUN9c7?=
 =?us-ascii?Q?sFxCfB/R5XTXU0nyktkNByg9/gj5T7APNUcgyu0Erm9Z6K7TfFQ9Xg6DrVUi?=
 =?us-ascii?Q?j2D6HA2R4w=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6057960-55f2-4986-9525-08da1ed8df49
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2022 12:10:03.5820
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ave+atBXLmUSEthf0XhQVEF5XBclHB5g/VXPC98CL3J5IyolTkQ7YMl9RYStWi9zlBZLB+dbQL7BnTJmx55Fig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4444
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Replace `if (!pause->autoneg)` with `else` for simplification
according to the kernel coding style:

"Do not unnecessarily use braces where a single statement will do."

...

"This does not apply if only one branch of a conditional statement is
a single statement; in the latter case use braces in both branches"

Please refer to:
https://www.kernel.org/doc/html/v5.17-rc8/process/coding-style.html

Suggested-by: Benjamin Poirier <benjamin.poirier@gmail.com>
Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
v2:edit commit message
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
index bd0607680329..e3842eaf1532 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
@@ -3752,7 +3752,7 @@ int qlcnic_83xx_set_pauseparam(struct qlcnic_adapter *adapter,
 	if (ahw->port_type == QLCNIC_GBE) {
 		if (pause->autoneg)
 			ahw->port_config |= QLC_83XX_ENABLE_AUTONEG;
-		if (!pause->autoneg)
+		else
 			ahw->port_config &= ~QLC_83XX_ENABLE_AUTONEG;
 	} else if ((ahw->port_type == QLCNIC_XGBE) && (pause->autoneg)) {
 		return -EOPNOTSUPP;
-- 
2.17.1