Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 15 Apr 2022 09:18:52 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Haowen Bai <baihaowen@meizu.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] staging: rtl8192e: Fix signedness bug in
 rtllib_rx_assoc_resp()
Message-ID: <20220415061852.GO3293@kadam>
References: <20220415053116.GN3293@kadam>
 <1650001836-25956-1-git-send-email-baihaowen@meizu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1650001836-25956-1-git-send-email-baihaowen@meizu.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qMv1Fqmw73e5AWX+xocwEkPzx+kKDvAvYqtY1O52sOE0O5J6B285zSQxWfIZ?=
 =?us-ascii?Q?Au0eKv7s24hekWga11zplFy+Psdop/FrM4fe+VqyRGIpT8L354MI0zygTpVF?=
 =?us-ascii?Q?2SW3F+8EV54vpRTEz6e36SfrUBry2N2bhXHGBCWSjXFHctP6rLjeFD5V1Ohc?=
 =?us-ascii?Q?3Fhals3sHM1I6FoIh1sz+c5kYMQZKaOWbq8e5rHTRjPhUDvTYza5GQ9OdRrx?=
 =?us-ascii?Q?KTDKXYkX8K33dMBKIRv8Sq1PDMKLyaNAuJZ4ySPC/fnoQG8ZmRGYq5yI3BcE?=
 =?us-ascii?Q?nCBfc3q5Q0/Hr9pLfM57CLhQJg9zoQpB83hHROiAJRWbBHnE4PoP/nybwesl?=
 =?us-ascii?Q?Ro63u9P6EinyVBo44RgGDlEvW2PI5WM5FWGDTowp3GolonX2FYmK2CRO8HJo?=
 =?us-ascii?Q?YCVKeqMzOc9X3KGQOXWkvoUeS2216sGaQKVkbRVPuYhyd8WziHPD8f9/XCFr?=
 =?us-ascii?Q?uHX0fLnNZ3+hphd+m09lLaNVUYnIKTSHpJ/taAo7pGctgSFnIKcyfIhp1chQ?=
 =?us-ascii?Q?wt559De6YWoazCHpJW49Uy1uqD7qwoTXWwpJ+z5jL7/jzZGIiHrXtoUWt3fY?=
 =?us-ascii?Q?gun0YF9P1eT26G0V8OG3O1l3YnR7ziFF0uGcE5HdYdEZTypsToV7rXKDqPGm?=
 =?us-ascii?Q?lQAiHnecLo9z5vuN+SIfF1InN3nCZmqeMeYsy2EI/w7jvI4O3u2dBpmJ02OD?=
 =?us-ascii?Q?ongSi5dPmvhi5apFZ5mBYPiSzE9aJ9igBggoWuMCO6s3GYDhgqMH4R3EbkAH?=
 =?us-ascii?Q?OhauwCIOxmb0pt1NQqPzVLjewhclKwCDkq4uruv5q6pdhsn6fipnZ2fQ4xoA?=
 =?us-ascii?Q?+QXECIWJYCgBHpxy6uWFjW9aa94MxFnYXivNWNSUEpII/CZQpTiEZQlME5vL?=
 =?us-ascii?Q?TacJKHBEeDr3cygbFoNlGd1wzWR+wJy/2AMJUUHmqi4InnHfgHJxSJNwAkw+?=
 =?us-ascii?Q?9xmlgVZfmjYCtDwN7PP8GH4bY4NiXMDN2PbsuxOOOqLjkQ0ULITJ+Rz50qbW?=
 =?us-ascii?Q?OutG/w5scnvajPy6vpxvW0xDKCPMoRWGP2tTlLg3GrLE97K6YCozKQCtixhM?=
 =?us-ascii?Q?7mAIzJ14x2G/SVQOgH1Y85x/YTHtsqmZEdtylmWh0uL4XNlwfihh8hOf8fsC?=
 =?us-ascii?Q?gIU0yYntySTZFLKJjet27OF97PjAgSpTUgz3cIUfkdsTWim/wQx9Y6KJqXws?=
 =?us-ascii?Q?RXjOdrgmnzGW3rF/3TtdwacvIoRzT8VnMopj9JfkPe2poxU+r1QNsKkyWCaN?=
 =?us-ascii?Q?qsrFQBxWTxoTdNW4W+q4vmsLEQ+4KBYzjdobcmoxJfrfnEMjlCbmKkiTM6FL?=
 =?us-ascii?Q?ZeYTN8vgPFFrxlW2TdihG5PqkN2iG1XUpn4bN8ScavS3BWIfWr1/WTCruDh4?=
 =?us-ascii?Q?E9LHQLecKCdtilUnWkSVTUpd/7wU+RevdYGnq05IJcad1M6G/Khy3jt5ndFF?=
 =?us-ascii?Q?Gy3qojZELmyhYgWLTtqC4WEDdjFU11OV5l653Q5Ub0fyKIEQs6jIZNHz3WQI?=
 =?us-ascii?Q?UDR0vWVb9SVPhlD/B0iM4+qHcb3lQkjISp8m1+BvygcUk+q8yv4ZBet+1uRt?=
 =?us-ascii?Q?BfVqmIAdutH3jLmPYDNi4T96Vnojnv6dmO15uhT60SwERx2x/9vK37HusnUn?=
 =?us-ascii?Q?1poNp7DYCDpAiQ+N1GbxbEPaaE0mTk5OOmQrcF5PW8CAxY5u+g/+Kbe0L4kd?=
 =?us-ascii?Q?j+gtXVsK958FVhzuMgQ5AR9Ke1vgz+cry3pvr913HIFQXXtt5v7CQ8gFSCuI?=
 =?us-ascii?Q?qzhXiBN8Pz3INmYjTcGdM//gPuxCRsY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45e88d17-50bb-4e2d-d80f-08da1ea7df13
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2022 06:19:17.9368
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DR/Xt16Jkwffnwhcho1OjzaTuSEgL49qEcrbCVu0q6FFdc/N0D/DSUPBN/yQDjyV/7m8cellhhPyVY5h/qQHOZAMLf4co8rYzoKVgzGWyrI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4896
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-15_01:2022-04-14,2022-04-15 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 mlxscore=0
 bulkscore=0 phishscore=0 spamscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204150038
X-Proofpoint-GUID: w09keAvkP5fTbJqUieZ2M6qEdBLrteOj
X-Proofpoint-ORIG-GUID: w09keAvkP5fTbJqUieZ2M6qEdBLrteOj
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 15, 2022 at 01:50:36PM +0800, Haowen Bai wrote:
> The rtllib_rx_assoc_resp() function has a signedness bug because it's
> a declared as a u16 but it return -ENOMEM.  When you look at it more
> closely it returns a mix of error codes including 0xcafe, -ENOMEM, and
> a->status which is WLAN_STATUS_NOT_SUPPORTED_AUTH_ALG.  This is a mess.
> 
> Clean it up to just return standard kernel error codes.  We can print
> out the a->status before returning a regular error code.  The printks
> in the caller need to be adjusted as well.
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> V1->V2: reduce return random value; print its own error message.
> V2->V3: change commit message; change s16 -> int.
> 
>  drivers/staging/rtl8192e/rtllib_softmac.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 82bf05eb1cbf..4a1b9a94930f 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -1764,7 +1764,7 @@ static void rtllib_softmac_check_all_nets(struct rtllib_device *ieee)
>  	spin_unlock_irqrestore(&ieee->lock, flags);
>  }
>  
> -static inline u16 auth_parse(struct net_device *dev, struct sk_buff *skb,
> +static inline int auth_parse(struct net_device *dev, struct sk_buff *skb,
>  			     u8 **challenge, int *chlen)
>  {
>  	struct rtllib_authentication *a;
> @@ -1773,7 +1773,7 @@ static inline u16 auth_parse(struct net_device *dev, struct sk_buff *skb,
>  	if (skb->len <  (sizeof(struct rtllib_authentication) -
>  	    sizeof(struct rtllib_info_element))) {
>  		netdev_dbg(dev, "invalid len in auth resp: %d\n", skb->len);
> -		return 0xcafe;
> +		return -EINVAL;
>  	}
>  	*challenge = NULL;
>  	a = (struct rtllib_authentication *) skb->data;
> @@ -1787,7 +1787,7 @@ static inline u16 auth_parse(struct net_device *dev, struct sk_buff *skb,
>  				return -ENOMEM;
>  		}
>  	}
> -	return le16_to_cpu(a->status);
> +	return a->status;

Please do not return a->status.  See my previous email.  You're sending
new versions too quickly.  Wait a day between new versions.

regards,
dan carpenter