Received: by 2002:a19:f614:0:0:0:0:0 with SMTP id x20csp62988lfe; Fri, 15 Apr 2022 19:38:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZ+vweYFMbrD2qsZX8uTboKB1SO9GNCTCdfpmGELG6PmJ5bs8R5OZGX/al/ns0b3EtjNvR X-Received: by 2002:a05:6a00:a26:b0:4fd:f9dd:549c with SMTP id p38-20020a056a000a2600b004fdf9dd549cmr1732670pfh.42.1650076709766; Fri, 15 Apr 2022 19:38:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650076709; cv=none; d=google.com; s=arc-20160816; b=lDn9RzGD8lWShWrFn5T2YHUbldWm9zhZLz4q8NVsUIe76F2lZ/a7RyfCMdnEgm/qXr VVo2ON2mCULOOEv/MINdQf0rrCmpXjqydg3RXvs7czXoxhQKKdSIDrqcxUMRPtxOUAKm YkzmbwR5u3759RfFn67/4mOnBEssh9a+P+yMzMFatz8kzo/XLnDf3L9QoMTIC1R420QJ IDiXdoRgUzM4CMcqKtNtCaNqdi4r1LOK2CGxJycFh3gHJmQhSJp8a+iJVbO6UeWCoqxG pfoWEOtrvYq5VcAZIqwzbafos0Ayg1TiIEKnQdO5iFfkozLomfd4NR0nUPYZ/1t7LLEZ ka/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=XzQWK68/dZeCa/nbUidr9XmW77fjBlg9fKK77YRt9bw=; b=S5YBluO/f2JI7p33NCIdMK/PjRDHzYBxZdD7OGGhdOdKmbU0I97QFGb5gc16dIzi+6 cMz5ngyc3PNx3tDSaU2Kpk0yrcEejJiQ6Wo+0+4/+YfsxyWlETr37zF23flQ48hOcebH tjUJcKow9IV8gEwN//Tr/qeBif+Mx2bZmjp5WUs0f/SgmyebzK/R5sX6UUnDxmvMeVS2 +ceJ9kEasI+dKwFSkv10JH/dTORzWMZenb9ybhhrXTjR7OC9wlQJYUapxL9/ye5oI7cW FOnCQxIt+xso3DtlKs4lVfi24UbekaOsEfs9bfrvI1x7WZFd3FgGlPOqC3erBv4GYVeb o1iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Y50odSd+; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id u8-20020a170902bf4800b00158e0640f01si1841010pls.582.2022.04.15.19.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 19:38:29 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Y50odSd+; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3D14F172DE3; Fri, 15 Apr 2022 18:50:51 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245019AbiDOGvO (ORCPT + 99 others); Fri, 15 Apr 2022 02:51:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239658AbiDOGvM (ORCPT ); Fri, 15 Apr 2022 02:51:12 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF8F4B18B2 for ; Thu, 14 Apr 2022 23:48:45 -0700 (PDT) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id F3FAE1F47D9A; Fri, 15 Apr 2022 07:48:43 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1650005324; bh=XzQWK68/dZeCa/nbUidr9XmW77fjBlg9fKK77YRt9bw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y50odSd+CkLjCRqX3DCAIsCG+FVEujjyOFfwTAp2yeIbsA5UML5ok536TC8CGe5Hm moEKM8NoHTGLR5rxX0IHz5NuTEh65uHj5Z8uzoWBwqVVIJB7SUqXuOJaV3gouJU/zF GDO4O5eM2bErYPBubluQb9TD+MUorjVCELo/qtCR3lJNA36cgUoNJRbnGeAO2Y1YGa 9FsVI70v4bbMyDfxCVQOvIXzgUT4aqYJE68c4j5SIGz1DduoI8jYItiTMdslRrfh+T mAYuUc5jlUB504KKTuAIoBrhXZ96jFV64vbey7VPYhHxUgbvLQUFqTPUz0YfQRL88z oRZOsLnuo51ug== Date: Fri, 15 Apr 2022 08:48:40 +0200 From: Boris Brezillon To: Chuanhong Guo Cc: linux-mtd@lists.infradead.org, Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Patrice Chotard , Christophe Kerello , Mark Brown , Daniel Palmer , linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH v2 2/3] mtd: spinand: add support for detection with param page Message-ID: <20220415084840.72a2bc9a@collabora.com> In-Reply-To: <20220415034844.1024538-3-gch981213@gmail.com> References: <20220415034844.1024538-1-gch981213@gmail.com> <20220415034844.1024538-3-gch981213@gmail.com> Organization: Collabora X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Apr 2022 11:48:43 +0800 Chuanhong Guo wrote: > +#define SPINAND_IDR_EN BIT(6) Looks like you're redefining CFG_OTP_ENABLE, why not use that definition directly? > +#define SPINAND_PARAM_PAGE 1 > +#define ONFI_PARAM_PAGES 3