Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <202204130751.lUeRF1y2-lkp@intel.com> <CAK8P3a3ow9EpNAyTU9n6zC8Rmw71vJ6oaRSCHmd1qU9Z_c3RuA@mail.gmail.com>
 <d5ffc004-f55c-c01e-3395-7983fb25e570@linux-m68k.org>
In-Reply-To: <d5ffc004-f55c-c01e-3395-7983fb25e570@linux-m68k.org>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Thu, 14 Apr 2022 17:59:53 +0200
Message-ID: <CAK8P3a29S9q=ZCGEx-1qxYciYB5=Jffkk9jx1+Gv91xvgtdA=g@mail.gmail.com>
Subject: Re: [linux-stable-rc:queue/5.4 7091/9999] drivers/staging/comedi/drivers/comedi_isadma.c:25:17:
 error: implicit declaration of function 'claim_dma_lock'
To:     Greg Ungerer <gerg@linux-m68k.org>
Cc:     Arnd Bergmann <arnd@arndb.de>, kernel test robot <lkp@intel.com>,
        kbuild-all@lists.01.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sasha Levin <sashal@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Apr 14, 2022 at 4:16 PM Greg Ungerer <gerg@linux-m68k.org> wrote:
> On 13/4/22 18:54, Arnd Bergmann wrote:
> > On Wed, Apr 13, 2022 at 1:07 AM kernel test robot <lkp@intel.com> wrote:
 >
> > Greg (Ungerer), do you see any of these that are used on Coldfire?
> > I can rule out most of them, but there are a few that are unclear to me.
>
> I think the cs89x0 driver may have been used on at least one platform
> in the past. But nothing that is currently supported in mainline code.
> So we can safely assume none of these are required for ColdFire platforms.

Ok, so even if this driver is used on coldfire, it only uses the ISA DMA
code path for actual ISA devices, not for the platform device code on
non-PC systems.

I think we can just remove arch/m68k/coldfire/dma.c and most of
arch/m68k/include/asm/dma.h then after dropping CONFIG_ISA_DMA_API,
leaving only the bits needed for CONFIG_GENERIC_ISA_DMA on Q40
and AMIGA.

     Arnd