Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220414091419.7654-1-jslaby@suse.cz> <CAK7LNATn2QrFn0fTixnbtZ-VOtWid2PvFKPmjfX+z_UtZgTMgA@mail.gmail.com>
 <ace87421-eefb-f4f6-307f-cd2990fb25eb@suse.cz> <810ab2b8-4138-1506-fc90-ae5c6ab0522e@suse.cz>
In-Reply-To: <810ab2b8-4138-1506-fc90-ae5c6ab0522e@suse.cz>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Fri, 15 Apr 2022 00:18:14 +0900
Message-ID: <CAK7LNATgfosGQ6LRmu8DUxwnWL=Dyu1cOUUq1GBRtP6+BppNbw@mail.gmail.com>
Subject: Re: [PATCH] scripts: dummy-tools, add pahole
To:     Jiri Slaby <jslaby@suse.cz>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Michal Marek <michal.lkml@markovi.net>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Apr 14, 2022 at 6:44 PM Jiri Slaby <jslaby@suse.cz> wrote:
>
> On 14. 04. 22, 11:42, Jiri Slaby wrote:
> > On 14. 04. 22, 11:33, Masahiro Yamada wrote:
> >> On Thu, Apr 14, 2022 at 6:14 PM Jiri Slaby <jslaby@suse.cz> wrote:
> >>>
> >>> CONFIG_PAHOLE_VERSION is a part of a config since the commit below. And
> >>> when multiple people update the config, this value constantly changes.
> >>> Even if they use dummy scripts.
> >>>
> >>> To fix this:
> >>> * add a pahole dummy script returning v99.99 -> 9999
> >>> * call it in Makefile taking CROSS_COMPILE into account.
> >>>
> >>> The latter happens only if $(CROSS_COMPILE)pahole really exists. This is
> >>> because a cross pahole likely exists only in dummy tools now, not in
> >>> real cross tools.
> >>
> >>
> >> I do not think this is the right thing to do.
> >>
> >> (As I said somewhere, I am opposed to checking pahole version in
> >> Kconfig).
> >
> > If you ask me, I am all for removal as this causes pain. But it's there,
> > so I cannot do anything about that.
> >
> >> Also, $(CROSS_COMPILE)pahole looks insane.
> >>
> >> You can create a dummy pahole in your local system.
> >>
> >> $ echo 'echo v99.99' > $HOME/bin/dummy-pahole
> >> $ chmod +x  $HOME/bin/dummy-pahole
> >> $ make CROSS_COMPILE=scripts/dummy-tools  PAHOLE=dummy-pahole  menuconfig
> >
> > Well, the question is how do I that for every kernel developer in SUSE?
>
> IOW it'd be quite easier if the scripts/dummy-tools/pahole part of the
> patch was in the tree. (I don't insist on the Makefile change.)


I do not mind  scripts/dummy-tools/pahole
although you need to do
make CROSS_COMPILE=scripts/dummy-tools
PAHOLE=scripts/dummy-tools/pahole  menuconfig


> > thanks,--
> js
> suse labs


-- 
Best Regards
Masahiro Yamada