Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 17 Apr 2022 09:38:47 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Rafael J. Wysocki" <rafael@kernel.org>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>
Cc:     Shuah Khan <skhan@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Linux PM <linux-pm@vger.kernel.org>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Borislav Petkov <bp@alien8.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] Add unit test module for AMD P-State driver
Message-ID: <YltvpwYslWfq9Sgm@amd.com>
References: <20220413090510.4039589-1-li.meng@amd.com>
 <CAJZ5v0jFXhfL=2TwBfzzfEdyKUwYDCxo8OKZuYtJjASKE5Oqfw@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJZ5v0jFXhfL=2TwBfzzfEdyKUwYDCxo8OKZuYtJjASKE5Oqfw@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QMko6g/SkiipMJNNVEUu6N1fQpEVkFNSaYhMEk+AmCy8ZNQrFuxq91iyFfc+?=
 =?us-ascii?Q?yjNk3uZFvfgmALqEnHDg76oCdl9vjvWmlTKDKgBoQsNhleTuX0ZVHq9tqreG?=
 =?us-ascii?Q?1194EIj5BOMNoITE/4mQnl/xnj1l6+5XPazVwhXfwOqRbEBPcpD1Eypj5eBi?=
 =?us-ascii?Q?UBv9WSLdQzuMDzjZZni92OTs3Zg5onrkQ3Cbx1Ew8rqr7MkFm1FIWTf1dUoA?=
 =?us-ascii?Q?ctqjcP0gVRzii66mMnMaEDW7RPquqrZ/w7E2V/BARo1dbLwka0nnisF4AdJ1?=
 =?us-ascii?Q?UQN4oO1TgIA5M8rX2lcmu/umep5tqYolt36/m9YQuL6m58ZLbtFLHcDW5VNI?=
 =?us-ascii?Q?Blz3KgHNMJ77r2XcyBeCDIRdVoDp4ozQiJHDFkL5mZ+UcaXPnY9B/8doFNZG?=
 =?us-ascii?Q?ifTQGLaZD3RGeUfQjSQu2ZiFiw7VTjS5zLhFwP/jIl7or8iKmukCkXCvS9lX?=
 =?us-ascii?Q?5TB0kLMWT/lfYLCt7k+JPJ4MtKrExRPpwJHRAKdy4VnKgmT7kR3YPK5jqsys?=
 =?us-ascii?Q?KaGXc0ltFLMiyq7girxt0J0SQLe6sSGMjKc3h3npbOCZR/jbnSNSOrN7jkQ2?=
 =?us-ascii?Q?3jZOK3eUzPJWvfeabEYRfL76zifGT8EMx0Yr6umcexNWCadTHeuSzPRUebjd?=
 =?us-ascii?Q?thLjrfWypJjsD+Wc0VvzmXC8KwV0dCqoQzuqFfpU+ZV/HlpZMPlL+2Y2/gxq?=
 =?us-ascii?Q?9u+NOgywgmfuZyXaY37+/vdEEv3gZHkYnwyGCOx1hvYUHa5iMDgNwuWMRln4?=
 =?us-ascii?Q?0dQXNUIYkYeyvC5H6XaUUxGgk890QqRm4/l0rHVs5fwxL+IReJcBTYlUic0j?=
 =?us-ascii?Q?HPM/Sny/qUxgbrJBa5vNeVO1V2mOsmnw61zNYZ1N+4nLGMp/dVUXyAcKH7Jx?=
 =?us-ascii?Q?/pneKH1Jdt3+ET3xVvfmJcNCLmEblyAk1TQiwb/4uphyqK9twxsJumbs1Skc?=
 =?us-ascii?Q?20D/Vh9ugV//sxGkxYL52gJo9SOfUOQgB7S27q23CDWDyqsGeRsYfbH9qTpu?=
 =?us-ascii?Q?+g1Z76YqSD2HJZ0ITuJuKAPBdxZeEhxdAOqy6XReGmXFMyrKZwkHCY/AfEON?=
 =?us-ascii?Q?CWee5Wj4S29jA7XMV2PqtZ9GB1L7NsdDsDmX6mYCBDHaAM2hCsgYFQ68Vo+E?=
 =?us-ascii?Q?vBXmuwVf/pyUnCAQKOkYrxqL1dvnzd00R4i74RLw8gyxdxqUCp6wl94yDMNZ?=
 =?us-ascii?Q?H9Nrjv7Hmhcn0n3tcVedago3+pO0JL22WAXJxIShl1QT/o+ixeygT83VfBJd?=
 =?us-ascii?Q?YBIH3s9Cou55Z2NAxo31Cl8QIiUncbusUfUvynQWAzqXPGoe0PaMoECcg06w?=
 =?us-ascii?Q?qPc6jKzkoT521Gh11M3ZV5ud12iUmweeVHqU7vWBF63FNoKazkPzKIA4alON?=
 =?us-ascii?Q?FwbQQzSgRiCLj+8mPv0GvRTRHFTZHJXq8MceIFl0TLQ09fS1DwKyQhVByRlA?=
 =?us-ascii?Q?7SUjyGCvYmqCtj9QGHbiON7AryohPiVqK8V+1oC2y5GS4osSPUkWbRHosmww?=
 =?us-ascii?Q?zBNkor9ToVJCA78RIg1QeUMkmgtMx4UJwCBJVAmsWkxKVEbxX45CzDKkgU0D?=
 =?us-ascii?Q?PZ2s7gubLp+KpwILaXM/R/jl/WyRPosHtqCcL6fF/1+L1cdn4WOV23LFhCll?=
 =?us-ascii?Q?rxHIt+ZxlXttZdYPtyVh5Rz3hkJHAWwJbVPqSbzTJuNYOCOSY6LD7m3L0DYv?=
 =?us-ascii?Q?/toCP9qPrAM3IESGipZps3OaBAvPLngJfcIR0vpU3o8uNVbL6ATZoOPe1gmb?=
 =?us-ascii?Q?S41hXyGBBw=3D=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ec8b6fe-21e6-43d9-2d2e-08da2013120d
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2022 01:39:10.7542
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sGawCbhhmeUM2ASxH82T26y73V32pVMPZIgCz2Blp7qBwD2uWWS5N47jXXZsX0QCV0qgE4lqW2ZsGhEavYbNLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4198
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 13, 2022 at 11:41:44PM +0800, Rafael J. Wysocki wrote:
> On Wed, Apr 13, 2022 at 11:06 AM Meng Li <li.meng@amd.com> wrote:
> >
> > Hi all:
> >
> > AMD P-State unit test(amd_pstate_testmod) is a kernel module for testing
> > the functions of amd-pstate driver.
> > It could import as a module to launch some test tasks.
> >
> > We upstream out AMD P-state driver into Linux kernel and use this unit
> > test module to verify the required conditions and basic functions of
> > amd-pstate before integration test.
> >
> > We use test module in the kselftest frameworks to implement it.
> > We create amd_pstate_testmod module and tie it into kselftest.
> >
> > For exmaple: The test case aput_acpi_cpc is used to check whether the
> > _CPC object is exist in SBIOS.
> > The amd-pstate initialization will fail if the _CPC in ACPI SBIOS is
> > not existed at the detected processor, so it is a necessary condition.
> >
> > At present, its test cases are very simple, and the corresponding test
> > cases will continue to be added later to improve the test coverage.
> >
> > See patch series in below git repo:
> > V1: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flinux-pm%2F20220323071502.2674156-1-li.meng%40amd.com%2F&amp;data=04%7C01%7Cray.huang%40amd.com%7C7a5d4998e2ca413a215b08da1d6425e4%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637854613222577975%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=8fAzN5hea4sVO5E7%2B9Uh9VSsyt29gM2%2FCkMXHS0%2FfP4%3D&amp;reserved=0
> >
> > Changes from V1 -> V2:
> > - cpufreq: amd-pstate:
> > - - add a trailing of amd-pstate.h to MAINTAINER AMD PSTATE DRIVER
> > - selftests: cpufreq
> > - - add a wrapper shell script for the amd_pstate_testmod module
> > - selftests: cpufreq:
> > - - remove amd_pstate_testmod kernel module to .../cpufreq/amd_pstate_testmod
> > - Documentation: amd-pstate:
> > - - amd_pstate_testmod rst document is not provided at present.
> >
> > Thanks,
> > Jasmine
> >
> > Meng Li (3):
> >   cpufreq: amd-pstate: Expose struct amd_cpudata
> 
> Please collect an ACK from Ray for this one as per MAINTAINERS and I
> will leave the series to Shuah as it is selftests mostly.
> 
> Thanks!
> 

Thanks, Rafael!

Jassmine, I think you can mark all patches as "v2" not only the cover
letter. Then we can separate these series easily.

Thanks,
Ray

> >   selftests: cpufreq: Add wapper script for test AMD P-State
> >   selftests: cpufreq: Add amd_pstate_testmod kernel module for testing
> >
> >  MAINTAINERS                                   |   1 +
> >  drivers/cpufreq/amd-pstate.c                  |  60 +---
> >  include/linux/amd-pstate.h                    |  74 +++++
> >  tools/testing/selftests/cpufreq/Makefile      |   2 +-
> >  .../selftests/cpufreq/amd_pstate_testmod.sh   |   4 +
> >  .../cpufreq/amd_pstate_testmod/Makefile       |  20 ++
> >  .../amd_pstate_testmod/amd_pstate_testmod.c   | 302 ++++++++++++++++++
> >  tools/testing/selftests/cpufreq/config        |   1 +
> >  8 files changed, 404 insertions(+), 60 deletions(-)
> >  create mode 100644 include/linux/amd-pstate.h
> >  create mode 100755 tools/testing/selftests/cpufreq/amd_pstate_testmod.sh
> >  create mode 100644 tools/testing/selftests/cpufreq/amd_pstate_testmod/Makefile
> >  create mode 100644 tools/testing/selftests/cpufreq/amd_pstate_testmod/amd_pstate_testmod.c
> >
> > --
> > 2.25.1
> >