Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp2309051pxb; Sun, 17 Apr 2022 18:10:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGxe+DqY+42WSEh+Kqx7qT8u1g0nFfSKDhApuS6fQOXUWvfu0ZhdwYx/neFeTbkhfius5h X-Received: by 2002:a17:906:4787:b0:6e8:9252:5bef with SMTP id cw7-20020a170906478700b006e892525befmr7226321ejc.679.1650244222330; Sun, 17 Apr 2022 18:10:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650244222; cv=none; d=google.com; s=arc-20160816; b=tmgRVib7aFPfuCjRvVKBrjmZmXZ2GjtuFaHquHPQM947C4OSs3sKjuo+NN9BoG9mIu hKjcQbl3HmKDIiAnz+bGCU+PcLGP5p3TCRAX9adL3KVrSbmThiT5eGlt/LGBMDPstMek Q0UIlP8V3oEL9mMr3/fgFrefTtOsLumrtG5TEXJlelF/dpgCiQhk4DFfLL/gzqtmQDlW 2stsWmMTEcghXdCWhHM/Cz+7O0caUQ5uTW45Wkx/Oe2I3aWaOdbSlofnEWflwuCH/ifs YzcVct/9xaDRsxVYuS9ctFGJ1qFGgvN68bFrLxcEW9M3zF/YMoRo2i0hyVsxbQP6xA5v 8fug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=q4+VxF0hopOML3Cixq0y6jntw1LYf5xjmng1LifXy+s=; b=l6a0XpCmsDvpn0aLqyWXTVVdr7ZbPQQ/jHXVAysNBTWY6IN1fIRo9zP0fMKHx9PdSJ bpTItt2f3iDyP8kc9tr+TMdvnNeaZjSiSMrv7L7UjjiFwoVpFRBdQFv1/P/Zq9aDGqWj JEO5xR4Da9Mj2xTTKPRxcsp2bx6JkI/7m0k2BXebfsZ/AZH6s5qTE8djDaJma9Tgz3Be o5MboluSo7q5o/LqUvQXtLzX4aWVOv5mSyCGYodzCMudhSuwTSQbqAwsUC89e2UmkbTK 05+WwpE3NSPbkRbsKQ34aFwWN2wuV50wYqWGinSooEdtFBZvS8einOhODb6EZ53ByMBq 7XsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=oPg0HT0t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r19-20020a170906c29300b006e89d0c88d9si4881123ejz.633.2022.04.17.18.09.52; Sun, 17 Apr 2022 18:10:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=oPg0HT0t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235203AbiDQWkj (ORCPT + 99 others); Sun, 17 Apr 2022 18:40:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235180AbiDQWkW (ORCPT ); Sun, 17 Apr 2022 18:40:22 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D69017060 for ; Sun, 17 Apr 2022 15:37:45 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 5248A1F40EAC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1650235064; bh=rykbT46970dnwG8XD3/7UFJ4mDKmg/KtVkYLQH0qBew=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oPg0HT0thRSQzIa+PIXu6dflLcXf9zuLjyoieAJBynHGL+oQMRB6utM+a5pMj/f4g Rme1KrWqiTCbTIFSyglqaZ4MGOs8ynq78J4of14vb9NGpMywp6DLLtLsqIxZbG0w5J rz0AGjJSJMSCr/E8PSbCUc/krtAD/MtXqq9OErI2HxwbFK/iZoSP251oDpJgNJH61d oqoaq+Oz0ZnlUmW/4Am+Wvlu3dDg6WN5KIfV/iOXOFUnYAoO0/j2ay34s3y+rztWwe t2jVYwuWWE19m14k4P7gzGN5P/SQQJHUtByonbn1mB6/hv+B3ILsW7fPat30cx641s o80sV30HJIX7A== From: Dmitry Osipenko To: David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Daniel Almeida , Gert Wollny , Gustavo Padovan , Daniel Stone , Tomeu Vizoso , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Steven Price , Alyssa Rosenzweig , Rob Clark , Emil Velikov , Robin Murphy Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Dmitry Osipenko , Dmitry Osipenko Subject: [PATCH v4 09/15] drm/shmem-helper: Correct doc-comment of drm_gem_shmem_get_sg_table() Date: Mon, 18 Apr 2022 01:37:01 +0300 Message-Id: <20220417223707.157113-10-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220417223707.157113-1-dmitry.osipenko@collabora.com> References: <20220417223707.157113-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drm_gem_shmem_get_sg_table() never returns NULL on error, but a ERR_PTR. Correct the doc comment which says that it returns NULL on error. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/drm_gem_shmem_helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c index 8ad0e02991ca..30ee46348a99 100644 --- a/drivers/gpu/drm/drm_gem_shmem_helper.c +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c @@ -662,7 +662,7 @@ EXPORT_SYMBOL(drm_gem_shmem_print_info); * drm_gem_shmem_get_pages_sgt() instead. * * Returns: - * A pointer to the scatter/gather table of pinned pages or NULL on failure. + * A pointer to the scatter/gather table of pinned pages or errno on failure. */ struct sg_table *drm_gem_shmem_get_sg_table(struct drm_gem_shmem_object *shmem) { @@ -688,7 +688,8 @@ EXPORT_SYMBOL_GPL(drm_gem_shmem_get_sg_table); * drm_gem_shmem_get_sg_table() should not be directly called by drivers. * * Returns: - * A pointer to the scatter/gather table of pinned pages or errno on failure. + * A pointer to the scatter/gather table of pinned pages ERR_PTR()-encoded + * error code on failure. */ struct sg_table *drm_gem_shmem_get_pages_sgt(struct drm_gem_shmem_object *shmem) { -- 2.35.1