Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <625c38ea.1c69fb81.17696.b763@mx.google.com>
Date:   Sun, 17 Apr 2022 17:57:28 +0200
From:   Ansuel Smith <ansuelsmth@gmail.com>
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Andy Gross <agross@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: qcom_scm: Add compatible for ipq806x
References: <20220310220723.3772-1-ansuelsmth@gmail.com>
 <YlY3rPpYvclK8L3z@builder.lan>
 <CAA8EJprEYgWTp5KJ1TSGC8EKbuw1XP+jz7D5BaCP0rEsEPVsuQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAA8EJprEYgWTp5KJ1TSGC8EKbuw1XP+jz7D5BaCP0rEsEPVsuQ@mail.gmail.com>
Precedence: bulk

On Wed, Apr 13, 2022 at 10:03:59AM +0300, Dmitry Baryshkov wrote:
> On Wed, 13 Apr 2022 at 05:38, Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
> >
> > On Thu 10 Mar 16:07 CST 2022, Ansuel Smith wrote:
> >
> > > Add compatible for ipq806x. Just like ipq4019, ipq806x doesn't require
> > > Core, Iface or Bus clock.
> > >
> > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > > ---
> > >  drivers/firmware/qcom_scm.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> > > index 7db8066b19fd..7348c5894821 100644
> > > --- a/drivers/firmware/qcom_scm.c
> > > +++ b/drivers/firmware/qcom_scm.c
> > > @@ -1338,6 +1338,7 @@ static const struct of_device_id qcom_scm_dt_match[] = {
> > >                                                            SCM_HAS_IFACE_CLK |
> > >                                                            SCM_HAS_BUS_CLK)
> > >       },
> > > +     { .compatible = "qcom,scm-ipq806x" },
> >
> > If you in your dt do:
> >
> >         compatible = "qcom,scm-ipq806x", "qcom,scm";
> >
> > Then we don't need to update the driver for each platform, only the DT
> > binding.
> >
> > And if we some day need to quirk something off qcom,scm-ipq806x we have
> > that option.
> 
> I suppose that ipq806x might need SCM_HAS_CORE_CLK. Or, more likely,
> an interconnect vote, once we have interconnect drivers for
> ipq/apq8064 platforms.
> 

From an old source I found that scm core clock comes from dfab_clk
(DAYTONA_FABRIC). I notice there is an interconnect driver for rpm (bw
is handled by rpm on ipq/apq8064) but why this should be related to scm
core clk? To handle the clock voter stuff? (I assume a voter logic is
not supported upstream)

But it does seems an interesting project adding interconnect support for
ipq8064 also considering I have a fab scaling driver present from ages
that I hane no idea how to handle.

> >
> > Thanks,
> > Bjorn
> >
> > >       { .compatible = "qcom,scm-ipq4019" },
> > >       { .compatible = "qcom,scm-mdm9607", .data = (void *)(SCM_HAS_CORE_CLK |
> > >                                                            SCM_HAS_IFACE_CLK |
> > > --
> > > 2.34.1
> > >
> 
> 
> 
> -- 
> With best wishes
> Dmitry

-- 
	Ansuel