Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>,
        Julia Lawall <julia.lawall@inria.fr>
Cc:     Julia Lawall <julia.lawall@inria.fr>, outreachy@lists.linux.dev,
        jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
        davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
        intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, ira.weiny@intel.com
Subject: Re: [PATCH v3] intel: igb: igb_ethtool.c: Convert kmap() to kmap_local_page()
Date:   Sat, 16 Apr 2022 17:52:20 +0200
Message-ID: <1897617.PYKUYFuaPT@leap>
In-Reply-To: <alpine.DEB.2.22.394.2204161608230.3501@hadrien>
References: <20220416111457.5868-1-eng.alaamohamedsoliman.am@gmail.com> <857a2d22-5d0f-99d6-6686-98d50e4491d5@gmail.com> <alpine.DEB.2.22.394.2204161608230.3501@hadrien>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="ISO-8859-1"
Precedence: bulk

On sabato 16 aprile 2022 16:09:58 CEST Julia Lawall wrote:
>=20
> On Sat, 16 Apr 2022, Alaa Mohamed wrote:
>=20
> >
> > On =D9=A1=D9=A6/=D9=A4/=D9=A2=D9 =D9=A2=D9=A2 =D9=A1=D9=A3:=D9=A3=D9=A1=
, Julia Lawall wrote:
> > >
> > > On Sat, 16 Apr 2022, Alaa Mohamed wrote:
> > >
> > > > Convert kmap() to kmap_local_page()
> > > >
> > > > With kmap_local_page(), the mapping is per thread, CPU local and=20
not
> > > > globally visible.
> > > It's not clearer.
> > I mean this " fix kunmap_local path value to take address of the mapped=
=20
page"
> > be more clearer
> > > This is a general statement about the function.  You
> > > need to explain why it is appropriate to use it here.  Unless it is=20
the
> > > case that all calls to kmap should be converted to call=20
kmap_local_page.
> > It's required to convert all calls kmap to kmap_local_page. So, I don't=
=20
what
> > should the commit message be?
>=20
> If all calls should be changed then you can also say that.

If all calls should be changed with no regards to the surrounding contexts=
=20
and special situations, we can just make an automated s/kmap()/
kmap_local_page()/ or something else similar :)

Thanks,

=46abio M. De Francesco

>=20
> I thought that a previous commit on the outreachy list made some=20
arguments
> about how the affacted value was just allocated and thus could not yet be
> shared.
>=20
> julia