Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Apr 2022 16:16:46 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Changming Huang <jerry.huang@nxp.com>
Cc:     leoyang.li@nxp.com, robh+dt@kernel.org, krzk+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jianchao Wang <jianchao.wang@nxp.com>
Subject: Re: [PATCH v2] arm64: dts: fsl-ls1028a: add dspi2 support
Message-ID: <20220418081646.GE391514@dragon>
References: <20220411091157.1965623-1-jerry.huang@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220411091157.1965623-1-jerry.huang@nxp.com>
Precedence: bulk

On Mon, Apr 11, 2022 at 05:11:57PM +0800, Changming Huang wrote:
> Enable MikroBUS SPI port.
> 
> Signed-off-by: Jianchao Wang <jianchao.wang@nxp.com>
> Signed-off-by: Changming Huang <jerry.huang@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 13 +++++++++++++

"arm64: dts: fsl-ls1028a-rdb: ..." to make it clear this is a board
rather than SoC change.

>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> index 68c31cb8eead..6d0508d5abd0 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> @@ -117,6 +117,19 @@ &duart1 {
>  	status = "okay";
>  };
>  
> +&dspi2 {
> +	bus-num = <2>;
> +	status = "okay";
> +
> +	mikrobus@0 {
> +		compatible = "semtech,sx1301";

Where is the bindings for this?

Shawn

> +		reg = <0>;
> +		spi-max-frequency = <2000000>;
> +		fsl,spi-cs-sck-delay = <1000000>;
> +		fsl,spi-sck-cs-delay = <50>;
> +	};
> +};
> +
>  &enetc_mdio_pf3 {
>  	sgmii_phy0: ethernet-phy@2 {
>  		reg = <0x2>;
> -- 
> 2.25.1
>