Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Saud Farooqui <farooqui_saud@hotmail.com>
To:     jgg@ziepe.ca, kevin.tian@intel.com, joro@8bytes.org,
        will@kernel.org
Cc:     Saud Farooqui <farooqui_saud@hotmail.com>,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        kernel test robot <lkp@intel.com>,
        Julia Lawall <julia.lawall@lip6.fr>
Subject: [PATCH] iommufd: unlock ictx->vfio_compat before return.
Date:   Sun, 17 Apr 2022 07:48:43 +0500
Message-ID: <PA4P189MB1421C0EB9620ACD70D87A1698BF09@PA4P189MB1421.EURP189.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 03c8ac8c-c9f8-4a4e-925e-08da201cd4f3
X-MS-Exchange-SLBlob-MailProps: CjO2us0gQYBn3D7n2JOxivINDx1blzDaDLaE6fNfzaoLfF5PENMgURHaE1n3W2g5+p9uaLu7hdo5sV81IqjupHRBn8Kb87OYTmrw/kHXDVztLXMtJ1bB7mV/bFGUg4+VnHje/2in2APo5bDpWxtXyLTBOLJWvZO0AXhsB/kC36R80iuMP3WBMskLUTXaC3sHLsfDwfllTC4Q/UUQfRYi/C4f/Vk9WrdhqH0mz+rEvUjIY7dprBO5ED0Xob/Wqd03/7C8tVNlXf7HBRsVLxI4XEQrcMfjCLgYZ+G0IDo4Garu+vF+iu8BfZVa5eU0jVERhodbpOA9a0w0g281VD4xim5tdw1SksYWyOnX3PjRi0dF30VqNCY/cy/MWd92Wrlod2IiLBE15ap6NucwuafLYt/rKUme8WWGEO4tJcm1IykAUlc1E2hJIyVb1u5Ncr825PJB0JAjIflYOB/q633aZyxEJX+hrcUiNxF84v04pGUnflb+A7PaugCu4Oy79UEdyv15wC291aPtca1mEfZMvD0ntqwcMhC+tMo/iXomZDv6J+OXW2VcxzVTbgVrsz9OaSFpaN+TP6Wi8wdu/qdzUgIpUpdy4JGwx8sUAWHCz6oT/AVV8Bt/oNyQ1cNFZSe8emXKuQKMeNtCFFbmWuOOD9Ox8lgqMzKcMZhQyKGjFtzQ4CKN/+Bf3NWw5fsJr69E
X-MS-TrafficTypeDiagnostic: DB6P18901MB0118:EE_
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 3rogoUdIUqiKK+x247kI2JK2WCTpwwdLLn1c3NWGu77kNoRlpyiisj4GsWfjBmp/3FMkNnu+NSsi9u0O4Mfeu7pNgca5LisOR6oEVUxbZ3wnUAltWj2vvc+ToXYMFHCxmaHvCny45J2CVo3AdCSXUPSFfWuX777NLHSgkE5rEM7l4HIPc0IIqf96YxucTm4IjkWx83j0OLmpIcIa/Tr3fJMDKRZu/CCGsRdTdWsDaDTBmRA/5gpsyyJkxF5oTcabsDR9jY1mygln5xKKCv31uUwOO6hdfjfClrYSBLRPZtACNdZ+3eMxoR0GEQ4eO0llrQihk73goP3SXSenML+yqlaFPeoiU7nFz25YMCmmTOBlvA3R8Ygnc1LC5DSv2swLomvP9FQuXTTbM2qkVCnGYTY3PNY1kQupkcYOFe8m3zWHJSmfa6GF4hQghqcxSwZNoWqeu0W4Lw5LCTyp/1FrazyV78xDqgMo53aNbADFI6kP7q9Pxt0r0bEfc9dKkwNbaQBvLxty/PqIj8K6DDqeswg2gA1SZn/WaY0FzX93oMMddKj7M2D6ub8Xta5oWARA0ng50q7V9Tfnaho9xeP5Ew==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6ZdM3Z6a4XFJIb7N/8fVdB2fk2TXqXoq8tXMAjJ37bT2S/N5aIId26Vq7EOr?=
 =?us-ascii?Q?uL5CvkRiKxaeZlEJ4fj8slcOaTNx53nA9k2qAxP410y+mMIQ/ZEQ56Tljg1x?=
 =?us-ascii?Q?CpSasHquN9ubNRX58YgT1RJUe45jmR1ikuMBHYKP8uRnHIsE7qJujpoQOl/R?=
 =?us-ascii?Q?WaQhCuVST1kMELYj6JxhjtWbrTS2tZTVXcVAoxm6Y9JU3X98u/ynkeWz9jwF?=
 =?us-ascii?Q?w6x3BS0B86y5FE5plZW6Ap65537mrH9IQzvW3JKqtNb7XsxFx9ySLCM2hLcY?=
 =?us-ascii?Q?vLFmqFDZ//aK6wYDgQMVB7+6VlnOx7AmaTmL2Cob3Z30j9U1w5IjVr0R2Evb?=
 =?us-ascii?Q?Jg9Tmeor3b5bqKIFrwJY4nZPSUAk7aAZdMyl/kSRU/oOTgr+D4qgUwWmqUng?=
 =?us-ascii?Q?3iaqQUWHIjIe5OnyYn+WPEAlMelXPn1QYdtkKtBt43mXP03yH9mVuGHoKOv0?=
 =?us-ascii?Q?QcavHwqYmRS7K4g+QHCGQO7mjXQqvsNwEzW5euRmaJXHPyYD7i3vxPeSaSK4?=
 =?us-ascii?Q?U8Bgj+BmaD2nIezFaWoXVyOXaycxCEt/rpzi06YlMzxcBulgElJwsxg1q38d?=
 =?us-ascii?Q?dIrugW3HveE+MIFZIz/jTh3Qd5ngh20izvLPC+QfhkDe1oLy5qeowccwB/mW?=
 =?us-ascii?Q?0DRzTCzqGcS9ADgu/YaHOS9CVB4OZ/8Ff60g8kq29MChx6nFbqBLB30NSJ1X?=
 =?us-ascii?Q?jMwp+r1eSgQecX8nJZy75S9/Uia06TBclz7rB4qu1rjTTaFe6wX8N7Pmla2E?=
 =?us-ascii?Q?B6weMFagrSYjK1mzAy/sVP/6eXk+GFbvICd74AN3zB8k6k4oqw6XxZYMn6jI?=
 =?us-ascii?Q?IaivvbeV554WCR3qLUVZcf7d+GlMpIYtCfy0QzkiIJQzirumTGWODsb54ZWR?=
 =?us-ascii?Q?Vj2ujGpqXf1eBHhjNiYKCEUKIcniVqXMPdLmVgl5wgp/+KfkJtzi/bWePMbi?=
 =?us-ascii?Q?MwMbBCxk3hGFERfTUe560/hkgm+PgXqAZziDF3xotdEbZjZPd8/oOyxv//ZO?=
 =?us-ascii?Q?ybWkvs5fNXfNNraGYRb1rlkTyo4soHMS7dU4e2gxp6dVYLL3PKahc/rdChL/?=
 =?us-ascii?Q?lpkbVxOX7yUPpsfN0vXZeY4OzqIyWdkQ9zvig8jaE5RcoiQKs59vPQwMawyU?=
 =?us-ascii?Q?/NueCFTwpdYfJYRuwsuVFAanv5hl6zjqOMfUzV6AP5cMRt8VW8fWhcdGw+p7?=
 =?us-ascii?Q?np+D/g0r+kE13ygmk+FKG7Ll1Ao3fw4HylkuapGygenkgxIWBQf4BZjVTcsr?=
 =?us-ascii?Q?+kQMJMZFt9lKh7OIQZ8fW5eChv4J9VIbnL3psQW7JbgiWRHWpTBwaXaeMEoD?=
 =?us-ascii?Q?nU5odQbUEXBIt7nuuqrKVAKyfVggcDQu4h6Y48keZrinMRHjKpJ7WBGg09i1?=
 =?us-ascii?Q?FVEz3YWq4e6qylU5XD8A2bjqt3Gp1fqdr+BcwXW+JwNB4dsenFKRLzWTKFUp?=
 =?us-ascii?Q?Q+qKOLdOXYNQn0eN2P0eL9rcEQdtFlxB?=
X-OriginatorOrg: sct-15-20-4734-24-msonline-outlook-c54b5.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 03c8ac8c-c9f8-4a4e-925e-08da201cd4f3
X-MS-Exchange-CrossTenant-AuthSource: PA4P189MB1421.EURP189.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2022 02:49:03.3064
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6P18901MB0118
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

cocci warning: drivers/iommu/iommufd/vfio_compat.c:494:2-8: preceding
lock on line 491

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Saud Farooqui <farooqui_saud@hotmail.com>
---
 drivers/iommu/iommufd/vfio_compat.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/iommufd/vfio_compat.c b/drivers/iommu/iommufd/vfio_compat.c
index 5b196de00ff9..d9347df48cc8 100644
--- a/drivers/iommu/iommufd/vfio_compat.c
+++ b/drivers/iommu/iommufd/vfio_compat.c
@@ -491,8 +491,10 @@ void vfio_group_unset_iommufd(void *iommufd, struct list_head *device_list)
 		return;
 	mutex_lock(&ictx->vfio_compat);
 	ioas = get_compat_ioas(ictx);
-	if (IS_ERR(ioas))
+	if (IS_ERR(ioas)) {
+		mutex_unlock(&ictx->vfio_compat);
 		return;
+	}
 
 	ioas_id = ioas->obj.id;
 	iommufd_put_object(&ioas->obj);
-- 
2.25.1