Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp2644489pxb; Mon, 18 Apr 2022 05:27:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztyYg+jgDwTrby+lTbyAO3iBCwAgY2UQM6NwLCU4PvkAmTavm2UFWVP463vE7haiKiiUvg X-Received: by 2002:aa7:cb93:0:b0:415:d57a:4603 with SMTP id r19-20020aa7cb93000000b00415d57a4603mr11834745edt.62.1650284842166; Mon, 18 Apr 2022 05:27:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650284842; cv=none; d=google.com; s=arc-20160816; b=znt6ZB6JH7IcUy6hFy8hbXlML9kDEi7+rLimusn8YU73P7Wwkf9Ya+x5i7mnUPQsdY M6usCrB5kKM8KwZFmt5bcDjTEcgD+ElfLAxrT2+3QVur7WqN7kLA9e90Jo/hGWAa501L R6w9/Tx8S+R9FzWukaM3Tduy1lKBJQJMp1BYazOE2d7BZHMl7r7071OaZgKl9FOXIlWw kLVmxw77qkfKWtZTxPpqaQPFfROxESRo9lUIzVhNvExPzlLi1cynT1g++lkZrIsEGTz/ nRErQMcrUBLX16NkqFZ2chfhURs5/hdBIW8LSnP6Rs5bxwCUJ8wvt4gJmiAH6Ma92tVk R64g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Hyu8q9EtLJJY15MRVGAIsM/zzDjKkywXJgXVL/qlXD4=; b=I6EkbSXNG8sOyBeClm9eX5qbhFE9Ay76fewPYtwDqCmoEbCwCL9cZR7POv0eBCdzH0 x6iuj8Hjw6lCT8Wh0Kua4dWoavi0mLrdFnoRlci3/nFMfw5iPRNogqQoDpgnETmoN+nu WFAroLC6Zdj/EHk1+dhPuo+N3EEOmZSx5Sl4Qwv/5SC8wJurq69ZUmltDmTGv8cxrxM9 birknXy+Eb+HKdCCZzL9TLfYM7xqqSQYUtJKPMtwwIJ1P3MeEb8WulTtG1CMdyJOGU8M iMcyqK8f0suepuHT8ediDXNmPVsKqGqtmWdvgDuMwFVylGFQ7poSeZFirGBs4gs70yHJ UX/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=hRyxZPe5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u13-20020a170906068d00b006e7ee5d0682si6062188ejb.585.2022.04.18.05.26.57; Mon, 18 Apr 2022 05:27:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=hRyxZPe5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234084AbiDQWlR (ORCPT + 99 others); Sun, 17 Apr 2022 18:41:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235269AbiDQWkf (ORCPT ); Sun, 17 Apr 2022 18:40:35 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72D2217E1B for ; Sun, 17 Apr 2022 15:37:54 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 742171F40EAE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1650235073; bh=xcqD2qnj7XmjjNXiUoDyGl5DLqM2rc7lEhtFg08w24w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hRyxZPe5XbKVWSDG8XvRi2rin02qdfW4XoryZC4MTu1o8sxcJzaWMBBixMQiPkXJm ZkLrptIYJnnw4Z2TQmpoq7CQW2Cg+U+EKrvYlLGJLly+SiGx/Y8unbqcFsgE5kSKur 1+JxkQZCNV9k9Nrk1Rbr8nznOONFENyPNnisc0rwipSdgA3r9jyNTDN94ftqOQ6I5X 3/3tHmr9EXEBJO05gR3XUtiLzgfz2eLyFkuYRTYah/Ay7WhQu2tGpGd4+5u7iJ2YFP isTSdBNqIJ29GMvW+f/wd97dgdfq8ayLiUQZkk5TXj3pyzbu2CjaJMbVytVYzEhO8d rWLF+1zuhDqXw== From: Dmitry Osipenko To: David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Daniel Almeida , Gert Wollny , Gustavo Padovan , Daniel Stone , Tomeu Vizoso , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Steven Price , Alyssa Rosenzweig , Rob Clark , Emil Velikov , Robin Murphy Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Dmitry Osipenko , Dmitry Osipenko Subject: [PATCH v4 14/15] drm/shmem-helper: Make drm_gem_shmem_get_pages() private Date: Mon, 18 Apr 2022 01:37:06 +0300 Message-Id: <20220417223707.157113-15-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220417223707.157113-1-dmitry.osipenko@collabora.com> References: <20220417223707.157113-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org VirtIO-GPU driver was the only user of drm_gem_shmem_get_pages() and it now uses drm_gem_shmem_get_pages_sgt(). Make the get_pages() private to drm_gem_shmem_helper. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/drm_gem_shmem_helper.c | 3 +-- include/drm/drm_gem_shmem_helper.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c index 3838fb8d6f3a..6d83d11211fc 100644 --- a/drivers/gpu/drm/drm_gem_shmem_helper.c +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c @@ -537,7 +537,7 @@ static int drm_gem_shmem_get_pages_locked(struct drm_gem_shmem_object *shmem) * Returns: * 0 on success or a negative error code on failure. */ -int drm_gem_shmem_get_pages(struct drm_gem_shmem_object *shmem) +static int drm_gem_shmem_get_pages(struct drm_gem_shmem_object *shmem) { int ret; @@ -554,7 +554,6 @@ int drm_gem_shmem_get_pages(struct drm_gem_shmem_object *shmem) return ret; } -EXPORT_SYMBOL(drm_gem_shmem_get_pages); static void drm_gem_shmem_get_pages_no_fail(struct drm_gem_shmem_object *shmem) { diff --git a/include/drm/drm_gem_shmem_helper.h b/include/drm/drm_gem_shmem_helper.h index a65557b446e6..84316c281292 100644 --- a/include/drm/drm_gem_shmem_helper.h +++ b/include/drm/drm_gem_shmem_helper.h @@ -144,7 +144,6 @@ struct drm_gem_shmem_object { struct drm_gem_shmem_object *drm_gem_shmem_create(struct drm_device *dev, size_t size); void drm_gem_shmem_free(struct drm_gem_shmem_object *shmem); -int drm_gem_shmem_get_pages(struct drm_gem_shmem_object *shmem); void drm_gem_shmem_put_pages(struct drm_gem_shmem_object *shmem); int drm_gem_shmem_pin(struct drm_gem_shmem_object *shmem); void drm_gem_shmem_unpin(struct drm_gem_shmem_object *shmem); -- 2.35.1