Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wu, Hao" <hao.wu@intel.com>
To:     "Zhang, Tianfei" <tianfei.zhang@intel.com>,
        "trix@redhat.com" <trix@redhat.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "Xu, Yilun" <yilun.xu@intel.com>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Matthew Gerlach" <matthew.gerlach@linux.intel.com>
Subject: RE: [PATCH v2] uio: dfl: add HSSI feature id
Thread-Topic: [PATCH v2] uio: dfl: add HSSI feature id
Thread-Index: AQHYTjZdBoHDFBYOuES9CQIlYPGclaz06tqw
Date:   Mon, 18 Apr 2022 01:32:18 +0000
Message-ID: <DM6PR11MB38190E6EEF6DE3EB900290C585F39@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <20220412062353.53984-1-tianfei.zhang@intel.com>
In-Reply-To: <20220412062353.53984-1-tianfei.zhang@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.401.20
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1+ugBTf3zbKQLZItNsyD6E21CsTNlYOAKfu2OXKaxWvtYalVXAjRBS+ea45s?=
 =?us-ascii?Q?j9b+x9M4p0wqXc5dURilBkEQfYfVOSWsNmAtwS3aJ8w2daslKE1vrNr6SP0B?=
 =?us-ascii?Q?TnZu8Vvag4PtGJEIscca14T6i7dKYIjhk4vCoCvE9gVlt+haDFaEanDvgkwI?=
 =?us-ascii?Q?xIoej2XH4Zn9sAAmVZ52ZtG2RNj88q2NZBRXFFTFWjPJ0IEUZYlVVNN3TQID?=
 =?us-ascii?Q?KZOh8865bT1wuJUbCRgH26vqrvKtSiLVnCOVPL87N9X9aa3Wwf/8sYUB/QbM?=
 =?us-ascii?Q?6nUHRow4c/vZ6aLPWsAvoMg2FEDW/PLQUkeMZqVUYcwEYLI3/pYdMR1666b3?=
 =?us-ascii?Q?iUzmnZXiKBtGFWKENQ9A3/P2yj1u7npXNb3j77qd00TTtmed6uTe81wRsTaV?=
 =?us-ascii?Q?NDLYcoZTwuohzC1ZORKlTN0Es/nXHd6rK58o1kelYGM2e4m6Qk1K96dC35e6?=
 =?us-ascii?Q?p6/gIgPTJE34mAxiTrHsl+TGG4gnwM68HozGkSAXgkrumujhxHtPFj2CTwgD?=
 =?us-ascii?Q?nY6gWsYLgAk6hxbNP9YB9TW/00LxxIl/LA4NIFVoezTz27UQ1CrbJj47uPb7?=
 =?us-ascii?Q?7dlyb6omzSDv6PvXNPKBXz8b6NMRRGTgr7Ar9mkAlecqjvC6mF8PSynxGPcQ?=
 =?us-ascii?Q?hwhgoihBTOVd/Kvqo2qaO7x8z6A5gl8gHKJFwZJ9YvJmhuEb2FICix2URbkX?=
 =?us-ascii?Q?bK7JQxEJ9tPMGsVuwUYu6ZmuRPpQl+YL+apf/ycH0Zo8yR/zp4OQeHIfKOKH?=
 =?us-ascii?Q?RElUjcH/B5QMJa9TrM3XcZezYsXYrabiqQ9MuNCJ1DKC47fMt7J91IGJmlmN?=
 =?us-ascii?Q?CIuplY8gOKLu7vB4jLgsvTbfjfZmy4BIsclYsnfTSd/n5/Ydpn6lnQS4FsUB?=
 =?us-ascii?Q?AJsxhmCKkK1yWjRl7T12bF+EXcT2toHYjcrMTFfs4dvPl2J4+0HUVbp59EdD?=
 =?us-ascii?Q?N05LvgUHeUSFl1HvVPBR9zkL3aNwfroSwqvCbDzBLEbQFYsyVS712pO++3xo?=
 =?us-ascii?Q?VBS2NHNgY/R5ISZGrnD1xLCbJE1WwYpn/VlivRF+HXzPZJVTTioVlB0D4Mqa?=
 =?us-ascii?Q?oq8pHABd5u0K5Wt2BNiMMOIOQpKpsjCW78IEyUHb6vKLy3u5347lOF5lsj99?=
 =?us-ascii?Q?nGykvPNfepos3sCToIafuqgfRTHB6ksXvoglSrrXL/ZsExn1BJZB1NVXeRSM?=
 =?us-ascii?Q?gEX8cJ17Glv58pR7NFsEOAFh7+nGuWivxEelQDEXTWpxZHNJ+kVzITeAcijh?=
 =?us-ascii?Q?QZZBRs3IpG1ATbYzm2bj5lJLGgl8K3YoQ0ArOFG8LaI9hqdKkfJAdud/PuZi?=
 =?us-ascii?Q?6nkp+OVEFbT3m014gOLWKc1Rhm68AMgjJJNQZFym2RGKiaYCZIpaVx8qqm4N?=
 =?us-ascii?Q?/oMBXqFLOZMsH/KYGJEaBHwqxXpwaj4tvKEYIoCcIBBqGEcvh6tqh7uIEH/3?=
 =?us-ascii?Q?uhYcP0tPRT1vYpKMongm3BCswEnmlw/+Dv3IYoz+OLPRwzMSVFkW3ySr7K/W?=
 =?us-ascii?Q?jVgSVLPmnMj6TWt1t54ABhi7gt3YTUFYqw82b3yMuGYmZvCjEXpiSnYwDKFK?=
 =?us-ascii?Q?qcaLzrqI6gVqSxz8G6pyqzMq7wPvKj6aaTTjIn1fyCU9QQhsNyVxRc15U4nL?=
 =?us-ascii?Q?8zkf4sBluHrrRNcuL6ZV1a/+baiYxx8bpRtug36DnrXt6Xwjh/2VfU4IUIo5?=
 =?us-ascii?Q?4LrKugeC9c5ly3bkKkT40DoNWy5ZYwchmWwKWfN5+j56NC+Ey+kTryW5VxdS?=
 =?us-ascii?Q?QwvVMia0vQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3819.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: afce7410-e8a0-4aa6-3543-08da20db46bd
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2022 01:32:18.2140
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: skYx2KXpDeNstrPgBFnKmGgKyBFE1KMOhBiHEcNAYo5xrWwY9ZaGZxFDykmDxtkFFs6ETqL93mp+okVys3cGmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5587
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Zhang, Tianfei <tianfei.zhang@intel.com>
> Sent: Tuesday, April 12, 2022 2:24 PM
> To: Wu, Hao <hao.wu@intel.com>; trix@redhat.com; mdf@kernel.org; Xu, Yilu=
n
> <yilun.xu@intel.com>; linux-fpga@vger.kernel.org;
> gregkh@linuxfoundation.org
> Cc: linux-kernel@vger.kernel.org; Matthew Gerlach
> <matthew.gerlach@linux.intel.com>; Zhang, Tianfei <tianfei.zhang@intel.co=
m>
> Subject: [PATCH v2] uio: dfl: add HSSI feature id
>=20
> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>=20
> Add the feature id of the OFS HSSI (High Speed Serial Interface)

We still don't see any description on what OFS is here, or will OFS be adde=
d to
title as well? we don't expect another submission with the same title but f=
or
XXX HSSI again.

> subsystem to table of ids supported by the uio_dfl driver. HSSI
> subsystem consists of harden/soft Ethernet MAC to support various
> ethernet usages and PCS/FEC/PMA direct modes for non-ethernet usages.
>=20
> We leverage the uio_dfl driver to access the HSSI subsystem on user space=
,
> because the HSSI subsystem was designed for specific purposes and does
> not fit into the standard MAC and net kernel subsystems.
>=20
> The Feature ID table of DFL can be found:
> https://github.com/OPAE/dfl-feature-id

Why you put it here? even this link there is no more descriptions to unders=
tand
what it is. Or can be removed here.

>=20
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> ---
> v2: add HSSI introduction and the git repo of Feature ID table.
> ---
>  drivers/uio/uio_dfl.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
> index 89c0fc7b0cbc..660e1d0bf6b9 100644
> --- a/drivers/uio/uio_dfl.c
> +++ b/drivers/uio/uio_dfl.c
> @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
>  }
>=20
>  #define FME_FEATURE_ID_ETH_GROUP	0x10
> +#define FME_FEATURE_ID_OFS_HSSI		0x15
>=20
>  static const struct dfl_device_id uio_dfl_ids[] =3D {
>  	{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
> +	{ FME_ID, FME_FEATURE_ID_OFS_HSSI },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
> --
> 2.26.2