Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 17 Apr 2022 10:09:47 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Meng Li <li.meng@amd.com>
Cc:     Shuah Khan <skhan@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        linux-pm@vger.kernel.org,
        Nathan Fontenot <nathan.fontenot@amd.com>,
        Deepak Sharma <deepak.sharma@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Jinzhou Su <Jinzhou.Su@amd.com>,
        Perry Yuan <Perry.Yuan@amd.com>,
        Xiaojian Du <Xiaojian.Du@amd.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Borislav Petkov <bp@alien8.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] cpufreq: amd-pstate: Expose struct amd_cpudata
Message-ID: <Ylt264e1r3r/ddQb@amd.com>
References: <20220413090510.4039589-1-li.meng@amd.com>
 <20220413090510.4039589-2-li.meng@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220413090510.4039589-2-li.meng@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?czYiT1zskVXhNXEmncG0OWBWPtDOpZOcJ0wbfgEr9BjTSEZUuCl3UHF3eXUa?=
 =?us-ascii?Q?y3x5PibJvX2MJSusGW68xU813Pn3w2lMCDNL8A6Pqfa9eMv0dMtf97CqdSmx?=
 =?us-ascii?Q?abbVwP+h01qaFih9QcFzw4u0hyCej3A6UgQB8dzvOGkKm6Dc2ZxX43mleeDR?=
 =?us-ascii?Q?p6mvZ7q1oF91mSCJTG3HmL8bB3fF9WHSntb6VdyKVfpFTp+mqTMx/SOeUFQe?=
 =?us-ascii?Q?b+WZKSdBleh1Ka+nWddYjRNT+PQG7SmhsCsjsCZVjBp3mG0QHg0Xcv7kNAMj?=
 =?us-ascii?Q?79Gkv2WtG5Q9FrGHoNr/O4RDDIoCOr6t7cZFO703ePDt4/SPhungtY/Nya6Y?=
 =?us-ascii?Q?P3qpmJMajmxiK/p5XtSyIQ8v6u0VH+zO/gmiEGQ36dysKLqlCk62r2RuKW1t?=
 =?us-ascii?Q?eRygsBUISQYG4pyRb1zgoHLVpdAd1kUrgA+L+BvV/m1QJOI7lRpsXYwY7mvn?=
 =?us-ascii?Q?7a95gL0oXrNomJpffJPpKZgZqVOlSaWp4pHNGsIjFIRhCyVuCLtnl78Z7Uox?=
 =?us-ascii?Q?Px+6275jOrQYOIJRPBBfxVMn7qPibHQuYMfhDvBxvFGyhC2TIgGBLObbQZWO?=
 =?us-ascii?Q?N9MNJs3Edlwgr+CsrK7rQrQj+yi6gWNnkAX+SfqRvTB9vXOV/WgTiRjdSOn9?=
 =?us-ascii?Q?0J4tm7meVnx9vH1RPvc204H5cyH4QlQJrouUkqKtXA/NzluPebz8FA1aVVXh?=
 =?us-ascii?Q?IH6obL4ZSNi9YVtKbduKZIskQ1fhtP275n9F1vFbc37DKF2Ih3UgVMEoED5x?=
 =?us-ascii?Q?N3yKb4VUBgs2rmsv//PXpS++pTWuoRfATl6ljx5Y1BopzJHkAeoRg4RvHWyC?=
 =?us-ascii?Q?rKhOKRFXXYyXVjYCJKLvy7RHC1+8oVxWRprGlT6IqTLYAyXmVZDjoBiysLi1?=
 =?us-ascii?Q?xWi1a/Hqc1wFq41qydkgpcGQ7hEmWPz4pOQA5zZVPSab+mBi8ksE/CsLN9iv?=
 =?us-ascii?Q?cgr3RbbiDwpRW6vkQ+/Svqg/Rgo7lVgZAzB1moWTmUq17SI+md6nd7pFkzyZ?=
 =?us-ascii?Q?7xY7lcM2B5O+FIhcFnr1WmQl9ctOUKjSxTHoGYnBk3dQm/TJfDJX3LLEzWN7?=
 =?us-ascii?Q?Vifun0Oep0S3mzkogcXac6mh0ZGSHw01yF3ATb2Z20lYGWZDikCxA2wa3/mP?=
 =?us-ascii?Q?g4b/2qbmwWNgvdw+pFZWUBS3HAIw14X56B37Jt9OxEJOLtd6PXmGwcQ75QIK?=
 =?us-ascii?Q?eZpdF9toXx18I6EzhS//JJC8l/Kz5r/1+EvTek+Ms6q7xx1g40LwX3X54yGr?=
 =?us-ascii?Q?/QElLQv36xsFXFJbSEml4VJNthX2eP2BUo6j3nCNy5B90I6oC24DrV579jTk?=
 =?us-ascii?Q?eHjky4xoxxMRvm/yYXEomDWNnBH4MijHEwcPJE9sEuSntrcC6vgQn48WraXb?=
 =?us-ascii?Q?oetSdG3r9z6PRK5EoiDdAGJeWECU9h/S/yS8U23RN/zalMXfPLIwqYZecBuh?=
 =?us-ascii?Q?StcSrMBbnhd1eHR9CX7mtPYvSzlRpmk/zMcADCrD4FUi2shTKFmlDpKuu9MD?=
 =?us-ascii?Q?OU+XBeH3WkKyuD9nA7Hhkg6qdAlVCMAcy8Q/l/yIOUVfR2zYvogeWG8m3T8q?=
 =?us-ascii?Q?ggeclKGf5JeuhRh26EMV4PRX/aRAS0VBq04TlIrpLWJKqa2P+6h7uVaYUVhm?=
 =?us-ascii?Q?MAAIWxaXTye2vqBwBBCkM69IhHK5/PahXQAbDImITWp2Tzv6MSp8OVA5iuHM?=
 =?us-ascii?Q?ddkez+rr52nCXJOXnm5mrtNyuw4W4HwlKjl/lw4k3tqwRbdvCd5G5RhNTrME?=
 =?us-ascii?Q?RTvH2Ch4XQ=3D=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54018266-a54c-4743-8143-08da201765c3
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2022 02:10:09.1244
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vNVZCld01tRglLVecamweiZy9KwIWaZNDiFoip6rnVVwyzMm1r8tQH0dEFxpvf4d7MRkb6DOwk5STrJs9VT3cw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5453
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 13, 2022 at 05:05:08PM +0800, Meng Li wrote:
> Expose struct amd_cpudata to AMD P-State unit test module.
> 
> This data struct will be used on the following AMD P-State unit test
> (amd-pstate-ut) module. The amd-pstate-ut module can get some AMD
> infomations by this data struct. For example: highest perf,
> nominal perf, boost supported etc.
> 
> Signed-off-by: Meng Li <li.meng@amd.com>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  MAINTAINERS                  |  1 +
>  drivers/cpufreq/amd-pstate.c | 60 +----------------------------
>  include/linux/amd-pstate.h   | 74 ++++++++++++++++++++++++++++++++++++
>  3 files changed, 76 insertions(+), 59 deletions(-)
>  create mode 100644 include/linux/amd-pstate.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9832b607e2e2..f108e83ba851 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1003,6 +1003,7 @@ S:	Supported
>  F:	Documentation/admin-guide/pm/amd-pstate.rst
>  F:	drivers/cpufreq/amd-pstate*
>  F:	tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py
> +F:	include/linux/amd-pstate.h
>  
>  AMD PTDMA DRIVER
>  M:	Sanjay R Mehta <sanju.mehta@amd.com>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 7be38bc6a673..5f7a00a64f76 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -36,6 +36,7 @@
>  #include <linux/delay.h>
>  #include <linux/uaccess.h>
>  #include <linux/static_call.h>
> +#include <linux/amd-pstate.h>
>  
>  #include <acpi/processor.h>
>  #include <acpi/cppc_acpi.h>
> @@ -65,65 +66,6 @@ MODULE_PARM_DESC(shared_mem,
>  
>  static struct cpufreq_driver amd_pstate_driver;
>  
> -/**
> - * struct  amd_aperf_mperf
> - * @aperf: actual performance frequency clock count
> - * @mperf: maximum performance frequency clock count
> - * @tsc:   time stamp counter
> - */
> -struct amd_aperf_mperf {
> -	u64 aperf;
> -	u64 mperf;
> -	u64 tsc;
> -};
> -
> -/**
> - * struct amd_cpudata - private CPU data for AMD P-State
> - * @cpu: CPU number
> - * @req: constraint request to apply
> - * @cppc_req_cached: cached performance request hints
> - * @highest_perf: the maximum performance an individual processor may reach,
> - *		  assuming ideal conditions
> - * @nominal_perf: the maximum sustained performance level of the processor,
> - *		  assuming ideal operating conditions
> - * @lowest_nonlinear_perf: the lowest performance level at which nonlinear power
> - *			   savings are achieved
> - * @lowest_perf: the absolute lowest performance level of the processor
> - * @max_freq: the frequency that mapped to highest_perf
> - * @min_freq: the frequency that mapped to lowest_perf
> - * @nominal_freq: the frequency that mapped to nominal_perf
> - * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf
> - * @cur: Difference of Aperf/Mperf/tsc count between last and current sample
> - * @prev: Last Aperf/Mperf/tsc count value read from register
> - * @freq: current cpu frequency value
> - * @boost_supported: check whether the Processor or SBIOS supports boost mode
> - *
> - * The amd_cpudata is key private data for each CPU thread in AMD P-State, and
> - * represents all the attributes and goals that AMD P-State requests at runtime.
> - */
> -struct amd_cpudata {
> -	int	cpu;
> -
> -	struct	freq_qos_request req[2];
> -	u64	cppc_req_cached;
> -
> -	u32	highest_perf;
> -	u32	nominal_perf;
> -	u32	lowest_nonlinear_perf;
> -	u32	lowest_perf;
> -
> -	u32	max_freq;
> -	u32	min_freq;
> -	u32	nominal_freq;
> -	u32	lowest_nonlinear_freq;
> -
> -	struct amd_aperf_mperf cur;
> -	struct amd_aperf_mperf prev;
> -
> -	u64 freq;
> -	bool	boost_supported;
> -};
> -
>  static inline int pstate_enable(bool enable)
>  {
>  	return wrmsrl_safe(MSR_AMD_CPPC_ENABLE, enable);
> diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
> new file mode 100644
> index 000000000000..790b04c9000b
> --- /dev/null
> +++ b/include/linux/amd-pstate.h
> @@ -0,0 +1,74 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * linux/include/linux/amd-pstate.h
> + *
> + * Copyright (C) 2007-2010 Advanced Micro Devices, Inc.
> + * Author: Meng Li <li.meng@amd.com>
> + */
> +#ifndef _LINUX_AMD_PSTATE_H
> +#define _LINUX_AMD_PSTATE_H
> +
> +#include <linux/pm_qos.h>
> +/*********************************************************************
> + *                        AMD P-state INTERFACE                       *
> + *********************************************************************/
> +/**
> + * struct  amd_aperf_mperf
> + * @aperf: actual performance frequency clock count
> + * @mperf: maximum performance frequency clock count
> + * @tsc:   time stamp counter
> + */
> +struct amd_aperf_mperf {
> +	u64 aperf;
> +	u64 mperf;
> +	u64 tsc;
> +};
> +
> +/**
> + * struct amd_cpudata - private CPU data for AMD P-State
> + * @cpu: CPU number
> + * @req: constraint request to apply
> + * @cppc_req_cached: cached performance request hints
> + * @highest_perf: the maximum performance an individual processor may reach,
> + *		  assuming ideal conditions
> + * @nominal_perf: the maximum sustained performance level of the processor,
> + *		  assuming ideal operating conditions
> + * @lowest_nonlinear_perf: the lowest performance level at which nonlinear power
> + *			   savings are achieved
> + * @lowest_perf: the absolute lowest performance level of the processor
> + * @max_freq: the frequency that mapped to highest_perf
> + * @min_freq: the frequency that mapped to lowest_perf
> + * @nominal_freq: the frequency that mapped to nominal_perf
> + * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf
> + * @cur: Difference of Aperf/Mperf/tsc count between last and current sample
> + * @prev: Last Aperf/Mperf/tsc count value read from register
> + * @freq: current cpu frequency value
> + * @boost_supported: check whether the Processor or SBIOS supports boost mode
> + *
> + * The amd_cpudata is key private data for each CPU thread in AMD P-State, and
> + * represents all the attributes and goals that AMD P-State requests at runtime.
> + */
> +struct amd_cpudata {
> +	int	cpu;
> +
> +	struct	freq_qos_request req[2];
> +	u64	cppc_req_cached;
> +
> +	u32	highest_perf;
> +	u32	nominal_perf;
> +	u32	lowest_nonlinear_perf;
> +	u32	lowest_perf;
> +
> +	u32	max_freq;
> +	u32	min_freq;
> +	u32	nominal_freq;
> +	u32	lowest_nonlinear_freq;
> +
> +	struct amd_aperf_mperf cur;
> +	struct amd_aperf_mperf prev;
> +
> +	u64	freq;
> +	bool	boost_supported;
> +};
> +
> +#endif /* _LINUX_AMD_PSTATE_H */
> -- 
> 2.25.1
>