Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Apr 2022 14:09:37 +0200 (CEST)
From:   Julia Lawall <julia.lawall@inria.fr>
To:     Aliya Rahmani <aliyarahmani786@gmail.com>
cc:     clabbe@baylibre.com, gregkh@linuxfoundation.org,
        linux-staging@lists.linux.dev, outreachy@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: media: zoran: avoid macro argument precedence
 issues
In-Reply-To: <20220418115948.5456-4-aliyarahmani786@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204181408230.11986@hadrien>
References: <20220418115948.5456-1-aliyarahmani786@gmail.com> <20220418115948.5456-4-aliyarahmani786@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk


On Mon, 18 Apr 2022, Aliya Rahmani wrote:

> This patch fixes checkpatch warnings of precedence issues. Added parentheses
> around macro argument 'num'.

You should use the imperative.  This "Add" rather than "Added".

The subject line would be better as "add parentheses on macro parameter".
That describes what you did, rather than what you avoided (avoided how?).

julia

>
> Signed-off-by: Aliya Rahmani <aliyarahmani786@gmail.com>
> ---
>  drivers/staging/media/zoran/videocodec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/zoran/videocodec.c b/drivers/staging/media/zoran/videocodec.c
> index 19732a47c8bd..925f90fd5885 100644
> --- a/drivers/staging/media/zoran/videocodec.c
> +++ b/drivers/staging/media/zoran/videocodec.c
> @@ -22,7 +22,7 @@ MODULE_PARM_DESC(videocodec_debug, "Debug level (0-4)");
>
>  #define dprintk(num, format, args...) \
>  	do { \
> -		if (videocodec_debug >= num) \
> +		if (videocodec_debug >= (num)) \
>  			printk(format, ##args); \
>  	} while (0)
>
> --
> 2.25.1
>
>
>