Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp3161617pxb; Mon, 18 Apr 2022 17:42:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyI+1WLA17wlPuTq6LqU/FVkwImBlKUMLECCozFOQuXR262UsIsnzRsXi7HygkwOjQ+7UZh X-Received: by 2002:a05:6a00:22d4:b0:50a:8540:431f with SMTP id f20-20020a056a0022d400b0050a8540431fmr4627489pfj.54.1650328955350; Mon, 18 Apr 2022 17:42:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650328955; cv=none; d=google.com; s=arc-20160816; b=ecMekOsbM4Oro6nyJ00FQFakzqLXyeLnS3/1ZijishkM9cIXtVjBcV9YCyF+ts5sD3 rDcTzNz/456CCHay+kttjcx2RSWsslM+El4HhKK0D96Ju4iofdARDtK5P7zv+/gdnsyo 4QMhaEB2Wxwhv2vToQz/yBgGQ+taCSQD+puR8JhvrifJSo53ENoaKH71w62ferUusM7D j003CghcWX5GbFWfKECbk7KARZG0FGOdZkZlSRU3VUnkzzgPcfnTM4I/FZh/bzRxhWnW OKotOc65a5Nxk+mT1C+ZBcFf8MsvSs6Xb1crqiwOnV95wf1GmIdNSmPrKiumMkMuVy05 4Nwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0D3q+Q4aX/TjIvUlQqvRM7SLptvrUumAm/I8NieXkdI=; b=oi7BpRcwoJqN0sirFM10Bkza6IoPOBfdKsTZ/LxzBcegnucMAKSMpIqJFPSKutM4dg GaPrNaH4fpxc3usb6UUQF63Lbr+ZB4Rj+IGqpBL1F2+26nsNThLR6SvJk8prEOdmlTuv h1y95FkRpmiOEzZSwtvfi+RLuF4c5b+6zOJf5zOc4YbT7sR0tbNPursz7kd6pyUG528a TVUOSPgq1pQfudNGusyR+IJfKyqQJbvemqlYXdWqV9dzENxeaNz3i4dXog2NVrEgurYn lXia2bhZOuhQxrQkAKI/1hvXre0CDkLUWc92rptnxw2rsaqE/3dqq9c10d3KMAE5guzS lOSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GGtHrZIS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w21-20020a63d755000000b00398be8dbfa6si10120203pgi.401.2022.04.18.17.42.17; Mon, 18 Apr 2022 17:42:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GGtHrZIS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238724AbiDRM0w (ORCPT + 99 others); Mon, 18 Apr 2022 08:26:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238683AbiDRMZl (ORCPT ); Mon, 18 Apr 2022 08:25:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CB5EC13; Mon, 18 Apr 2022 05:19:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 45C3BB80EDB; Mon, 18 Apr 2022 12:19:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87972C385A9; Mon, 18 Apr 2022 12:19:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650284383; bh=Xe2AbJ8/FRjja0awDq2I0DB0l+XsLNsfBPUqt1HnJaQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GGtHrZIS90sL7y3vUf3AbeBDbkquh5AtnSBbxLuZMPxJFX3RpMV3hEmErsNugehfq iAgsMu9XPhQC2/sFUhFPzFS+TT7zKanUN6DO7dzkTcT5Yd8RaXHdWPpibt29bAdrOl jwckVE7+9v34FtqjK0GkwdqwdI2+ZZGE1ObxYbtw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Damien Le Moal , Jack Wang , Ajish Koshy , Viswas G , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.17 097/219] scsi: pm80xx: Enable upper inbound, outbound queues Date: Mon, 18 Apr 2022 14:11:06 +0200 Message-Id: <20220418121209.491526549@linuxfoundation.org> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220418121203.462784814@linuxfoundation.org> References: <20220418121203.462784814@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ajish Koshy [ Upstream commit bcd8a45223470e00b5f254018174d64a75db4bbe ] Executing driver on servers with more than 32 CPUs were faced with command timeouts. This is because we were not geting completions for commands submitted on IQ32 - IQ63. Set E64Q bit to enable upper inbound and outbound queues 32 to 63 in the MPI main configuration table. Added 500ms delay after successful MPI initialization as mentioned in controller datasheet. Link: https://lore.kernel.org/r/20220411064603.668448-3-Ajish.Koshy@microchip.com Fixes: 05c6c029a44d ("scsi: pm80xx: Increase number of supported queues") Reviewed-by: Damien Le Moal Acked-by: Jack Wang Signed-off-by: Ajish Koshy Signed-off-by: Viswas G Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/pm8001/pm80xx_hwi.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c index 2dea48933ef9..5853b3c0d76d 100644 --- a/drivers/scsi/pm8001/pm80xx_hwi.c +++ b/drivers/scsi/pm8001/pm80xx_hwi.c @@ -766,6 +766,10 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha) pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_severity = 0x01; pm8001_ha->main_cfg_tbl.pm80xx_tbl.fatal_err_interrupt = 0x01; + /* Enable higher IQs and OQs, 32 to 63, bit 16 */ + if (pm8001_ha->max_q_num > 32) + pm8001_ha->main_cfg_tbl.pm80xx_tbl.fatal_err_interrupt |= + 1 << 16; /* Disable end to end CRC checking */ pm8001_ha->main_cfg_tbl.pm80xx_tbl.crc_core_dump = (0x1 << 16); @@ -1027,6 +1031,13 @@ static int mpi_init_check(struct pm8001_hba_info *pm8001_ha) if (0x0000 != gst_len_mpistate) return -EBUSY; + /* + * As per controller datasheet, after successful MPI + * initialization minimum 500ms delay is required before + * issuing commands. + */ + msleep(500); + return 0; } -- 2.35.1