Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp3202490pxb; Mon, 18 Apr 2022 19:02:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7ezlMeruIfu1diO9sKLqPLLlEWP+Dftd5DTuNAKGwNdu/kHMyOwUSkt1lIz2ePoaiE/D6 X-Received: by 2002:a17:903:1212:b0:156:3ddc:84bd with SMTP id l18-20020a170903121200b001563ddc84bdmr13238562plh.70.1650333755136; Mon, 18 Apr 2022 19:02:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650333755; cv=none; d=google.com; s=arc-20160816; b=DXPCA8wrQMYW9nU5xgVMa9hNjJkSX0G6ULw+DcJYzmwxlhYb5xX80HLX2aXefdFL2w KFHIYC/7tePpBzVvEtFaP1RV6/aVXGSmIg0K8vuvQnhOfY+KsIwF2JfeBcoJaJ4nNKC6 rUZwtSxmtKZ5J4gzUr7ZItk9KaYVY51IPK0OOcZ4OzmJbFda+ScA2e91R36nr5CoRGpY 58eVH5zzDITwbFAjuf607FP+r+Pqkz1EvEGaWb1sjGcWyJuMsCkRccftEDaj+QaS+OLs qnFxkVM+6Wwll4qjsvpGFlb6VVEsqN9Qtw53pni7CEnDULy7wMXoEU6dycKdDDWrIPDD yemA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CB0FDko0M1EYlrNa5elZozN4nSQP4VDTI8FHGWQf1fo=; b=tJCBs3mwvE5vuwL72e7C0NfyjrbdZ7hmRkWbl2Y4p34XztJ+OtDvJCNj57k1K1Q0Tg liEtq3GQgf8ByDcD0vaoi3vrLPobT1sIU/aTTCnmrVO3yb+7vLWlIh+3jV4ZhaSUPq+b rtFuDDgrCiPGEAp8v4DcjJLaTw6ANS/MAGcwV3+Ax8JJaxcQReqOQIOMX/HNkxZD+aXO /A2IrVDdgJ0veq/3YW3xW6OaAWysIfF67fpmbSNddc0nuABO0VyDdnoqkjMEQ40I10JA vAV/09CDEgfCylAGzxKYjcTcgNjc2lgWVjgyIdmfEbCdaNdYCKW1dW4EfONiYP/952O9 u5kA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wmzUuMX3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oc3-20020a17090b1c0300b001cba1057b12si901017pjb.95.2022.04.18.19.02.18; Mon, 18 Apr 2022 19:02:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wmzUuMX3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346123AbiDROZh (ORCPT + 99 others); Mon, 18 Apr 2022 10:25:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244603AbiDRONp (ORCPT ); Mon, 18 Apr 2022 10:13:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1C5738BC5; Mon, 18 Apr 2022 06:12:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4B5C260F16; Mon, 18 Apr 2022 13:12:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41AFEC385A1; Mon, 18 Apr 2022 13:12:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650287523; bh=oDeTHARGZEfrXPcCeIWg2xEfZgIW08C61yBMEcE/0AY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wmzUuMX3a144uGYfCLDW+QRg3YiyHFU3IEqFR+xQI27l155EkQqbPMMZ9du3RfNv3 pCM8DxUzlM+qXGimksODqLwbmqtsX2qm40ikSNh45BK/u3Bqq4greahfagyOpNMpmP kDaVnnzolg3xHmpg+nRX2JnMgmCTM71YOQZlzfuE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Geert Uytterhoeven , Christophe JAILLET , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.9 188/218] scsi: zorro7xx: Fix a resource leak in zorro7xx_remove_one() Date: Mon, 18 Apr 2022 14:14:14 +0200 Message-Id: <20220418121206.582458980@linuxfoundation.org> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220418121158.636999985@linuxfoundation.org> References: <20220418121158.636999985@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 16ed828b872d12ccba8f07bcc446ae89ba662f9c ] The error handling path of the probe releases a resource that is not freed in the remove function. In some cases, a ioremap() must be undone. Add the missing iounmap() call in the remove function. Link: https://lore.kernel.org/r/247066a3104d25f9a05de8b3270fc3c848763bcc.1647673264.git.christophe.jaillet@wanadoo.fr Fixes: 45804fbb00ee ("[SCSI] 53c700: Amiga Zorro NCR53c710 SCSI") Reviewed-by: Geert Uytterhoeven Signed-off-by: Christophe JAILLET Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/zorro7xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/zorro7xx.c b/drivers/scsi/zorro7xx.c index aff31991aea9..ee6d97473853 100644 --- a/drivers/scsi/zorro7xx.c +++ b/drivers/scsi/zorro7xx.c @@ -158,6 +158,8 @@ static void zorro7xx_remove_one(struct zorro_dev *z) scsi_remove_host(host); NCR_700_release(host); + if (host->base > 0x01000000) + iounmap(hostdata->base); kfree(hostdata); free_irq(host->irq, host); zorro_release_device(z); -- 2.35.1