Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934098AbXEER1X (ORCPT ); Sat, 5 May 2007 13:27:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934089AbXEER1X (ORCPT ); Sat, 5 May 2007 13:27:23 -0400 Received: from pat.uio.no ([129.240.10.15]:34920 "EHLO pat.uio.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934086AbXEER1W (ORCPT ); Sat, 5 May 2007 13:27:22 -0400 Subject: Re: [-mm patch] fix fs/nfs/nfsroot.c compile error From: Trond Myklebust To: Adrian Bunk Cc: Andrew Morton , davem@davemloft.net, David Howells , linux-kernel@vger.kernel.org, netdev@vger.kernel.org In-Reply-To: <1178385646.6561.46.camel@heimdal.trondhjem.org> References: <20070505014955.8f3990b5.akpm@linux-foundation.org> <20070505164422.GD8975@stusta.de> <1178385646.6561.46.camel@heimdal.trondhjem.org> Content-Type: text/plain Date: Sat, 05 May 2007 13:27:14 -0400 Message-Id: <1178386034.6561.53.camel@heimdal.trondhjem.org> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit X-UiO-Resend: resent X-UiO-Spam-info: not spam, SpamAssassin (score=-0.2, required=12.0, autolearn=disabled, AWL=-0.171) X-UiO-Scanned: A4C373152250432970BC2C9A983140303EDA2605 X-UiO-SPAM-Test: remote_host: 129.240.10.9 spam_score: -1 maxlevel 200 minaction 2 bait 0 mail/h: 152 total 1526572 max/h 8345 blacklist 0 greylist 0 ratelimit 0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 995 Lines: 33 On Sat, 2007-05-05 at 13:20 -0400, Trond Myklebust wrote: > On Sat, 2007-05-05 at 18:44 +0200, Adrian Bunk wrote: > > On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote: > > >... > > > Changes since 2.6.21-rc7-mm2: > > >... > > > git-net.patch > > >... > > > git trees > > >... > > > > match_table_t was made "const" and gcc doesn't like "const __initdata": > > Then please revert the "fix" to match_table_t... > > There is no reason for something like the nfsroot parser to be kept in > memory after the system has booted. That would be code bloat. > > Trond Alternatively, please change the nfsroot parser to use static struct match_token tokens[] __initdata = { That is in any case cleaner than using a typedef. Trond - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/