Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Apr 2022 13:29:06 +0530
From:   "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Subject: Re: [PATCH v1 16/22] powerpc/ftrace: Minimise number of #ifdefs
To:     Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Ingo Molnar <mingo@redhat.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Paul Mackerras <paulus@samba.org>,
        Steven Rostedt <rostedt@goodmis.org>
Cc:     linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
References: <cover.1648131740.git.christophe.leroy@csgroup.eu>
        <7ef4015badd5f1861cfc327a7641c84e0e5630ca.1648131740.git.christophe.leroy@csgroup.eu>
In-Reply-To: <7ef4015badd5f1861cfc327a7641c84e0e5630ca.1648131740.git.christophe.leroy@csgroup.eu>
MIME-Version: 1.0
User-Agent: astroid/4d6b06ad (https://github.com/astroidmail/astroid)
Message-Id: <1650267933.ewyj9l63lo.naveen@linux.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Christophe Leroy wrote:
> A lot of #ifdefs can be replaced by IS_ENABLED()
>=20
> Do so.
>=20
> This requires to have kernel_toc_addr() defined at all time
> and PPC_INST_LD_TOC as well.
>=20
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
>  arch/powerpc/include/asm/code-patching.h |   2 -
>  arch/powerpc/include/asm/module.h        |   2 -
>  arch/powerpc/include/asm/sections.h      |  24 +--
>  arch/powerpc/kernel/trace/ftrace.c       | 201 ++++++++++++-----------
>  4 files changed, 113 insertions(+), 116 deletions(-)
>=20
> diff --git a/arch/powerpc/include/asm/code-patching.h b/arch/powerpc/incl=
ude/asm/code-patching.h
> index 4260e89f62b1..071fcbec31c5 100644
> --- a/arch/powerpc/include/asm/code-patching.h
> +++ b/arch/powerpc/include/asm/code-patching.h
> @@ -217,7 +217,6 @@ static inline unsigned long ppc_kallsyms_lookup_name(=
const char *name)
>  	return addr;
>  }
>=20
> -#ifdef CONFIG_PPC64
>  /*
>   * Some instruction encodings commonly used in dynamic ftracing
>   * and function live patching.
> @@ -234,6 +233,5 @@ static inline unsigned long ppc_kallsyms_lookup_name(=
const char *name)
>=20
>  /* usually preceded by a mflr r0 */
>  #define PPC_INST_STD_LR		PPC_RAW_STD(_R0, _R1, PPC_LR_STKOFF)
> -#endif /* CONFIG_PPC64 */
>=20
>  #endif /* _ASM_POWERPC_CODE_PATCHING_H */
> diff --git a/arch/powerpc/include/asm/module.h b/arch/powerpc/include/asm=
/module.h
> index e6f5963fd96e..700d7ecd9012 100644
> --- a/arch/powerpc/include/asm/module.h
> +++ b/arch/powerpc/include/asm/module.h
> @@ -41,9 +41,7 @@ struct mod_arch_specific {
>=20
>  #ifdef CONFIG_FUNCTION_TRACER
>  	unsigned long tramp;
> -#ifdef CONFIG_DYNAMIC_FTRACE_WITH_REGS
>  	unsigned long tramp_regs;
> -#endif
>  #endif
>=20
>  	/* List of BUG addresses, source line numbers and filenames */
> diff --git a/arch/powerpc/include/asm/sections.h b/arch/powerpc/include/a=
sm/sections.h
> index 8be2c491c733..6980eaeb16fe 100644
> --- a/arch/powerpc/include/asm/sections.h
> +++ b/arch/powerpc/include/asm/sections.h
> @@ -29,18 +29,6 @@ extern char start_virt_trampolines[];
>  extern char end_virt_trampolines[];
>  #endif
>=20
> -/*
> - * This assumes the kernel is never compiled -mcmodel=3Dsmall or
> - * the total .toc is always less than 64k.
> - */
> -static inline unsigned long kernel_toc_addr(void)
> -{
> -	unsigned long toc_ptr;
> -
> -	asm volatile("mr %0, 2" : "=3Dr" (toc_ptr));
> -	return toc_ptr;
> -}
> -
>  static inline int overlaps_interrupt_vector_text(unsigned long start,
>  							unsigned long end)
>  {
> @@ -60,5 +48,17 @@ static inline int overlaps_kernel_text(unsigned long s=
tart, unsigned long end)
>=20
>  #endif
>=20
> +/*
> + * This assumes the kernel is never compiled -mcmodel=3Dsmall or
> + * the total .toc is always less than 64k.
> + */
> +static inline unsigned long kernel_toc_addr(void)
> +{
> +	unsigned long toc_ptr;
> +
> +	asm volatile("mr %0, 2" : "=3Dr" (toc_ptr));
> +	return toc_ptr;
> +}
> +
>  #endif /* __KERNEL__ */
>  #endif	/* _ASM_POWERPC_SECTIONS_H */
> diff --git a/arch/powerpc/kernel/trace/ftrace.c b/arch/powerpc/kernel/tra=
ce/ftrace.c
> index ffedf8c82ea8..4dd30e396026 100644
> --- a/arch/powerpc/kernel/trace/ftrace.c
> +++ b/arch/powerpc/kernel/trace/ftrace.c
> @@ -150,55 +150,55 @@ __ftrace_make_nop(struct module *mod,
>  		return -EINVAL;
>  	}
>=20
> -	/* When using -mkernel_profile or PPC32 there is no load to jump over *=
/
> -	pop =3D ppc_inst(PPC_RAW_NOP());
> +	if (IS_ENABLED(CONFIG_MPROFILE_KERNEL)) {
> +		/* When using -mkernel_profile or PPC32 there is no load to jump over =
*/
> +		pop =3D ppc_inst(PPC_RAW_NOP());

Why move this inside the if() statement? You can keep this out and drop=20
the else clause.

- Naveen