Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Apr 2022 23:18:54 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Tom Lendacky <thomas.lendacky@amd.com>
Cc:     Dionna Amalie Glaze <dionnaglaze@google.com>,
        linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
        Brijesh Singh <brijesh.singh@amd.com>, x86@kernel.org
Subject: Re: [tip: x86/sev] virt: Add SEV-SNP guest driver
Message-ID: <Yl3Vvhw+NKfC503u@zn.tnic>
References: <20220307213356.2797205-44-brijesh.singh@amd.com>
 <164940891958.389.8256762641375131456.tip-bot2@tip-bot2>
 <CAAH4kHZpwbJSE6tDz-3ZzMH75rmgDYvBQ5_gLteXRmEk54yORQ@mail.gmail.com>
 <Yl2cffonOopK6JrM@zn.tnic>
 <18e9197a-9e8d-a06f-3a55-bb548e649258@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <18e9197a-9e8d-a06f-3a55-bb548e649258@amd.com>
Precedence: bulk

On Mon, Apr 18, 2022 at 12:40:11PM -0500, Tom Lendacky wrote:
> The driver name is used when registering the driver in
> snp_init_platform_device() and isn't really referenced after that. The
> module name is sevguest.ko, while the device name ends up being
> /dev/sev-guest.
> 
> All that really matters is the device name that is exposed to user space.
> But if we want things to match, then, yes, we can change the name that is
> used in arch/x86/kernel/sev.c and drivers/virt/coco/sevguest/sevguest.c
> to "sev-guest" if that works. Do you want the module name to also be
> sev-guest.ko?

Just to ack this on the ML after our IRC discussion: yeah, let's keep
the common driver name sev-guest in order to avoid confusion. Other
functionality like SEV-ES or only SEV can still go in there, if needed,
but the name can remain.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette