Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp3360462pxb; Tue, 19 Apr 2022 00:11:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxXLpYDsKc92WQyujjNomFAJ8ubEEtP5eH3BgEU/YWyUBOZVs2MqLMP986P5gkrOXRG5rg X-Received: by 2002:a50:ba8a:0:b0:423:bdf5:41d6 with SMTP id x10-20020a50ba8a000000b00423bdf541d6mr14483968ede.204.1650352308362; Tue, 19 Apr 2022 00:11:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650352308; cv=none; d=google.com; s=arc-20160816; b=I20SGczst7h4EioNSO/JjleJE/WGgQtxAPbsdZby2nwoRgROkhaj1BBGqDy+b0elom zACcrJKLpKmbH8EYEPL3vi/e7Wk8cDpGFT+OO0lXHY1OSx9KXpjyrzgG6j9pO/HpCKDU cINiiMoYFFjUTV00K6PjMMSXMczzUPvG2CJnUeNOHMXhQwaV9p6Lrgw9R210gws9O9e8 WO4LHN33tp1zGU5hcrIlfEpWmqS3uMNzK4xKriDulWUtb7un05Cv3j59h+/DethIZCpE oJeHv6ioM7qcl3xca6OAxwYNMHBnqP/aJBTEEoQk3TwRRewULjKE3VZimt1i70poUy4Z rroQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=B8HB5UsMcYCH6dnCh61XsqKo6h5w3bfQReOb/+tBK5w=; b=XxfDCkIABnj+4fRuYPNPEKiuFMR63YPlqgzC5v5gNpLSO/RHHLCxxMh53+yd1ZgGWK OrmPE9ImYxCfpdnRpofpUP7xSVxFKIME2eRUCsGC69WskKzD9WVlapgOfAO6RaXlsHcO n81y53Pve6i9474FDaqw/H//lstoBftpdburQXpyxNX9xouzUXkqMF2KsQJeshuiVKMs SikljsrM33PdEeQmS6izgASGzgrVmWKfM0w76QYVFbbgKduASPNBOzvL61jq7uMs7jsg BIK7ItUgKDqmGmuRLPtYd6zpvlJc0YVCtREaaZbokxa/CRDp0QFFCFk7gdFKj1OlooM+ akgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WU9ydoNL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c41-20020a509fac000000b0041d149bb3d7si8283849edf.620.2022.04.19.00.11.24; Tue, 19 Apr 2022 00:11:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WU9ydoNL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345305AbiDRPXA (ORCPT + 99 others); Mon, 18 Apr 2022 11:23:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345327AbiDRPWY (ORCPT ); Mon, 18 Apr 2022 11:22:24 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E80B26E; Mon, 18 Apr 2022 07:19:45 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id 12so12426702pll.12; Mon, 18 Apr 2022 07:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=B8HB5UsMcYCH6dnCh61XsqKo6h5w3bfQReOb/+tBK5w=; b=WU9ydoNL8Xn3bewDq3z90aKYqnymssyAL2SVHjHgL1bqcAi1HiUt3jlZq9AD2KlvHD e+SONocd1RP+tpUBOTp4KUceRLJ9XmeV78B/lNq/ZXqCPOz7dbBWsTFuH6dTzyTp3HOU hSC7kJFZ6/qdFkDHR086kuDvduIb1BFAH1Jl0C7pdbV2+LYYxUwL7xNzZk0QQc/gAnkf RVNRkItIK9s4WQQLLlIq+9nXFKnkwx7W6QNQzhxkq8M7sO0OdyBJVt89+QxMSsldeZ3T iyRcHw8WlYj8Z7RgIdhDzRyqwprEBCsjRfR7NfipDNTHjo2uwuf9Jjd6b+0JQ96ScNJi e6dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=B8HB5UsMcYCH6dnCh61XsqKo6h5w3bfQReOb/+tBK5w=; b=i4HXF4Q8TWiSPDMomuVgwxjhTESyut9zqCuYtWauBewsTdhclA6oE7rcWjLEZIivIG J47W3ryRLJjyC+acLJgSOlPlF67eL3Bgap3+2m5t1mZydNJDTESHNnEo+34vCojd7Yy9 wfnwPyuipi6maqFhlguzzWs8eDiDmndyLSGhU4XeHYYX3PgMW4U3DnXjrIlUZSHl2+Bs GRm5eCbw9BZUNH+x1c9V7SKszbfV4yotC07TQh4ZMwDUsWEDdTAkmovlT5A6SHpKKI97 TEWAHNwwCWa1jzD6shTjv3UgIsdVsbGa0H1HcW1gSpngtVnFBpKTuoyXbqKGf8x6CeYT x8BA== X-Gm-Message-State: AOAM532PyTRcjszKUOun8PT0l6RryigX3u1S5wISHluUnakASTpjoKPw Av1hIb/9hXm/wdwt4rukGiw= X-Received: by 2002:a17:90b:17c3:b0:1c6:b0ff:abf with SMTP id me3-20020a17090b17c300b001c6b0ff0abfmr13182032pjb.24.1650291585099; Mon, 18 Apr 2022 07:19:45 -0700 (PDT) Received: from localhost ([210.21.229.138]) by smtp.gmail.com with ESMTPSA id a2-20020a17090ad80200b001d27824fc24sm5732955pjv.5.2022.04.18.07.19.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 07:19:44 -0700 (PDT) From: Yunbo Yu To: vkoul@kernel.org Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Yunbo Yu Subject: [PATCH] dmaengine: mv_xor_v2: move spin_lock_bh to spin_lock Date: Mon, 18 Apr 2022 22:19:40 +0800 Message-Id: <20220418141940.1241482-1-yuyunbo519@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is unnecessary to call spin_lock_bh() for that you are already in a taselet. Signed-off-by: Yunbo Yu --- drivers/dma/mv_xor_v2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c index 9c8b4084ba2f..f10b29034da1 100644 --- a/drivers/dma/mv_xor_v2.c +++ b/drivers/dma/mv_xor_v2.c @@ -591,14 +591,14 @@ static void mv_xor_v2_tasklet(struct tasklet_struct *t) dma_run_dependencies(&next_pending_sw_desc->async_tx); /* Lock the channel */ - spin_lock_bh(&xor_dev->lock); + spin_lock(&xor_dev->lock); /* add the SW descriptor to the free descriptors list */ list_add(&next_pending_sw_desc->free_list, &xor_dev->free_sw_desc); /* Release the channel */ - spin_unlock_bh(&xor_dev->lock); + spin_unlock(&xor_dev->lock); /* increment the next descriptor */ pending_ptr++; -- 2.25.1