Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp3397406pxb; Tue, 19 Apr 2022 01:18:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsp6Zgp2oQIZCHrUyEdjzM45P2kHdEtkpKN4sexZ4AuuNaECiHVypaVOqA3Sl9d+F0ieuh X-Received: by 2002:a63:714:0:b0:3a1:d658:709d with SMTP id 20-20020a630714000000b003a1d658709dmr13548528pgh.562.1650356303447; Tue, 19 Apr 2022 01:18:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650356303; cv=none; d=google.com; s=arc-20160816; b=GY42hGnP29YCQpytqqR/rt3zTo4ZDmZiY7p/1m0lKHF5TSNotOdZY9t0ykErCZ6rQC EjHaZDt7mqaFQXQvK3z/8e+Xzn+uq1B9A4pogG2V84/GGDRMjeTI9nmHUOI68wdTjGfS GcyvEscf0DSEz+LXcnsTB2nQgxuPsKVAVC1N+jCM4fYEy3TbsN7SiMOioerus2/l5Zwc PleEU2QKcpU93zriw2kj4TYK25PpFN2JnVlOD+JGCkiRVgTsGH8Bmq7TR4UAvNN/Im9E r/8SMYhrp+HVvrGqWcP2KaRydF0X41J9U8mv+T6ka1qQvShxXG9zXXKiC22LgT3JUstN slOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uMLCd1jUQmqd+kJmG30f48mw7LnIWfBX+V3Zn86PmXM=; b=n09J4RCdVj48wzFyxVcmEdj/yaIsjXtjYV2sGkM6zPAaKTsmfLXd4PycCI7KOqEDge p9zxIFZDqcB27uhRd8+WVdf8H65pmyQ+VH3K9HNahS/UIO3/JNL3VSySkTvOqlnaHBIX XaYNay3om7YJO5uEvRr4WVvYnjiO2omZBTw2/iiR556Zp8YS9UtlazdK5pXpcDokg4kt 6uRMKyjrbmyxm7JAcGM4VK1bFTbN9OBL/wGNNQBPgTaLIRc/nv5DgpuR03n4BApM3IXw USGEViHfOLd/VD+D4Vi+oMS86RUdWryKPX7woftFM8UByz6nDNGwUW3oGVecCn3i3797 ikIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ApI55Mca; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v1-20020a634801000000b0039d68b7a67asi11134348pga.843.2022.04.19.01.18.09; Tue, 19 Apr 2022 01:18:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ApI55Mca; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348189AbiDSEVy (ORCPT + 99 others); Tue, 19 Apr 2022 00:21:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238655AbiDSEVw (ORCPT ); Tue, 19 Apr 2022 00:21:52 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 623FE2BB20 for ; Mon, 18 Apr 2022 21:19:11 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id k29so22646798pgm.12 for ; Mon, 18 Apr 2022 21:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uMLCd1jUQmqd+kJmG30f48mw7LnIWfBX+V3Zn86PmXM=; b=ApI55McaYqWh8Bk8YPuzmhrlx3JF8GuYaCqr1JzFraTOnY7Oqpyq+djrXZmHPoD6cp YQZTi8GwjFlp9cukp7VIMiQf6RStcUcrBv/gDjCL/ChcqYwONw8wxqhd76EBTG/fMbs+ yiv6AckYO+kW04b3zy+Dp6WMbYVlU2qkSlNI0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uMLCd1jUQmqd+kJmG30f48mw7LnIWfBX+V3Zn86PmXM=; b=JY4yTtE7CeV1nuJEAoNjb60AEtONqOfK9ZAN+OYwAR7Fss1Mf1cGJzv6EHa+z5VNbW V3yR3FHJBbPEb419Wn4109Jhogd/IPeY5WWsURMmqlDtvDL+MJFINuaGJYEa96komqSn 8Rg02L34UPwRLiWyiW/ueOTDrdL1uaZMNW5nSokKnfS/xef8tVHAEYyjdT9JdVtfIWB8 HX4nC4FFsvHxknxBg/PVZkulHSdxTT/UpTNlGnEMj4n5lVynlxWikZsG6OCc7c3ij1NI mcA3NREWuBO3Qt5d4PfgywSdameSt7XanZGc0aIhhml9ubDFsuUuyh0Nvs/yPo7gW2In efIA== X-Gm-Message-State: AOAM530OSl50U5+4Nlxiw3kVjwxZAkXeUZj31fsmUu1Pu6p/bjObHHVJ 3YjOpnOq+DaBewkGeUmA7dzExw== X-Received: by 2002:a05:6a00:c8f:b0:50a:77a3:e7b with SMTP id a15-20020a056a000c8f00b0050a77a30e7bmr7825616pfv.41.1650341950925; Mon, 18 Apr 2022 21:19:10 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z13-20020a17090a468d00b001c7db8e6ac7sm14621432pjf.40.2022.04.18.21.19.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 21:19:10 -0700 (PDT) Date: Mon, 18 Apr 2022 21:19:09 -0700 From: Kees Cook To: kernel test robot Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: include/linux/fortify-string.h:267:25: warning: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? Message-ID: <202204182118.5EB742C6@keescook> References: <202204142318.vDqjjSFn-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202204142318.vDqjjSFn-lkp@intel.com> X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 14, 2022 at 11:54:03PM +0800, kernel test robot wrote: > In function 'fortify_memcpy_chk', > inlined from 'firm_send_command' at drivers/usb/serial/whiteheat.c:587:4: > >> include/linux/fortify-string.h:267:25: warning: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wattribute-warning] > 267 | __write_overflow_field(p_size_field, size); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Thanks! Proposed patch: https://lore.kernel.org/linux-hardening/20220419041742.4117026-1-keescook@chromium.org/ -- Kees Cook