Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp3441930pxb; Tue, 19 Apr 2022 02:36:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhYBi1FB1QfIVM7SYrf/7XLm3JVD1vCBqaYfAoXvO/xJ97750OldxsSEDmdjdiriWMX9Rc X-Received: by 2002:a63:5a20:0:b0:3aa:2fd0:9e94 with SMTP id o32-20020a635a20000000b003aa2fd09e94mr2981544pgb.602.1650360997384; Tue, 19 Apr 2022 02:36:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650360997; cv=none; d=google.com; s=arc-20160816; b=Ve/aEaDFjzTsktspKdAApyJuy+2dO1/GDfQpMa1XvgJj49kZbEJ9ubRoyYY2MdMvUH KX9/37Xhk7bjXCZ3gXps3nRDhEN7Sju62q2bZxp1e6V7GWFPM/Lnx8zlUXreA0qV4doV O9eAo4VekhRwo3TTj8KX68KheLknQ9i8qv535aq8oXAW4nWQA4JJJSb1kNyFOMxYTCbW BDnafrIQs1S+NRE9+THVFs1Z7HLSK5tdG1y2Puft7SrpGHJkWh74qwOlJ6hNp4y6rABK jSzaCQAi6mYJBoDYXevBljyCiMmrKlrRxbHZBBvOUqslHYnaY1qWIaRBCyqi4UW0o4ol j5JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=K+wycLbtOGXfx3rrJ8YJAcjSMtOkWcA7L4SAeEXTlpk=; b=hPWiCwSjX3srFUvuyNKuOEMd34AYp+aYVcxuc6e8CnldMpqBk+u5sNl2n0gq/dgbts zGn5r4C/QZNErcmmvs9HtQZrOa+z+s+l70Zu86oNM2EmPJqgEm93twfz3Ub9ej50P/md mPM6+BeFO5IrhHQdo6sICtkBYhpkgkg1iZwyoo5zpM1lpSgCoZz/XIEz9o3nmUGOrBDZ cFppjq6FB4TT/2PPfkK0qBG9bGjwN7K9RVV07l0q/mjw+blFlu10OrvIMh8xnNPmalSe OhsvoiPNiezg/2nqucU2Xk0ude5AE3JtJnTTw1t09Y4d3vlmNc3PglhwBcQhiiOi9sWT lKcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=KuHwDA8Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id on16-20020a17090b1d1000b001c6acc3b2b3si1889740pjb.23.2022.04.19.02.36.22; Tue, 19 Apr 2022 02:36:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=KuHwDA8Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245626AbiDSBlA (ORCPT + 99 others); Mon, 18 Apr 2022 21:41:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243639AbiDSBk6 (ORCPT ); Mon, 18 Apr 2022 21:40:58 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A44C2317D; Mon, 18 Apr 2022 18:38:17 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id c1so12463401qkf.13; Mon, 18 Apr 2022 18:38:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=K+wycLbtOGXfx3rrJ8YJAcjSMtOkWcA7L4SAeEXTlpk=; b=KuHwDA8ZkRKEWblQ0FoA9kY8ZMJKY/Tyfsk1CHA3Y5cMY7z0WM64lb+55tASiqvSDc C2M8Z31xHCidij1WbgEo3ClbIPCkkPj8waHFaS1EdCU78mL/C8Xg1hfBOazNdCJF5eKQ qNQxqR0pLOUbxtuw3z7LtkOzG0vrmX6PLvuLp6rkBYNuWuYs/bgJAfsHXGwCrgEUbNgV TRPt8on0LUafnwEQ7YN7UT/5mcrTw/rdkxQI8wwWXvy/N9d4aKo4h3Ja+vEDQ8Lsd78u 9tVU7tkXberW0tv9bL99VSW6wlsbCmMc0beg9gth7dkmT7560rKThghxpBdm0EbQTsL6 rGWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=K+wycLbtOGXfx3rrJ8YJAcjSMtOkWcA7L4SAeEXTlpk=; b=GczMJlWh30hNJFjzotQYaat2vvXXd3dQxoCC+yRz5q11hoiBGMwEOybLv2YWlVYBJP TB4e15GlMRwDeQuHQjBnK2pYWhuQLRhZmUhcFaN/sWyyh0Kk/yqGtP8VVgrO6y+vS7Q4 t92ijovEiA3Wx8Ih+6j6Q3Xm3vVAG3e/myncOQzlGh/YDWQ1S1UElGzYWD1Mq7V+jtQF cXoEC2W71r3MW5Z+iRIGn48WdGfjekTrEeHQ8nwl6IL8RdS2lOZkO0M39/CL17hje66M p5bgArs42oT5KWcpn8Lxqvu2hLbrZZL7WZhJ+q4MaxnhTWpirna0De/hYI+/CtA8NwQE GJow== X-Gm-Message-State: AOAM532WspcBHTo0irZsJQRAwJ6UlEy23H0i2snjMG3NnEsyAZcu6e8G oPC5DvaX0aJgarJNBdDX8IA= X-Received: by 2002:a37:aad5:0:b0:69e:a0ba:ffa3 with SMTP id t204-20020a37aad5000000b0069ea0baffa3mr4295285qke.317.1650332296428; Mon, 18 Apr 2022 18:38:16 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id 12-20020a37080c000000b0069ea5b5e1d2sm1904157qki.83.2022.04.18.18.38.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 18:38:16 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: lv.ruyi@zte.com.cn To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl Cc: ming.qian@nxp.com, shijie.qin@nxp.com, eagle.zhou@nxp.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Lv Ruyi , Zeal Robot Subject: [PATCH] media: amphion: fix error check return value of debugfs_create_file() Date: Tue, 19 Apr 2022 01:38:09 +0000 Message-Id: <20220419013809.2561635-1-lv.ruyi@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lv Ruyi If an error occurs, debugfs_create_file() will return ERR_PTR(-ERROR), so use IS_ERR() to check it. Fixes: 9f599f351e86 ("media: amphion: add vpu core driver") Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/media/platform/amphion/vpu_dbg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/amphion/vpu_dbg.c b/drivers/media/platform/amphion/vpu_dbg.c index 376196bea178..5cef1fd41a74 100644 --- a/drivers/media/platform/amphion/vpu_dbg.c +++ b/drivers/media/platform/amphion/vpu_dbg.c @@ -413,7 +413,7 @@ int vpu_inst_create_dbgfs_file(struct vpu_inst *inst) vpu->debugfs, inst, &vpu_dbg_inst_fops); - if (!inst->debugfs) { + if (IS_ERR(inst->debugfs)) { dev_err(inst->dev, "vpu create debugfs %s fail\n", name); return -EINVAL; } @@ -451,7 +451,7 @@ int vpu_core_create_dbgfs_file(struct vpu_core *core) vpu->debugfs, core, &vpu_dbg_core_fops); - if (!core->debugfs) { + if (IS_ERR(core->debugfs)) { dev_err(core->dev, "vpu create debugfs %s fail\n", name); return -EINVAL; } @@ -463,7 +463,7 @@ int vpu_core_create_dbgfs_file(struct vpu_core *core) vpu->debugfs, core, &vpu_dbg_fwlog_fops); - if (!core->debugfs_fwlog) { + if (IS_ERR(core->debugfs_fwlog)) { dev_err(core->dev, "vpu create debugfs %s fail\n", name); return -EINVAL; } -- 2.25.1