Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp3510916pxb; Tue, 19 Apr 2022 04:22:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygCX/Je9tnw+rqdZprG8J2KKtETwOpFarMtSGqnmxWpS0FZuB7z6uja6EdG11NTfzC1LEL X-Received: by 2002:a17:906:a08b:b0:6cf:65bc:e7de with SMTP id q11-20020a170906a08b00b006cf65bce7demr13347690ejy.220.1650367324472; Tue, 19 Apr 2022 04:22:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650367324; cv=none; d=google.com; s=arc-20160816; b=WcpHZW2NhT9zxiKbIfEod+/wMLon8Wan7yihQq8Fe1yZIrG8Dtlo9SLf6QckVve8de 6/zUQR/Y61ILKk3CUXSeTcj+UAZ+yo1Y8RIFuuW1kOnAtEVwx2HHJXv7gYAOXLaL9c2p fn6ZSwLFQFzvzXQyUmKwHEIOd4CU8cRgf3/OXPvo5oCOmhI+nfu2+Z9PKjsuQopHRVwk YCik0yCFQ3FlP0NfYOLvF3kSgjTWerJtWcPwz5RcYThssFrvn6qmCEaGbepggDyKJqpm ZmnltfRbrAdQGCTVVxDQAf5L5qrE0IHOhs/z8ac/VNdT8erC6yl5lrxfMgAbXIO0Wxsl 0VfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ccR/mnwveIJy1+ZaW/EVppjy7Ucpakkl1UjrV+8YXAk=; b=T5hFW6uZN4ABjCw+ijQMsutsvKABEmzF1cnZStS8C5oIuqnbZreOqFRcrmJfV7msgC VRoIq/P9TOoGvM7fXdrPamDNRIZwnRsEPFE/BfVM44taKhmq5+wUQkxvWYGTD97LXz8M JV/k1bxSeshBQlZM2IyvoNboGoTtlp36jbbOsuC3Ranq3ndU7FA+0TXW0KSIc4cKZzwZ VHx9t5Nb7Xt92PehCD35Y9B1n9S1DMRtRr5QN+RBJjAj6a/16tvlWeidkEnaql32+OKo qdggM6gPjiYWjHHSjgRQPTTxQRAVolSmyO8FomkfXpYjwAsylrjV1NwpZFJAP2ItleIY aEKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XEiadJDP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j12-20020a05640211cc00b00423f052f4ddsi3604567edw.314.2022.04.19.04.21.40; Tue, 19 Apr 2022 04:22:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XEiadJDP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345330AbiDRPXH (ORCPT + 99 others); Mon, 18 Apr 2022 11:23:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345448AbiDRPWh (ORCPT ); Mon, 18 Apr 2022 11:22:37 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99C8AD64D4; Mon, 18 Apr 2022 07:20:25 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id j71so5622082pge.11; Mon, 18 Apr 2022 07:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ccR/mnwveIJy1+ZaW/EVppjy7Ucpakkl1UjrV+8YXAk=; b=XEiadJDP5pRoh9TElIIjDpGwvXHzinAi+cZWXrgMmFKiX356STHcLvNbO/c4ZXqYR+ Knr6EZeYjIYRu+IGA4188A6O5jEjDX+gUVdW9aHQQlKjhWwpyR56ED5Vp8stWXA4J1ak 8AHGY95ejcUuPKxQJ1d+az7rMgzmOIpfUxg2dgkIvTXy+XBlc1r3waKeAPgceGMgZ7mg puYi4vLQaxF1WxYlH6DaagWeva2/CIpCKVWQNfy+fjeue2xiKePqXJgpnSzW2mH1gbJE oTccNo7N0WvpV3hPRzj37uMo0R6+5UHRTP0CT34GEOwDNcTdxLBet0zw5PCYmFZjPFM4 wEPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ccR/mnwveIJy1+ZaW/EVppjy7Ucpakkl1UjrV+8YXAk=; b=7fEOISAzpKMNi3Kfp4ZYYp++bpV7TZ9q+EByBMjbDcEivS7VV1+Gcv4w4KCJNMvLLB wFb4sXwti+Pe7lyxeQ1OQbNLqojmFtICsbX/v7ISY80krrkv8qTguTSKw+vCLMqOSnV+ WxMHajkQpo0pRZAPHUFepslWZQ3Acri5MdshwbUUG44Yxd2Y7l/yApDxW/ggEgBAhw1d gvG2D0m8si05T9mUle+x9shahDGtc8E7is26qW4CDecsc+7cuAokxqm09PrCxw6afPBC 1NIfUt+kjmZfAP2pzYuRMas2nBVEn2LHn9Z5jJiQsF5FA5HHdodSf82O0ubpGiiGwpIE yTAg== X-Gm-Message-State: AOAM532h7p+tCBLRal/8Z9JeLEeCzhwkS1WIMY98ugwVEk+B6TQzlHw5 buHi9c8PdEidYZ5H0EUt+bneZWgP5ZJhB/NQyVs= X-Received: by 2002:a05:6a00:1310:b0:4ca:cc46:20c7 with SMTP id j16-20020a056a00131000b004cacc4620c7mr12720042pfu.44.1650291624922; Mon, 18 Apr 2022 07:20:24 -0700 (PDT) Received: from localhost ([210.21.229.138]) by smtp.gmail.com with ESMTPSA id y15-20020a17090a1f4f00b001c7ecaf9e13sm13425938pjy.35.2022.04.18.07.20.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 07:20:24 -0700 (PDT) From: Yunbo Yu To: logang@deltatee.com, vkoul@kernel.org Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Yunbo Yu Subject: [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock() Date: Mon, 18 Apr 2022 22:20:21 +0800 Message-Id: <20220418142021.1241558-1-yuyunbo519@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is unnecessary to call spin_lock_bh() for you are already in a tasklet. Signed-off-by: Yunbo Yu --- drivers/dma/plx_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c index 1ffcb5ca9788..12725fa1655f 100644 --- a/drivers/dma/plx_dma.c +++ b/drivers/dma/plx_dma.c @@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev) struct plx_dma_desc *desc; u32 flags; - spin_lock_bh(&plxdev->ring_lock); + spin_lock(&plxdev->ring_lock); while (plxdev->tail != plxdev->head) { desc = plx_dma_get_desc(plxdev, plxdev->tail); @@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev) plxdev->tail++; } - spin_unlock_bh(&plxdev->ring_lock); + spin_unlock(&plxdev->ring_lock); } static void plx_dma_abort_desc(struct plx_dma_dev *plxdev) -- 2.25.1