Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932318AbXEETJE (ORCPT ); Sat, 5 May 2007 15:09:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932985AbXEETJE (ORCPT ); Sat, 5 May 2007 15:09:04 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:39055 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932318AbXEETJD (ORCPT ); Sat, 5 May 2007 15:09:03 -0400 Date: Sat, 5 May 2007 21:09:01 +0200 From: Adrian Bunk To: Andrew Morton Cc: jsipek@cs.sunysb.edu, Christoph Lameter , linux-kernel@vger.kernel.org, unionfs@filesystems.org Subject: Re: [-mm patch] fix unionfs compilation Message-ID: <20070505190901.GJ8975@stusta.de> References: <20070505014955.8f3990b5.akpm@linux-foundation.org> <20070505170012.GF8975@stusta.de> <20070505115718.a1a0b61e.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20070505115718.a1a0b61e.akpm@linux-foundation.org> User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2106 Lines: 61 On Sat, May 05, 2007 at 11:57:18AM -0700, Andrew Morton wrote: > On Sat, 5 May 2007 19:00:12 +0200 Adrian Bunk wrote: > > > On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote: > > >... > > > Changes since 2.6.21-rc7-mm2: > > >... > > > git-unionfs.patch > > >... > > > git trees > > >... > > > > <-- snip --> > > > > ... > > CC fs/unionfs/super.o > > /home/bunk/linux/kernel-2.6/linux-2.6.21-mm1/fs/unionfs/super.c: In function ‘init_once’: > > /home/bunk/linux/kernel-2.6/linux-2.6.21-mm1/fs/unionfs/super.c:822: error: ‘SLAB_CTOR_VERIFY’ undeclared (first use in this function) > > /home/bunk/linux/kernel-2.6/linux-2.6.21-mm1/fs/unionfs/super.c:822: error: (Each undeclared identifier is reported only once > > /home/bunk/linux/kernel-2.6/linux-2.6.21-mm1/fs/unionfs/super.c:822: error: for each function it appears in.) > > make[3]: *** [fs/unionfs/super.o] Error 1 > > > > <-- snip --> > > > > Signed-off-by: Adrian Bunk > > > > --- > > --- linux-2.6.21-mm1/fs/unionfs/super.c.old 2007-05-05 18:45:25.000000000 +0200 > > +++ linux-2.6.21-mm1/fs/unionfs/super.c 2007-05-05 18:46:03.000000000 +0200 > > @@ -819,8 +819,7 @@ > > { > > struct unionfs_inode_info *i = v; > > > > - if ((flags & (SLAB_CTOR_VERIFY | SLAB_CTOR_CONSTRUCTOR)) == > > - SLAB_CTOR_CONSTRUCTOR) > > + if (flags & SLAB_CTOR_CONSTRUCTOR) > > inode_init_once(&i->vfs_inode); > > } > > Bah, that was hidden from my allmodconfig because CONFIG_UNIONFS is inexplicably > dependent upon CONFIG_SLAB. > > How come? http://lkml.org/lkml/2007/2/19/326 cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/