Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933165AbXEETQi (ORCPT ); Sat, 5 May 2007 15:16:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933174AbXEETQi (ORCPT ); Sat, 5 May 2007 15:16:38 -0400 Received: from filer.fsl.cs.sunysb.edu ([130.245.126.2]:45491 "EHLO filer.fsl.cs.sunysb.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933165AbXEETQh (ORCPT ); Sat, 5 May 2007 15:16:37 -0400 Date: Sat, 5 May 2007 15:13:13 -0400 From: Josef Sipek To: Andrew Morton Cc: Adrian Bunk , jsipek@cs.sunysb.edu, Christoph Lameter , linux-kernel@vger.kernel.org, unionfs@filesystems.org Subject: Re: [-mm patch] fix unionfs compilation Message-ID: <20070505191313.GA5834@filer.fsl.cs.sunysb.edu> References: <20070505014955.8f3990b5.akpm@linux-foundation.org> <20070505170012.GF8975@stusta.de> <20070505115718.a1a0b61e.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20070505115718.a1a0b61e.akpm@linux-foundation.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2359 Lines: 62 On Sat, May 05, 2007 at 11:57:18AM -0700, Andrew Morton wrote: > On Sat, 5 May 2007 19:00:12 +0200 Adrian Bunk wrote: > > > On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote: > > >... > > > Changes since 2.6.21-rc7-mm2: > > >... > > > git-unionfs.patch > > >... > > > git trees > > >... > > > > <-- snip --> > > > > ... > > CC fs/unionfs/super.o > > /home/bunk/linux/kernel-2.6/linux-2.6.21-mm1/fs/unionfs/super.c: In function ‘init_once’: > > /home/bunk/linux/kernel-2.6/linux-2.6.21-mm1/fs/unionfs/super.c:822: error: ‘SLAB_CTOR_VERIFY’ undeclared (first use in this function) > > /home/bunk/linux/kernel-2.6/linux-2.6.21-mm1/fs/unionfs/super.c:822: error: (Each undeclared identifier is reported only once > > /home/bunk/linux/kernel-2.6/linux-2.6.21-mm1/fs/unionfs/super.c:822: error: for each function it appears in.) > > make[3]: *** [fs/unionfs/super.o] Error 1 > > > > <-- snip --> > > > > Signed-off-by: Adrian Bunk > > > > --- > > --- linux-2.6.21-mm1/fs/unionfs/super.c.old 2007-05-05 18:45:25.000000000 +0200 > > +++ linux-2.6.21-mm1/fs/unionfs/super.c 2007-05-05 18:46:03.000000000 +0200 > > @@ -819,8 +819,7 @@ > > { > > struct unionfs_inode_info *i = v; > > > > - if ((flags & (SLAB_CTOR_VERIFY | SLAB_CTOR_CONSTRUCTOR)) == > > - SLAB_CTOR_CONSTRUCTOR) > > + if (flags & SLAB_CTOR_CONSTRUCTOR) > > inode_init_once(&i->vfs_inode); > > } > > Bah, that was hidden from my allmodconfig because CONFIG_UNIONFS is inexplicably > dependent upon CONFIG_SLAB. > > How come? As it was discussed a while back on the mailing lists, Unionfs is trying to be smart and tries to do reallocation on its own. The way it does it makes it depend on some internals of the SLAB allocator. There have been some patches out there for a realloc function (by Pekka Enberg, IIRC), but as far as I can tell, they haven't been merged in. Josef "Jeff" Sipek. -- In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. - Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/