Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp3615969pxb; Tue, 19 Apr 2022 06:39:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxh/n5Gr5gQWdR8s7bTislmkcMebjgrqDf5WMHa6VP8bS/TWwOJZKi8VhM24dxjFcfV11Q X-Received: by 2002:a17:906:2c0d:b0:6e8:979c:be8 with SMTP id e13-20020a1709062c0d00b006e8979c0be8mr14086921ejh.239.1650375597753; Tue, 19 Apr 2022 06:39:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650375597; cv=none; d=google.com; s=arc-20160816; b=gPSQPMD6lgagw7BDDCgqmiP4chYNTp1nB6nx4mR3b52kc9JHok9qnFZMPiFtuHe3BK eehNcQ+8BBZF/Erf9yRGdMPr8DWkZtsFX3iBedO85UkF+ef1XnaFnVms4QK9Lb1BzcXc 3xqZ6rimKJau9ln0dANxA2ZVTVrelSBke4Y/uFpLRnA2ac9RxcNUpki6jCf5oW0gtk7b TQfBeEztz304Jcoy/WuhvfOMHdyJXRJpXom4co6mkCgTt0VI/BF/NOdbS+1t0UGmHAxK UruLQp/bSjeqCQN2dYtv5v4K1sDKUfIPy+pExD+ynjxG2Flc2aWr+06+Xo7J3K8mKYeQ nZ1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=oU3y5yW4d7qfHisZMvTaFXwQA+DzftsKpFKH252JMwQ=; b=rxnMiRNT4qnR/3Lt5SHtSLci/9fnkSQDUaKxi3mgFgpF+jFlFCovPKm0z/fFWwGs73 Wac7NYBSOPQitHUyYmku0apsP6/GC4HZy3VGuIhvNJ7rPZ7xntfsUstg2NKb/x7D+OyQ rFBhypI+e+7AzP4Ax+5kt45hl9ZdxPc+fo8wOJPE9YEUxExRDdCP6IMBWUWkJ0Hjrc0y amdMm0mqupxBcdobD0ygZbNLUjuzlLvgjlnQoxzhMZx2EpUMgzj5KeKB8sc8boKvlc/f 4YpdZWXO/U23RtiD4lNCnzaKKeMBDK6+BmvqYqM/WnMqT9nwBD8l3Yhl6Ay9tEaJCvAn H7+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=W9bsQ8i4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i27-20020a170906265b00b006e8910cb819si3580289ejc.825.2022.04.19.06.39.33; Tue, 19 Apr 2022 06:39:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=W9bsQ8i4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243132AbiDRNjw (ORCPT + 99 others); Mon, 18 Apr 2022 09:39:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241239AbiDRNLi (ORCPT ); Mon, 18 Apr 2022 09:11:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68EB82D1E5; Mon, 18 Apr 2022 05:50:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6565661254; Mon, 18 Apr 2022 12:50:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58C2BC385A1; Mon, 18 Apr 2022 12:50:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650286239; bh=H2E+hkoWrFyiw9Yw9enrsHb/6o1hrtPFBfEID+qRoMM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W9bsQ8i4+GuJEgh6CL6+ftOfmsbYjYS2an8Rwwh+7sByVMnmSxSirghWbsyGE2mmq +9N6bNcvjQ2TY14dDvloEOdsjUSIFv2xlazLb9ZRp8sAomH5zScBRNNh5ZKxuNy/pm M/BdhUWaVResTLQKnSjArFVJZDrcv/0LxpjPB3bI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 071/284] media: coda: Fix missing put_device() call in coda_get_vdoa_data Date: Mon, 18 Apr 2022 14:10:52 +0200 Message-Id: <20220418121212.707431987@linuxfoundation.org> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220418121210.689577360@linuxfoundation.org> References: <20220418121210.689577360@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit ca85d271531a1e1c86f24b892f57b7d0a3ddb5a6 ] The reference taken by 'of_find_device_by_node()' must be released when not needed anymore. Add the corresponding 'put_device()' in the error handling path. Fixes: e7f3c5481035 ("[media] coda: use VDOA for un-tiling custom macroblock format") Signed-off-by: Miaoqian Lin Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/coda/coda-common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c index 5b87c488ee11..993208944ace 100644 --- a/drivers/media/platform/coda/coda-common.c +++ b/drivers/media/platform/coda/coda-common.c @@ -360,6 +360,7 @@ static struct vdoa_data *coda_get_vdoa_data(void) if (!vdoa_data) vdoa_data = ERR_PTR(-EPROBE_DEFER); + put_device(&vdoa_pdev->dev); out: if (vdoa_node) of_node_put(vdoa_node); -- 2.34.1