Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp3653202pxb; Tue, 19 Apr 2022 07:19:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvdf2ePT79r9uE1OZ2m0REnYMQAFA17gPlMbjd+RwhkDI8/qkDPUw5ZJtErP5rMQObCCEO X-Received: by 2002:a17:902:748c:b0:158:3461:ac75 with SMTP id h12-20020a170902748c00b001583461ac75mr15782353pll.114.1650377962907; Tue, 19 Apr 2022 07:19:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650377962; cv=none; d=google.com; s=arc-20160816; b=nSgtsY1Q5nYiOp3Ztc4GicYadJsnQH9p/gBlERoOHhWiNlRwLU/CCPotXKUuj+m3C5 p2/qmcRiotGs9HkQ0/kf3+1O2TeqRb5/JISojQTTrzsTwSbe01nM8anoqxGpfAnPLwrR egceRu0Yrd41ekbQ2TARYqyQkuBfyKPwAZUNjz3ZUYbd6/PCQcyv7fa0xHc14v6XSFO9 eg4PfRolGIOQ0p0+gDinJN9r0EP2Qce8dmESqi+g0IwvEBwfbVgZoWO2d8qh8QGSvWTz 0CS2AH/MAUVK3J/cl7cfK0MKvrLhsQuNd2OKsk/o1a3T2quK3A7Gwyb1A//OR74fPRpE 2qwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:dkim-signature:dkim-signature; bh=7FH/cZqwHqkstNxttHiwShTx35esBf5x9xB4oSROZV8=; b=x3E5y3nce/HcbdG30RPcoCEtqRzrQ+kSshNgIHGE+yFiiVbijIFO8NbY3ZUOP3V+bk +IiP8vmeFczMng7jiEEKmD8HvjKL8+4GI5wYzh0MvM1iiUZO+bZNeDxdKe9ZtkNuQpkj rlv1oS5nrNV+J0L1d9eBeA/417jvJz33PrfgWfyGmrzzoRrxsKSGuZKEdX5LRJesWWwG SmsWYT8l+hDCNndY/HnAyDKmEcx5q4dS8BdAcbshKj/83X+QA3xrGFASlbEVKPsRkWYF 87BbffTNfLfZ6TAGbYQsFiHZrQcjVYbtjPxIhxS+hyWvPV7DDtnMLHuXHB1lYaPvxMCm wgzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@svenpeter.dev header.s=fm1 header.b=RSNMLGBg; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=i9+RnVzS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=svenpeter.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x1-20020a631701000000b0039d942c5053si12621432pgl.825.2022.04.19.07.19.04; Tue, 19 Apr 2022 07:19:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@svenpeter.dev header.s=fm1 header.b=RSNMLGBg; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=i9+RnVzS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=svenpeter.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350409AbiDSJuR (ORCPT + 99 others); Tue, 19 Apr 2022 05:50:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241742AbiDSJuP (ORCPT ); Tue, 19 Apr 2022 05:50:15 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E93EBC34; Tue, 19 Apr 2022 02:47:33 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 003B75C018F; Tue, 19 Apr 2022 05:47:30 -0400 (EDT) Received: from imap47 ([10.202.2.97]) by compute2.internal (MEProxy); Tue, 19 Apr 2022 05:47:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1650361650; x=1650448050; bh=7F H/cZqwHqkstNxttHiwShTx35esBf5x9xB4oSROZV8=; b=RSNMLGBgDgANeCVu2V Q5XHDMelTAniUUIJTvqtY/gqFdq49d3ifi6JBihik0CL1OUDgw05mqp0Lpz0zCdB S+er/mNixteyESDqYCQ39ReAQ8A+leQO9puqemXGoN2Zi0w1z35IqpUzooo2VO8U Woo2Xq/3XBQny8D4RyTA6WFNi17+4VnuLzxnmdZds97G3+cQWHOx8NUYtrndOzeF GoR4xruJ1l6FB7qFpFnPRzpAYPsl9j46NGsXquuJQSrTEknQz0PlHZbJHaepc475 L8fIRYlGbsVULD6+vn4TuZNe0jCW2zsA3CvsmhM/fUwyNykatY0tE9E/vl1Bf5se 5m/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1650361650; x= 1650448050; bh=7FH/cZqwHqkstNxttHiwShTx35esBf5x9xB4oSROZV8=; b=i 9+RnVzSBgugZuECfHOZAm1xZajUYSMp4J50UH1XscbROtWy7CZbImt4vsnCWwnUm VlpB5SZxTQfcXSdNDN01myghMsKbdvumzkPaNt/mMSJgUPTPtNICGu5evM15G8wz ASnEMn33h7dmqy7/iYaPMzQHOkBZAU0sls9fnwcgU5/ka7bYzFFvPKzNidqSkuSe k3np/lZLQXva9Qqn3e6Lc/WWas0UTmjBXImqcD65lkkwamWNuoHgvRdsyPWiEPbk nZ+fu0dR/+Z+3X5BYwNTYAyrdiUIrAy4Frs7tc4a2HVhf2KPn9znXrxIogiB/E/O TgCJXAYa/R34WoNYaalQg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvddtfedgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdfuvhgv nhcurfgvthgvrhdfuceoshhvvghnsehsvhgvnhhpvghtvghrrdguvghvqeenucggtffrrg htthgvrhhnpefgieegieffuefhtedtjefgteejteefleefgfefgfdvvddtgffhffduhedv feekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsvhgvnhesshhvvghnphgvthgvrhdruggvvh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 500B22740692; Tue, 19 Apr 2022 05:47:30 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-387-g7ea99c4045-fm-20220413.002-g7ea99c40 Mime-Version: 1.0 Message-Id: <866f79b1-6c02-4248-ac98-594829fed204@www.fastmail.com> In-Reply-To: <20220419053157.GA31530@lst.de> References: <20220415142055.30873-1-sven@svenpeter.dev> <20220415142055.30873-7-sven@svenpeter.dev> <20220419053157.GA31530@lst.de> Date: Tue, 19 Apr 2022 11:47:09 +0200 From: "Sven Peter" To: "hch@lst.de" Cc: "Keith Busch" , "axboe@fb.com" , "sagi@grimberg.me" , "Hector Martin" , "Alyssa Rosenzweig" , "Rob Herring" , "Krzysztof Kozlowski" , "Arnd Bergmann" , "Marc Zyngier" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-spdx@vger.kernel.org Subject: Re: [PATCH v2 6/6] nvme-apple: Add initial Apple SoC NVMe driver Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 19, 2022, at 07:31, Christoph Hellwig wrote: > On Fri, Apr 15, 2022 at 04:20:55PM +0200, Sven Peter wrote: >> +++ b/drivers/nvme/host/apple.c >> @@ -0,0 +1,1597 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Apple ANS NVM Express device driver >> + * Copyright The Asahi Linux Contributors > > Is that actually a valid legal entity? > >> +#include > > Does this controller still not support 64-bit MMIO accesses like > the old Apple PCIe controllers or is this just a leftover? I just checked again and 64-bit accesses seem to work fine. I'll remove the lo_hi_* calls and this include. > > The rest of the code looks fine to me: > > Reviewed-by: Christoph Hellwig Thanks! Sven