Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
Subject: Re: [PATCH] docs/trans/ja_JP/howto: Don't mention specific kernel
 versions
From:   Kosuke Fujimoto <fujimotokosuke0@gmail.com>
In-Reply-To: <40b763ab-d35d-03de-9d27-bca2af56dd34@gmail.com>
Date:   Mon, 18 Apr 2022 17:26:45 +0900
Cc:     linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
        Tsugikazu Shibata <shibata@linuxfoundation.org>,
        linux-doc@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <CF4F34EC-47AD-4E6F-8A36-1EE295AE31BE@gmail.com>
References: <20220417070451.19736-1-fujimotokosuke0@gmail.com>
 <40b763ab-d35d-03de-9d27-bca2af56dd34@gmail.com>
To:     Akira Yokosawa <akiyks@gmail.com>
Precedence: bulk

Hi Yokosawa-san,=20

> On Apr 18, 2022, at 15:44, Akira Yokosawa <akiyks@gmail.com> wrote:
>=20
> Hi Fujimoto-san,
>=20
> This looks mostly good to me.
> Please find inline comments below on a couple of conventions expected =
in
> this community.
>=20
> On Sun, 17 Apr 2022 16:04:51 +0900,
> Kosuke Fujimoto wrote:
>> [PATCH] docs/trans/ja_JP/howto: Don't mention specific kernel =
versions
>=20
> It looks like patches to Chinese docs carry a simpler "docs/zh_CN:" =
prefix [1].
> So "docs/ja_JP/howto:" should suffice.

Okay, I intentionally added =E2=80=9Ctrans=E2=80=9D there, but if it=E2=80=
=99s not needed, I won=E2=80=99t add it for future commitment.

>=20
> [1]: example: =
https://lore.kernel.org/r/2fc8a76e1308e15823eebf614f35f36f322a55d3.1649384=
633.git.siyanteng@loongson.cn/
>=20
>> This change is based on commit d2b008f134b7 =
(Documentation/process/howto: Update for 4.x -> 5.x versioning)
>=20
> In changelog explanation, lines should not exceed 75 chars unless you
> have a good reason.
> The rule is stricter than the contents of documents because some of =
git
> commands auto indent changelogs by 4 spaces, and the result should fit
> in an 80-column wide terminal.
> Also, the title of the referenced commit should be enclosed in a pair
> of double quotation marks.  So this should be:
>=20
>   This change is based on commit d2b008f134b7
>   ("Documentation/process/howto: Update for 4.x -> 5.x versioning").
>=20
> [with a punctuation fix]
>=20
>> Replace "4.x kernel version" with generic term such as "mainline =
tree"
>>=20
>> Signed-off-by: Kosuke Fujimoto <fujimotokosuke0@gmail.com>
>> Cc: Jonathan Corbet <corbet@lwn.net>
>> Cc: Tsugikazu Shibata <shibata@linuxfoundation.org>
>> Cc: Akira Yokosawa <akiyks@gmail.com>
>> Cc: linux-doc@vger.kernel.org
> Please note that the above mentioned width limit does not apply to
> tags.  E.g., Fixes: and Link: tags should not wrap.
>=20
> These conventions are covered in the latter part of Section "Describe
> your changes" and Section "The canonical patch format" of
> Documentation/process/submitting-patches.rst.
>=20
> So I'd suggest that you post a v2 with the subject and changelog
> fixed.
> But please wait a few days for comments from someone else.
>=20
> With the above addressed, feel free to add:
>=20
> Reviewed-by: Akira Yokosawa <akiyks@gmail.com>
>=20
>        Thanks, Akira
>=20
>> ---
>> Documentation/translations/ja_JP/howto.rst | 43 =
++++++++++------------
>> 1 file changed, 20 insertions(+), 23 deletions(-)
>>=20
> [=E2=80=A6]
>=20

Thank you for your detail explanation, I will apply these comments and =
send v2.

Best regards,
Kosuke