Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f66e3fc3-ddf8-3223-f94c-dd98e1648a56@deltatee.com>
Date:   Mon, 18 Apr 2022 09:54:22 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-CA
To:     Yunbo Yu <yuyunbo519@gmail.com>, vkoul@kernel.org
Cc:     dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220418142021.1241558-1-yuyunbo519@gmail.com>
From:   Logan Gunthorpe <logang@deltatee.com>
In-Reply-To: <20220418142021.1241558-1-yuyunbo519@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock()
Precedence: bulk


On 2022-04-18 08:20, Yunbo Yu wrote:
> It is unnecessary to call spin_lock_bh() for you are already in a tasklet.
> 
> Signed-off-by: Yunbo Yu <yuyunbo519@gmail.com>

Ah, thanks!

Reviewed-by: Logan Gunthorpe <logang@deltatee.com>

> ---
>  drivers/dma/plx_dma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
> index 1ffcb5ca9788..12725fa1655f 100644
> --- a/drivers/dma/plx_dma.c
> +++ b/drivers/dma/plx_dma.c
> @@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
>  	struct plx_dma_desc *desc;
>  	u32 flags;
>  
> -	spin_lock_bh(&plxdev->ring_lock);
> +	spin_lock(&plxdev->ring_lock);
>  
>  	while (plxdev->tail != plxdev->head) {
>  		desc = plx_dma_get_desc(plxdev, plxdev->tail);
> @@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
>  		plxdev->tail++;
>  	}
>  
> -	spin_unlock_bh(&plxdev->ring_lock);
> +	spin_unlock(&plxdev->ring_lock);
>  }
>  
>  static void plx_dma_abort_desc(struct plx_dma_dev *plxdev)