Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933265AbXEEUdT (ORCPT ); Sat, 5 May 2007 16:33:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933330AbXEEUdT (ORCPT ); Sat, 5 May 2007 16:33:19 -0400 Received: from smtp1.linux-foundation.org ([65.172.181.25]:55289 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933265AbXEEUdT (ORCPT ); Sat, 5 May 2007 16:33:19 -0400 Date: Sat, 5 May 2007 13:33:14 -0700 (PDT) From: Linus Torvalds To: art@usfltd.com cc: linux-kernel@vger.kernel.org Subject: Re: git-tree compilation error "pci_module_init" [drivers/scsi/tmscsim.ko] undefined! In-Reply-To: <20070505092558.joq9kbhn284sc00c@67.106.77.56> Message-ID: References: <20070505092558.joq9kbhn284sc00c@67.106.77.56> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1050 Lines: 33 On Sat, 5 May 2007, art@usfltd.com wrote: > > WARNING: "pci_module_init" [drivers/scsi/tmscsim.ko] undefined! Ok, that driver needs to be converted to use "pci_register_driver()" instead of "pci_module_init()". It's probably the following one-liner, do you actually have that hardware to test? Linus --- drivers/scsi/tmscsim.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c index a583e89..3158949 100644 --- a/drivers/scsi/tmscsim.c +++ b/drivers/scsi/tmscsim.c @@ -2680,7 +2680,7 @@ static int __init dc390_module_init(void) printk (KERN_INFO "DC390: Using safe settings.\n"); } - return pci_module_init(&dc390_driver); + return pci_register_driver(&dc390_driver); } static void __exit dc390_module_exit(void) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/