Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ed643c3d-6ad0-1b3c-1fe3-9157e7aa5859@linux.ibm.com>
Date:   Tue, 19 Apr 2022 12:37:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] net/smc: sync err info when TCP connection is refused
Content-Language: en-US
To:     Tony Lu <tonylu@linux.alibaba.com>, yacanliu@163.com
Cc:     davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
        linux-s390@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, liuyacan <liuyacan@corp.netease.com>
References: <20220417123307.1094747-1-yacanliu@163.com>
 <Yl6Nnvnrvqv3ofES@TonyMac-Alibaba>
From:   Karsten Graul <kgraul@linux.ibm.com>
Organization: IBM Deutschland Research & Development GmbH
In-Reply-To: <Yl6Nnvnrvqv3ofES@TonyMac-Alibaba>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19/04/2022 12:23, Tony Lu wrote:
> On Sun, Apr 17, 2022 at 08:33:07PM +0800, yacanliu@163.com wrote:
>> From: liuyacan <liuyacan@corp.netease.com>
>>
>> In the current implementation, when TCP initiates a connection
>> to an unavailable [ip,port], ECONNREFUSED will be stored in the
>> TCP socket, but SMC will not. However, some apps (like curl) use
>> getsockopt(,,SO_ERROR,,) to get the error information, which makes
>> them miss the error message and behave strangely.
>>
>> Signed-off-by: liuyacan <liuyacan@corp.netease.com>
> 
> This fix works for me. I have tested it with curl for unavailable
> address.
> 
> This patch missed net or net-next tag, I think net is preferred.
> 
> Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>
> 
> Thank you,
> Tony Lu

Thank you both for the fix and the test!

Acked-by: Karsten Graul <kgraul@linux.ibm.com>