Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zhang, Tianfei" <tianfei.zhang@intel.com>
To:     "Wu, Hao" <hao.wu@intel.com>, "trix@redhat.com" <trix@redhat.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "Xu, Yilun" <yilun.xu@intel.com>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Matthew Gerlach" <matthew.gerlach@linux.intel.com>
Subject: RE: [PATCH v2] uio: dfl: add HSSI feature id
Thread-Topic: [PATCH v2] uio: dfl: add HSSI feature id
Thread-Index: AQHYTjZdVn4DreM1yUm1T9RcZPeV3qz069sAgAIEAlA=
Date:   Tue, 19 Apr 2022 08:25:10 +0000
Message-ID: <BN9PR11MB548330FAA7EF6B9DAC2F0E76E3F29@BN9PR11MB5483.namprd11.prod.outlook.com>
References: <20220412062353.53984-1-tianfei.zhang@intel.com>
 <DM6PR11MB38190E6EEF6DE3EB900290C585F39@DM6PR11MB3819.namprd11.prod.outlook.com>
In-Reply-To: <DM6PR11MB38190E6EEF6DE3EB900290C585F39@DM6PR11MB3819.namprd11.prod.outlook.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.401.20
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iAe4T6CSsvSjSJqU7mgX7evkBqmrY+jNrYg43ggDrAsNIMWPoLce6ag5s1rI?=
 =?us-ascii?Q?hCV3zU4jJVz+tDTcD8zRCvGWgRPNvDMxqwA6IwE8/AEi3lzpCIrI6O1fxle2?=
 =?us-ascii?Q?b333tPPwtJ+yUMxPJH6MerrKY5ZtTtT3rHVO+avfWg+3p/ta0yRcuOtjplPV?=
 =?us-ascii?Q?R0BnoZAGE/4mxQdFHrX+2tdJj0iG0svlxXZV5BcOaIBPhNNyHZbwe2zZbi5b?=
 =?us-ascii?Q?+BO180jKAcDP1q6Y/XRKAPBqzciez1uoNKnxmfcQO+7QaHrkCaeByM9wwzD5?=
 =?us-ascii?Q?R/BLEGcF9z17gTGRGPNaayZwYaLqMvctavu0JSUSkFbYI3Ok1TOvZ1EjPzl3?=
 =?us-ascii?Q?ecmINtk7E3T79FaBK/08oIPKd+m0MALHvAICjftpb8APkS3OIoCkz+i/S1zw?=
 =?us-ascii?Q?R+yrpv7W5NHXvTwWoL8+g9n2KICIMIIDD7zGQ7mh8x7n5gmibZIVS+66g+/j?=
 =?us-ascii?Q?4d9Q+nog8JDhBXZGTE7XhVW3ZEwV5zCmXQbxOR6r/BBQDb2ayn9BQwVK2A5h?=
 =?us-ascii?Q?DNchR6p7K4n4OT+DbQTCqmsh5bd/EaxVB4Sp9I5q1PiD4Kk7CD+3BTXII4Or?=
 =?us-ascii?Q?hTbGxDc6GYbduUFqj6bQwxM/RUMbCyN4y/yP2zoafj02BlAxh3fbPnnhV4bT?=
 =?us-ascii?Q?+4HAC9jJtx0zgjD7fsZ0E8dYZJzjb9Oj3uPrSfdJghSuxX9273x3jqCpuq0F?=
 =?us-ascii?Q?lYwBRa0I/HetGsM38H5jkLijyUi/TOkxyagNtq08B6SNVFN/w4EBv4KrJdOI?=
 =?us-ascii?Q?O9XJPERnPjnsF0jJjAdm1y7IiT5gweXhEAPMebNdBgE49SuD4+6ADmI7KgFQ?=
 =?us-ascii?Q?nnVYJ2hVVmQKKKBR5NJ67+ceRpAg5hHM/6Dwm5ptRR4lTmY7vdmMa6TqXL6E?=
 =?us-ascii?Q?PaKDNbsncJasYW+vHX/0AcLEFT+Asa6ie+68/KyLLj1B048vJcu3CFB0mrte?=
 =?us-ascii?Q?si/p518nOBJIeMgurJNHJ82CEc18OeM/V7OWuQllWVGZ8nkwLJdoXyXYSsUR?=
 =?us-ascii?Q?rTTYNENCI/G17NqLvLXScrOYhiVgWb8m1TtOcKM9wCEUHJPaKxXimR/r69WL?=
 =?us-ascii?Q?XgX8xj8sW5cXM0iG68f6DITljw5gG1zbiv+8dNY5su6EnGH6Rs5M9wELxtMn?=
 =?us-ascii?Q?ney3s33g5MyZPA7rwshYl0n8hgyF4JBz13sBhRoDrSfvXIvfnYHWn83/JLM+?=
 =?us-ascii?Q?DrmwqpmA1d6Se3gtYNF63dFLW+RHu1BD5S+PuJGpMI4x+XW0KbfZpK1hGfsw?=
 =?us-ascii?Q?/yhlPRzNfffrqSeLAC27/QRlQ0JAKcAneSlSNm8moeANRbLR71wY2E3kgbyh?=
 =?us-ascii?Q?ictmTaGLBOou3UNDNI1Vs6bbCaxU5GLkaGZ+FGhrFGaQ7Z406r4obkQ/Ykpj?=
 =?us-ascii?Q?rDR5iJeA2au3xChT8BGx8ccLbFWEeSs76cDiwXdhsHmpLDHjg3V2T1xI5Uqi?=
 =?us-ascii?Q?p0KfUc0fsLQ1yumUsvOkUH3XR1xL7+p72CfKC1MEbCzoq/cZo5yYs261Jkzv?=
 =?us-ascii?Q?DjORdS16yPRfltsVDYzswRD2njnTt41qchpaGpA4dWvKSqt8zoWxNT2OHfnZ?=
 =?us-ascii?Q?JdiNunUi+UP86YF41nRIGx4hzswonQBdAWmPRhDYuWgFjKl7Gw1uvdc04m50?=
 =?us-ascii?Q?Z0Epk9xnobmI5DdtiKRTXMHm0E2+e/RfshL/x6o1EpVQ8XpvyhMEeQiVJ5C3?=
 =?us-ascii?Q?LHEh+LiYDEp3rS2iSWEL6q86aL4O1sK+/Ecbbxit3BFPboFRgwu8gmZvj3lu?=
 =?us-ascii?Q?RQVaEXgq6w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06b842d5-15e2-4fbd-c788-08da21de1e9a
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 08:25:10.4856
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5Im1XdSHFtpZrN85JzOxwpRBdQ93L6mpL+anqvDtdWQ1qeoBtIGeU4mZortZLTJdDPcO8kVnBtdcx4drJ1yvGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5866
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> > -----Original Message-----
> > From: Zhang, Tianfei <tianfei.zhang@intel.com>
> > Sent: Tuesday, April 12, 2022 2:24 PM
> > To: Wu, Hao <hao.wu@intel.com>; trix@redhat.com; mdf@kernel.org; Xu,
> > Yilun <yilun.xu@intel.com>; linux-fpga@vger.kernel.org;
> > gregkh@linuxfoundation.org
> > Cc: linux-kernel@vger.kernel.org; Matthew Gerlach
> > <matthew.gerlach@linux.intel.com>; Zhang, Tianfei
> > <tianfei.zhang@intel.com>
> > Subject: [PATCH v2] uio: dfl: add HSSI feature id
> >
> > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> >
> > Add the feature id of the OFS HSSI (High Speed Serial Interface)
>=20
> We still don't see any description on what OFS is here, or will OFS be ad=
ded to
> title as well? we don't expect another submission with the same title but=
 for XXX
> HSSI again.

This name of HSSI module in dfl feature id table is : OFS HSSI subsystem.

How about this tile:
uio: dfl: add OFS HSSI device id

Add OFS HSSI (Open FPGA Stack High Speed Serial Interface) device ID in uio=
_dfl driver for Intel PAC N6000 Card.

>=20
> > subsystem to table of ids supported by the uio_dfl driver. HSSI
> > subsystem consists of harden/soft Ethernet MAC to support various
> > ethernet usages and PCS/FEC/PMA direct modes for non-ethernet usages.
> >
> > We leverage the uio_dfl driver to access the HSSI subsystem on user
> > space, because the HSSI subsystem was designed for specific purposes
> > and does not fit into the standard MAC and net kernel subsystems.
> >
> > The Feature ID table of DFL can be found:
> > https://github.com/OPAE/dfl-feature-id
>=20
> Why you put it here? even this link there is no more descriptions to unde=
rstand
> what it is. Or can be removed here.

Yes, I agree, I will remove it.
>=20
> >
> > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> > ---
> > v2: add HSSI introduction and the git repo of Feature ID table.
> > ---
> >  drivers/uio/uio_dfl.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c index
> > 89c0fc7b0cbc..660e1d0bf6b9 100644
> > --- a/drivers/uio/uio_dfl.c
> > +++ b/drivers/uio/uio_dfl.c
> > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
> > }
> >
> >  #define FME_FEATURE_ID_ETH_GROUP	0x10
> > +#define FME_FEATURE_ID_OFS_HSSI		0x15
> >
> >  static const struct dfl_device_id uio_dfl_ids[] =3D {
> >  	{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
> > +	{ FME_ID, FME_FEATURE_ID_OFS_HSSI },
> >  	{ }
> >  };
> >  MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
> > --
> > 2.26.2