Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <daf868a94da8ce7e4ee7e304db54cfee71b0174a.camel@redhat.com>
Subject: Re: [PATCH] net: ethernet: enetc: Add missing put_device() call
From:   Paolo Abeni <pabeni@redhat.com>
To:     Yihao Han <hanyihao@vivo.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com
Date:   Tue, 19 Apr 2022 10:22:34 +0200
In-Reply-To: <20220415133633.87127-1-hanyihao@vivo.com>
References: <20220415133633.87127-1-hanyihao@vivo.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2022-04-15 at 06:36 -0700, Yihao Han wrote:
> A coccicheck run provided information like the following.
> 
> drivers/net/ethernet/freescale/enetc/enetc_pf.c:1180:1-7:
> ERROR: missing put_device; call of_find_device_by_node
> on line 1174, but without a corresponding object release
> within this function.
> 
> Generated by: scripts/coccinelle/free/put_device.cocci
> 
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
>  drivers/net/ethernet/freescale/enetc/enetc_pf.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pf.c b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
> index a0c75c717073..d6e18afda69a 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc_pf.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
> @@ -1177,6 +1177,7 @@ static int enetc_pf_register_with_ierb(struct pci_dev *pdev)
>  	if (!ierb_pdev)
>  		return -EPROBE_DEFER;
>  
> +	put_device(ierb_pdev);

put_device() gets a 'struct device' argument, e.g. ierb_pdev->dev.

Have a look at the patchwork checks they catch this sort of issue.

>  	return enetc_ierb_register_pf(ierb_pdev, pdev);

enetc_ierb_register_pf() uses/dereference ierb_pdev, you need to
release the device reference after the above call, or you may hit UaF,
I guess.

Thanks,

Paolo