Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933770AbXEEVXS (ORCPT ); Sat, 5 May 2007 17:23:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933674AbXEEVXS (ORCPT ); Sat, 5 May 2007 17:23:18 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:47555 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933770AbXEEVXR (ORCPT ); Sat, 5 May 2007 17:23:17 -0400 Date: Sun, 6 May 2007 00:23:15 +0300 (EEST) From: Pekka J Enberg To: Frederik Deweerdt cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [-mm patch] do_revoke error handling (was Re: 2.6.21-mm1) In-Reply-To: <20070505211318.GA28912@slug> Message-ID: References: <20070505014955.8f3990b5.akpm@linux-foundation.org> <20070505211318.GA28912@slug> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1108 Lines: 24 On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21/2.6.21-mm1/ > > > fs/revoke.c: In function 'do_revoke': > fs/revoke.c:563: warning: 'details.fset' may be used uninitialized in this function > fs/revoke.c:563: warning: 'details.restore_start' may be used uninitialized in this function On Sat, 5 May 2007, Frederik Deweerdt wrote: > It seems that we should goto 'out_free_table' if an error happens in > the mainloop. Otherwise 'details' is passed to restore_files() without > being initialized. Good catch. The patch is wrong, though. Wwe must restore the file descriptors in case revoke fails; otherwise we'll leave non-revoked files hanging. The proper fix is to move initialization before the do_each_thread() bit. Care to make a new patch, Frederik? Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/