Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Apr 2022 18:23:26 +0800
From:   Tony Lu <tonylu@linux.alibaba.com>
To:     yacanliu@163.com
Cc:     kgraul@linux.ibm.com, davem@davemloft.net, kuba@kernel.org,
        pabeni@redhat.com, linux-s390@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        liuyacan <liuyacan@corp.netease.com>
Subject: Re: [PATCH] net/smc: sync err info when TCP connection is refused
Message-ID: <Yl6Nnvnrvqv3ofES@TonyMac-Alibaba>
Reply-To: Tony Lu <tonylu@linux.alibaba.com>
References: <20220417123307.1094747-1-yacanliu@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220417123307.1094747-1-yacanliu@163.com>
Precedence: bulk

On Sun, Apr 17, 2022 at 08:33:07PM +0800, yacanliu@163.com wrote:
> From: liuyacan <liuyacan@corp.netease.com>
> 
> In the current implementation, when TCP initiates a connection
> to an unavailable [ip,port], ECONNREFUSED will be stored in the
> TCP socket, but SMC will not. However, some apps (like curl) use
> getsockopt(,,SO_ERROR,,) to get the error information, which makes
> them miss the error message and behave strangely.
> 
> Signed-off-by: liuyacan <liuyacan@corp.netease.com>

This fix works for me. I have tested it with curl for unavailable
address.

This patch missed net or net-next tag, I think net is preferred.

Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>

Thank you,
Tony Lu