Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2440b3f3-6961-4091-438f-7120b9177164@linux.ibm.com>
Date:   Mon, 18 Apr 2022 10:23:38 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] s390: vfio-ap: Remove the superfluous MODULE_DEVICE_TABLE
 declaration
Content-Language: en-US
To:     Thomas Huth <thuth@redhat.com>, Halil Pasic <pasic@linux.ibm.com>,
        Jason Herne <jjherne@linux.ibm.com>, linux-s390@vger.kernel.org
Cc:     Harald Freudenberger <freude@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        linux-kernel@vger.kernel.org
References: <20220413094416.412114-1-thuth@redhat.com>
From:   Tony Krowiak <akrowiak@linux.ibm.com>
In-Reply-To: <20220413094416.412114-1-thuth@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Precedence: bulk

Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>

On 4/13/22 5:44 AM, Thomas Huth wrote:
> The vfio_ap module tries to register for the vfio_ap bus - but that's
> the interface that it provides itself, so this does not make much sense,
> thus let's simply drop this statement now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   See also my previous patch to register it for the "ap" bus instead:
>   https://lore.kernel.org/linux-s390/20211201141110.94636-1-thuth@redhat.com/
>   ... but since it has been decided to not auto-load the module uncondi-
>   tionally, I'd like to suggest to rather drop this line now instead.
>
>   drivers/s390/crypto/vfio_ap_drv.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 29ebd54f8919..4ac9c6521ec1 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -46,8 +46,6 @@ static struct ap_device_id ap_queue_ids[] = {
>   	{ /* end of sibling */ },
>   };
>   
> -MODULE_DEVICE_TABLE(vfio_ap, ap_queue_ids);
> -
>   static struct ap_matrix_mdev *vfio_ap_mdev_for_queue(struct vfio_ap_queue *q)
>   {
>   	struct ap_matrix_mdev *matrix_mdev;