Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp3838526pxb; Tue, 19 Apr 2022 10:47:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0KcKPXLpreco5bTKWoPPyLIhi8dB4n0n9FvkxR5A+PpHWt0PMtB3gw7USc28x5o38fj1B X-Received: by 2002:a05:6402:298b:b0:41d:675f:8b44 with SMTP id eq11-20020a056402298b00b0041d675f8b44mr18671252edb.377.1650390435000; Tue, 19 Apr 2022 10:47:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650390434; cv=none; d=google.com; s=arc-20160816; b=RFZKWIVVMIuhBmpiMWId8P9oS/oBS9/m6E4T3Hgyw6ET2gumWzJia4ikLms6p9f1Dw BbzUGbYeXr3JNcRLgoTG4zmgdNyDGJZKBaVSLDbS8CtpEJ+rhjHvAvpY+Jbxyxu5m1HD lO5ZyOS610OWICqa5z7vFOmHH1Kl2sPpNLoKAiWEqf0HS8aa2UDh6eRPZ9jD/QawAcDY 2MM44cuUkUcYliVcTbgnQmb+UDBbkQS9VLjpug/ML2VRByko+mpDKLsl3AP6fGULQ65v FFCoWQz5Sf6fd0x34q2aDR/dzeIYn83IgzQmk3n/PLrmaaL1pZ4RxT7pDcPoH116x1k7 AEFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=E0j6qyaBIWogQyCvYV0oY2iEmpHbTUs/BPcpOttMJ30=; b=r43y0Q5BLHPAyj2PO+KkPHrjjS6+hNzNJyV8c1YT95pFAafUEupSqrmYbvrcWXFwP5 eaLqFkiy312uCLHuV+6Se2BgYXSpb9FtBKY6D6TuOR/OmepwDH2bNmbyZvMBAn/4Io7j LEBv0g1TeKt79PQN+lLlcf61b6QA0dC3D6LU8QrZWxauJv8TDlsQg1mDIR+POUecz2r6 wgtt7x/84b46DgaIHKq3nytK9qLAgUBvwf0/hH2Wb5BVRwF4uPBENrNfBAJ0EL7hNX7S zCRgqYGwPNMJAzEGo4QvFKshcgmQHKxO/F8irVqVD2oLd5tJf+6C6+n5U6BwJ8m/8bIq f+wA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="g8uV//ZJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lb10-20020a170907784a00b006e8046cba4asi8631569ejc.914.2022.04.19.10.46.48; Tue, 19 Apr 2022 10:47:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="g8uV//ZJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238960AbiDRMaZ (ORCPT + 99 others); Mon, 18 Apr 2022 08:30:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238998AbiDRM1h (ORCPT ); Mon, 18 Apr 2022 08:27:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D63FB1DA6E; Mon, 18 Apr 2022 05:21:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8CD4BB80EDA; Mon, 18 Apr 2022 12:21:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD0E8C385A1; Mon, 18 Apr 2022 12:21:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650284464; bh=5hLQUV35+tzlBH6zdxatGjjvCJQpxT0R3ebZCnvvka8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g8uV//ZJiWpvEgrAKhn3LqygY/wcVpREwtV0eSwMmuf5UOtVAg9G5L507yBnc7EWx toKsBJlXtbPQ3Ofzu8PRKDqaYkBcv8FHui8suKDA+xffTeAh3aRan5imUkj8HLEiP9 Dk7B3MuSvm4gvTjBSKZn/UZt996DpZTVbun7eR/k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Dumazet , Antoine Tenart , Paolo Abeni , Sasha Levin Subject: [PATCH 5.17 123/219] tun: annotate access to queue->trans_start Date: Mon, 18 Apr 2022 14:11:32 +0200 Message-Id: <20220418121210.340561914@linuxfoundation.org> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220418121203.462784814@linuxfoundation.org> References: <20220418121203.462784814@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Antoine Tenart [ Upstream commit 968a1a5d6541cd24e37dadc1926eab9c10aeb09b ] Commit 5337824f4dc4 ("net: annotate accesses to queue->trans_start") introduced a new helper, txq_trans_cond_update, to update queue->trans_start using WRITE_ONCE. One snippet in drivers/net/tun.c was missed, as it was introduced roughly at the same time. Fixes: 5337824f4dc4 ("net: annotate accesses to queue->trans_start") Cc: Eric Dumazet Signed-off-by: Antoine Tenart Reviewed-by: Eric Dumazet Link: https://lore.kernel.org/r/20220412135852.466386-1-atenart@kernel.org Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/tun.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index de999e0fedbc..aa78d7e00289 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -1106,7 +1106,7 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, struct net_device *dev) /* NETIF_F_LLTX requires to do our own update of trans_start */ queue = netdev_get_tx_queue(dev, txq); - queue->trans_start = jiffies; + txq_trans_cond_update(queue); /* Notify and wake up reader process */ if (tfile->flags & TUN_FASYNC) -- 2.35.1