Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Apr 2022 18:06:19 +0200
From:   Max Kellermann <mk@cm4all.com>
To:     David Howells <dhowells@redhat.com>
Cc:     Max Kellermann <mk@cm4all.com>, linux-cachefs@redhat.com,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: fscache corruption in Linux 5.17?
Message-ID: <Yl7d++G25sNXIR+p@rabbit.intern.cm-ag>
References: <YlWWbpW5Foynjllo@rabbit.intern.cm-ag>
 <507518.1650383808@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <507518.1650383808@warthog.procyon.org.uk>
Precedence: bulk

On 2022/04/19 17:56, David Howells <dhowells@redhat.com> wrote:
> This is weird.  It looks like content got slid down by 31 bytes and 31 zero
> bytes got added at the end.  I'm not sure how fscache would achieve that -
> nfs's implementation should only be dealing with pages.

Did you read this part of my email?:

On 2022/04/12 17:10, Max Kellermann <max@rabbit.intern.cm-ag> wrote:
> The corruption can be explained by WordPress commit
> https://github.com/WordPress/WordPress/commit/07855db0ee8d5cff2 which
> makes the file 31 bytes longer (185055 -> 185086).  The "broken" web
> server sees the new contents until offset 184320 (= 45 * 4096), but
> sees the old contents from there on; followed by 31 null bytes
> (because the kernel reads past the end of the cache?).

My theory was that fscache shows a mix of old and new pages after the
file was modified.  Does this make sense?

Is there anything I can do to give you data from this server's cache?