Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp3987348pxb; Tue, 19 Apr 2022 14:15:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzV1Kc1mSTkOT5kLmNoI6TN3J+kZMpjYop71wjWWN3+rVWoPuq3y6C8j299jb9y1lOizQ3l X-Received: by 2002:a17:906:1692:b0:6e8:7641:c620 with SMTP id s18-20020a170906169200b006e87641c620mr15043827ejd.183.1650402914680; Tue, 19 Apr 2022 14:15:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650402914; cv=none; d=google.com; s=arc-20160816; b=h8q/EBzsiuOciTUdqQlw/vM6H6sovX5rqnnYwK9wJW6f8Wuh920/ZtceDj5aZgypxh DPlRe4uiPAE17hWEv8eXqN4OPmdNo5DTEN8OAasYfhrGZCJIMod0t5hg95k6V4R7F3wS tKXxMGGqiiVdgQGNRysMNs066guEETv6ijSk1cim0I5kZW9bXSs5h9ogAi8AKncYVz5N C0RU8mR6ioINAl1bkjnwFJw0onpCdUCxLiQ4x/MSaYrnpKIXYlFvs58wkk/tO5ju8nKR xVzW/3ZSiZWmLfq7A6x+KrcLLX8FVzmaFi4THqG8bQI8JYoyb9CcRdUmQVzRPc5CzOD6 esng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=FgfhznoEwlI1gZ4RwiNHpMGAMQaG/XKY7H6WtjqDG8M=; b=uKUjIkCFpMoKBExSYWLPbisfgUUzQ4nmOF5UQX60Uzj3PRF5sayY9sWrYE50RWnIXm Sq3VTvLgpi3q0wVgAxuwhSfPaWRahIl3MXCyje2XFDE8lqheiI7agVWFDMvGwocNDxVg 2RssrUfrKT84iYqO2Q2NDEjf7AdGmou0a42GPxp3pKzd3H0IgZpyU/v0dOYa0aeo+fAw Vs9gapI0rwfCiGnKk931dPgAasyqXrGUUV1Fd1hM7H7rYCSA3C9ApLfspQGF1Y6r8F3V YV8dqEIHm/YmQpW6yJFVGsslm57pl/Qlsrqf2138MFu987bAJKif99U9BF6VXwbjIs9O FzkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lHoVeiM8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d18-20020a50cd52000000b00418eda94104si9066027edj.490.2022.04.19.14.14.43; Tue, 19 Apr 2022 14:15:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lHoVeiM8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237639AbiDRKVB (ORCPT + 99 others); Mon, 18 Apr 2022 06:21:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237634AbiDRKU6 (ORCPT ); Mon, 18 Apr 2022 06:20:58 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C8E419034; Mon, 18 Apr 2022 03:18:20 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id k29so18060419pgm.12; Mon, 18 Apr 2022 03:18:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FgfhznoEwlI1gZ4RwiNHpMGAMQaG/XKY7H6WtjqDG8M=; b=lHoVeiM8H9bA2eBLAqPdQQ0GNfndniP6f54WpBLOiATsNbv3uH/gzQYz+y3A3hTd02 62azlrYt/zWYfbNvTk/dU7zval1wXAH6IhhY1QCODzCh9g7USBWH7pSJzKwnDKvni5n+ vSLUZ1cKGVj68Jo+bkjlM4fDt3T0qvz/OE82UwQcASNQ34lfxFh9Q5o8A+XYzBye5iPw rBVsiYkEhiMyeertPSU80kW0JKZT1jp6mG0SDyrKAbat3SncZ7S6VGfZDEMUHDWaQrql 0CF7/IQHCptHRqlk2eYj0xFfXt0Nnt8YRk88GRWweQcMEWvIjdu7S9/qhtb4ihBXIEvD 3yug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FgfhznoEwlI1gZ4RwiNHpMGAMQaG/XKY7H6WtjqDG8M=; b=Z0k+UQo0j1mhzwKpOAf4s3x980BEsKVxiux+kbEqJvZ30KHjQorh3bl8MriQjsC73J 0iIWGCeIpxnCa/D8t33oqMznEdNEt9JazjuxCE3vW5sRkZc2F4gdZrEHFySOf6gsQiCo M8HwlvaMEJOKwzbBtO4zwC8kDmLdsdGkrP5RS+1YLutRpiGjc53eMBuyJi2AXQFrQ5XF KW1Pf1pMaRMUVmyYkIoCU6m27P/lnMUsNDBdCtHm519qAgfauHgmdHmSMq1swuUx8tdW PxvIKPGikwLZ9UdkRBtnt9Zf1plOF2j5/3W3VTUXM2bZBM6C2NR35Tsm+yELz8zbWARP r/Bw== X-Gm-Message-State: AOAM533HJ8kNykBrF8Ku0nFOk4sf8fNAH0OLjN9NH7LktffCGgcJh+AZ 7vMgt8Zdz647/sJVFtHlrSQ8XQDwFPV6LZ52 X-Received: by 2002:a05:6a00:1a91:b0:4fa:b21d:2ce with SMTP id e17-20020a056a001a9100b004fab21d02cemr11519916pfv.75.1650277099931; Mon, 18 Apr 2022 03:18:19 -0700 (PDT) Received: from localhost.localdomain ([103.84.139.165]) by smtp.gmail.com with ESMTPSA id y6-20020a626406000000b005060889f2cdsm12011331pfb.191.2022.04.18.03.18.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 03:18:19 -0700 (PDT) From: Hangyu Hua To: bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, arnaud.pouliquen@foss.st.com Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Hangyu Hua Subject: [PATCH] rpmsg: virtio: fix possible double free in rpmsg_virtio_add_ctrl_dev() Date: Mon, 18 Apr 2022 18:17:24 +0800 Message-Id: <20220418101724.42174-1-hbh25y@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org vch will be free in virtio_rpmsg_release_device() when rpmsg_ctrldev_register_device() fails. There is no need to call kfree() again. Fixes: c486682ae1e2 ("rpmsg: virtio: Register the rpmsg_char device") Signed-off-by: Hangyu Hua --- drivers/rpmsg/virtio_rpmsg_bus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c index 603233f0686e..3b7b47f785cf 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -851,7 +851,6 @@ static struct rpmsg_device *rpmsg_virtio_add_ctrl_dev(struct virtio_device *vdev err = rpmsg_ctrldev_register_device(rpdev_ctrl); if (err) { - kfree(vch); return ERR_PTR(err); } -- 2.25.1