Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp4037226pxb; Tue, 19 Apr 2022 15:32:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzauXYcvLAMx36kfkWaqVpE9ovNrUX800nYRaqXXR1TrdegdXJOCb8YCwIK17J+aI67mvcw X-Received: by 2002:a17:906:58d1:b0:6ef:c915:bb54 with SMTP id e17-20020a17090658d100b006efc915bb54mr8272458ejs.253.1650407566803; Tue, 19 Apr 2022 15:32:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650407566; cv=none; d=google.com; s=arc-20160816; b=b4rq0cOaRPDHTV1Vb6DNfWM9eSYbwjpQslXnW+VlnZdOMXnhcVnt9/womfTnnrDh2X +5y65Fr3y12sFj40xRIAR2maoWAcGttDNswSEu47fXWmbEjdUEtbxiKy+2HjH0//7YgW zRAjoUq8xvpkifBAF8Gs6d0NO3g35GuwxRl6QJ17xVpDGdedDZdil4UuZ7N5H4MUlJQg iPZJzFdmv+2S2bZLGJbS2AwTXJhXejTOo2oH5Otd8OuhUZ3f8ungfFaXkQdJ1jqLD3Ob wWOTsL/muUtlDLmbHbKGmYQO7HitZTTUDx1mxWKzA238SvkEYkohC2BW54tqFX9FSc7R RlrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yW/Xtlm2DEmdlcKAJWnGvn+AxAEQ2Q/PaAl/FxXatQg=; b=OPGlSlx0vG3X+tyTJSa1xo88HaaAChuvRlJxShfHCqHpcMUbZ6ht48ZaekNSz6CNX2 K5FagZMo+gsLI73gYrqy2KFCC67Ks9BUWCCgUVdw1gMYn3nGxNqlHQ6usXFajHICiJOx TYIKWunwFif6vbjImB3ISE1bdtz1ySXC0053TUObn6EK40TPqARqRPKbxFtdZ4+dHuyE 1//P4KLrfXHVkkZOqjb3oiThMWspnQ7LinAplDS6M6/hhsf5reKqF0il4VQ8xMZEXGPz 48h+UhEbo6vY/xE26aTJMgBBzpApUfCli1McZES61Y7C+YmlTFeqb0ACqbJNbHwdp/0n sifA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="JV/CeTBT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n20-20020a1709067b5400b006e87b7b8461si459559ejo.60.2022.04.19.15.32.23; Tue, 19 Apr 2022 15:32:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="JV/CeTBT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347939AbiDRVOQ (ORCPT + 99 others); Mon, 18 Apr 2022 17:14:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234528AbiDRVOP (ORCPT ); Mon, 18 Apr 2022 17:14:15 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D1A72CC9D for ; Mon, 18 Apr 2022 14:11:33 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id w1so2721249lfa.4 for ; Mon, 18 Apr 2022 14:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yW/Xtlm2DEmdlcKAJWnGvn+AxAEQ2Q/PaAl/FxXatQg=; b=JV/CeTBTDxZdIEZG5+RJY0irjC2pJax7Y3KJMpq7gZl5CU7YUloKLzx+QCW4CfmW55 9Oz7lZ8Att8s3JZ/bA7bXUMRScOMu4tvhUofd85ED8UuFme5d2Huk3M4Ah8wra0pkiYb 16GPSmTusg86p1fixswzzHNZPLMqwo08ove0Lv+FLpDgZc09NP4g8kUEY/v1Cv0sUbgP GbN3CPFN2x5EMoWTwAVB2JnFwE5zE/Y4rwXiyryhryWK+7QjFxp5/q39lHvHthnFgixm QyaGaHj2QubGxAf94ssvYNyqQyPb149btYKXQEACTGS+E+0MmmGLki1p1HnSSv3Q3mX8 HdWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yW/Xtlm2DEmdlcKAJWnGvn+AxAEQ2Q/PaAl/FxXatQg=; b=jkEmrSx5cn20RZfWG0cXm47ab+pzHclb+WficYPow6Q+N8qJVdwGaYUBIDVFz6CzvK ckbPJrCVzK2LFNncVd4O1Fp9Q/yWLiiZkMQvWcnFXTVdz3iPPnbSBQk2JWcK42c0sOO3 RYuvA0Qlj7hpgmM0mbV1hc8RLniwI+fvgAooCh/+WTuHJdvqKRFZ6YvSV7w5PmxdGfk1 XW6BxobztmqAF2xqrVzNFnt4BVJ0TQ4qvOij6YWzrQg50Lv56wYocbC1rp5lpE59fYGa GJJH2FMf30Ktl9iRFYiOAbV1sZQomEXpeuOfDtB6bXUXmrnifLQfp/fr09ampLaavxto S38Q== X-Gm-Message-State: AOAM530tCpfVZZ827cv1oROXF8tD1Hc/BPGsQ5DXj/n3a77vHCPh3p1i hVGIHP8lmSy+ZSQJSE97fOE= X-Received: by 2002:ac2:491d:0:b0:46d:ce9:69b2 with SMTP id n29-20020ac2491d000000b0046d0ce969b2mr9001484lfi.40.1650316291694; Mon, 18 Apr 2022 14:11:31 -0700 (PDT) Received: from localhost ([46.188.51.232]) by smtp.gmail.com with ESMTPSA id x40-20020a056512132800b004489691436esm1319222lfu.146.2022.04.18.14.11.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 14:11:31 -0700 (PDT) Date: Tue, 19 Apr 2022 00:11:13 +0300 From: Alexander Fomichev To: Dave Jiang Cc: ntb@lists.linux.dev, linux@yadro.com, Jon Mason , Allen Hubbe , Yang Li , Serge Semin , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ntb_perf: extend with burst/poll/doorbell latency measurement Message-ID: <20220418211113.oxidrif4jtjlqr2r@yadro.com> References: <20220417235517.26865-1-a.fomichev@yadro.com> <9ad57247-36df-cb3d-d50f-feb3c80f17e6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9ad57247-36df-cb3d-d50f-feb3c80f17e6@intel.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 18, 2022 at 07:52:50AM -0700, Dave Jiang wrote: > > I don't see any major issues with the code. However, is it possible to break > the introduction of these 3 metrics into 3 different patches for easier > review? > Sure. I'll re-post the separate patches soon. -- Regards, Alexander