Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp4045976pxb; Tue, 19 Apr 2022 15:46:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxC1uB3eg3rn4376hsnSZW1LSbF9rERT5WBNhThIN7gmQJJa1nHpb2AdzJup00Pwqlvp74j X-Received: by 2002:a65:5542:0:b0:39d:5471:9d39 with SMTP id t2-20020a655542000000b0039d54719d39mr16394711pgr.358.1650408373177; Tue, 19 Apr 2022 15:46:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650408373; cv=none; d=google.com; s=arc-20160816; b=Vv7ChOxa+VZtOLQMYQs6II9LppBMhsxsse4ch5lvGhoBvAKF1PvAoDQQzKM0vqtqgo lepJwQupp4a6NSuklp8swJJlsITnUCfzx7EPRDFuS/kOwqEvtC4E4dojJvuS4uy20Md2 PGM4OSbIYg5QHzAoY3gOlVJM0h8SIxNW8fZS4sJGNCcJxfqfObb6p7OPgbweJabeccoD gv44tEFVkw0TZz+S1pNiEd45yg5Sv6f2UzPlcTUnGszfgn0t6rj/XbTmZrgXFULL37NV Z8m9A/qXqk2PKoQ3ejGGuXKPTwfVcTaorvFuUaVDvbGbeHShBMisVcAPdtQm0CyE/U8g bosw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=vBORQz77RThbETo+puUUWcHVCJQc7CVNPdVtOfH4Hu4=; b=sfVtDVwbXyikzVr0srS6MT/KEvU5UsCY+Vh2Y3yeZJC2eJX/MMDwb7j5miNVJ9++nY tq+zAXjMkj21vqCNNcJy9zcQ1zJnwd8fRpanh7xH8SZTB+yjVhHsvUL+34oez7s0yK4s nPQbv+fHiktp8L4kFpNu23jX39x1BgSksGRm3H+RfvzC2GuRG/C/9mkfQt/8scFaIGSq pfLZT+qyUDJ/xobZtCCtkkn+3thO8XrNyrNLOOWPLuvrREPvbjhIMvnVO4LXzoeJmN7E c3gVc2CnZPyn/tVG+GpPy5BwrciYISVDfVLSQ0586/WHPcjCSlAeHPBizpqc/SR232cm 030g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=Uh8OWS6m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t3-20020a635f03000000b0039d9a13b8b1si618150pgb.135.2022.04.19.15.45.43; Tue, 19 Apr 2022 15:46:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=Uh8OWS6m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345041AbiDSTOX (ORCPT + 99 others); Tue, 19 Apr 2022 15:14:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229772AbiDSTOT (ORCPT ); Tue, 19 Apr 2022 15:14:19 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D59083A72B; Tue, 19 Apr 2022 12:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1650395496; x=1681931496; h=from:to:cc:subject:date:message-id:mime-version; bh=vBORQz77RThbETo+puUUWcHVCJQc7CVNPdVtOfH4Hu4=; b=Uh8OWS6mMhgg7GSKMOO3MHHy7U4pjQxnpDpdhb5/dJ3gqVSWakWt1BjB QtfLDxVfZF25dZ5jrIgLD/0su6YuX0ik4ed15OmziM0EQEo5TiwRRRMfN Klv4rSeLy0Xk/73dQVEchnEwy3AwOVmkg2inOzbD5FzZvt+fQaAcNZ7/h E=; Received: from ironmsg09-lv.qualcomm.com ([10.47.202.153]) by alexa-out.qualcomm.com with ESMTP; 19 Apr 2022 12:11:35 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg09-lv.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 12:11:34 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 19 Apr 2022 12:11:33 -0700 Received: from c-sanm-linux.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 19 Apr 2022 12:11:27 -0700 From: Sandeep Maheswaram To: Rob Herring , Andy Gross , "Bjorn Andersson" , Greg Kroah-Hartman , Felipe Balbi , Stephen Boyd , Doug Anderson , "Matthias Kaehlcke" , Mathias Nyman , Krzysztof Kozlowski , "Rafael J . Wysocki" , Len Brown , Pavel Machek CC: , , , , , , , , , Sandeep Maheswaram Subject: [PATCH v14 0/7] USB DWC3 host wake up support from system suspend Date: Wed, 20 Apr 2022 00:41:03 +0530 Message-ID: <1650395470-31333-1-git-send-email-quic_c_sanm@quicinc.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Avoiding phy powerdown in host mode when wakeup capable devices are connected, so that it can be wake up by devices. Keep usb30_prim gdsc active to retain controller status during suspend/resume. Changes in v14: Added patch for device_children_wakeup_capable. Used device_children_wakeup_capable instead of usb_wakeup_enabled_descendants. Fixed minor nit picks in v13 reported by Matthias. Changes in v13: Moved the dt bindings patch to start. Changed dwc3_set_phy_speed_mode to dwc3_check_phy_speed_mode. Check wakep-source property for dwc3 core node to set the wakeup capability. Drop the device_init_wakeup call from runtime suspend and resume. Added GENPD_FLAG_RPM_ALWAYS_ON and set GENPD_FLAG_ALWAYS_ON if wakeup is supported. Changes in v12: Squashed PATCH 1/5 and 2/5 of v11. Added dt bindings and device tree entry for wakeup-source property for dwc3 core node. Dropped redundant phy_set_mode call. Changes in v11: Moving back to v8 version https://patchwork.kernel.org/project/linux-arm-msm/cover/1624882097-23265-1-git-send-email-sanm@codeaurora.org as we are getting interrupts during suspend when enabling both DP hs phy irq and DM hs phy irq. Moved the set phy mode function to dwc3/core.c from xhci-plat.c We didn't find any other option other than accessing xhci from dwc. Changes in v10: PATCH 1/6: Change device_set_wakeup_capable to device_set_wakeup_enable PATCH 2/6: Remove redundant else part in dwc3_resume_common PATCH 4/6: Change the irg flags PATCH 5/6: Set flag GENPD_FLAG_ALWAYS_ON PATCH 6/6: Remove disable interrupts function and enable interrupts in probe. Changes in v9: Checking with device_may_makeup property instead of phy_power_off flag. Changed the IRQ flags and removed hs_phy_mode variable. Changes in v8: Moved the dwc3 suspend quirk code in dwc3/host.c to xhci-plat.c Checking phy_power_off flag instead of usb_wakeup_enabled_descendants to keep gdsc active. Changes in v7: Change in commit text and message in PATCH 1/5 and PATCH 5/5 as per Matthias suggestion. Added curly braces for if and else if sections in PATCH 4/5. Changes in v6: Addressed comments in host.c and core.c Separated the patches in dwc3-qcom.c to make it simple. Dropped wakeup-source change as it is not related to this series. Changes in v5: Added phy_power_off flag to check presence of wakeup capable devices. Dropped patch[v4,4/5] as it is present linux-next. Addressed comments in host.c and dwc3-qcom.c. Changes in v4: Addressed Matthias comments raised in v3. Changes in v3: Removed need_phy_for_wakeup flag and by default avoiding phy powerdown. Addressed Matthias comments and added entry for DEV_SUPERSPEED. Added suspend_quirk in dwc3 host and moved the dwc3_set_phy_speed_flags. Added wakeup-source dt entry and reading in dwc-qcom.c glue driver. Changes in v2: Dropped the patch in clock to set GENPD_FLAG_ACTIVE_WAKEUP flag and setting in usb dwc3 driver. Separated the core patch and glue driver patch. Made need_phy_for_wakeup flag part of dwc structure and hs_phy_flags as unsgined int. Adrressed the comment on device_init_wakeup call. Corrected offset for reading portsc register. Added pacth to support wakeup in xo shutdown case. Matthias Kaehlcke (1): PM / wakeup: Add device_children_wakeup_capable() Sandeep Maheswaram (6): dt-bindings: usb: dwc3: Add wakeup-source property support usb: dwc3: core: Host wake up support from system suspend usb: dwc3: qcom: Add helper functions to enable,disable wake irqs usb: dwc3: qcom: Configure wakeup interrupts during suspend usb: dwc3: qcom: Keep power domain on to retain controller status arm64: dts: qcom: sc7280: Add wakeup-source property for USB node .../devicetree/bindings/usb/snps,dwc3.yaml | 5 ++ arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 + drivers/base/power/wakeup.c | 18 +++++ drivers/usb/dwc3/core.c | 33 ++++---- drivers/usb/dwc3/core.h | 4 + drivers/usb/dwc3/dwc3-qcom.c | 91 +++++++++++++--------- drivers/usb/dwc3/host.c | 24 ++++++ include/linux/pm_wakeup.h | 7 ++ 8 files changed, 133 insertions(+), 50 deletions(-) -- 2.7.4